Hi Gerd,

Thanks,
Chao

On 2024/3/14 19:22, Gerd Hoffmann wrote:

Hi,

+[Sources.LoongArch64]
+  LoongArch/DxeExceptionLib.c
+  LoongArch/ExceptionCommon.h
+  LoongArch/ExceptionCommon.c
+  LoongArch/LoongArch64/ArchExceptionHandler.c
+  LoongArch/LoongArch64/ExceptionHandlerAsm.S | GCC

Hmm, if all code is in an arch-specific subdirectory anyway yet another
directory level for the asm code looks unnecessary to me.

It is not a directory that only holds ASM code, it is a private folder of LoongArch64, this library may support the LoongArch32 in the future, so it is designed this way.


The code looks reasonable overall.  Can't comment on loongarch specific
details though.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_