From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ACCDFAC0C63 for ; Fri, 15 Mar 2024 06:20:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bs8apZNzIPJRrZJVH69cRAuyEqItci44Au3k5bq9Iis=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710483611; v=1; b=5VzHkD60jenzFuIOIz4rLOzpguBF9U3arzwPQ0nw6dnx1tjOD8YEWAuAfEUH6FUfoscREQml ykdlqQ7+VlHaQZka5dE7rPON797GLD+oNjSNjdXl/mPRfgdCo4A5dmbjuN8IYMf+5pBUkRTKa3H 0aEnFBnmCsPzCpysetcc3iCDARO5MkNKVDlJm+OmKQzTITMluWHFoEjfDjc7oVY2GEXsd5V7fOP /6O+XWK/NGtgB9EJGBwJ8iuN3yngwATwdgUNO8PeZxAGhUEvfkFvQNLh4GD1uPkg2MlU5GXybzr VoNX/IRFNlSPAXQGxUVwqh2+2mXaCWtoH0dWEeHV2SGNA== X-Received: by 127.0.0.2 with SMTP id nX1JYY7687511x2Uln8Gi7UT; Thu, 14 Mar 2024 23:20:11 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.14362.1710483609908924677 for ; Thu, 14 Mar 2024 23:20:10 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxJ+iX6PNlc18ZAA--.41405S3; Fri, 15 Mar 2024 14:20:07 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxHs+V6PNlsLtaAA--.41958S3; Fri, 15 Mar 2024 14:20:05 +0800 (CST) Message-ID: <2544c82d-5591-4551-bd74-57e372c74680@loongson.cn> Date: Fri, 15 Mar 2024 14:20:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 06/26] UefiCpuPkg: Add CPU exception library for LoongArch To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ray Ni , Rahul Kumar , Baoqi Zhang References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093759.1253558-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8AxHs+V6PNlsLtaAA--.41958S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQARCGXytWcNeAACsq X-Coremail-Antispam: 1Uk129KBj9xXoWruryUGrWrZF1UXrykCrWDWrX_yoWkZFcEgr nxZFyrJr98Xr1agrn2qr90yrZ8K3Z7ZrW5K3s7Xr4xAw4kJr4qyFs7Gw1jqr1IqasxAr4D GrZ3KF4DAr1I9osvyTuYvTs0mTUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjDUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbzkYFVCjjxCrM7AC 8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr v_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AK xVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIE14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUAVWUtw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x07U_uc_UUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 23:20:10 -0700 Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vj0qV7M7ZCsalMy11qE5jB2Ex7686176AA= Content-Type: multipart/alternative; boundary="------------ZX7T6Hpnmw7xZxgXLBk16sH8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=5VzHkD60; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------ZX7T6Hpnmw7xZxgXLBk16sH8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Gerd, Thanks, Chao On 2024/3/14 19:22, Gerd Hoffmann wrote: > Hi, > >> +[Sources.LoongArch64] >> + LoongArch/DxeExceptionLib.c >> + LoongArch/ExceptionCommon.h >> + LoongArch/ExceptionCommon.c >> + LoongArch/LoongArch64/ArchExceptionHandler.c >> + LoongArch/LoongArch64/ExceptionHandlerAsm.S | GCC > Hmm, if all code is in an arch-specific subdirectory anyway yet another > directory level for the asm code looks unnecessary to me. It is not a directory that only holds ASM code, it is a private folder=20 of LoongArch64, this library may support the LoongArch32 in the future,=20 so it is designed this way. > > The code looks reasonable overall. Can't comment on loongarch specific > details though. > > Acked-by: Gerd Hoffmann > > take care, > Gerd > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116782): https://edk2.groups.io/g/devel/message/116782 Mute This Topic: https://groups.io/mt/104859877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------ZX7T6Hpnmw7xZxgXLBk16sH8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Gerd,


=
Thanks,
Chao
On 2024/3/14 19:22, Gerd Hoffmann wrote:
  Hi,


+[Sources.LoongArch64]
+  LoongArch/DxeExceptionLib.c
+  LoongArch/ExceptionCommon.h
+  LoongArch/ExceptionCommon.c
+  LoongArch/LoongArch64/ArchExceptionHandler.c
+  LoongArch/LoongArch64/ExceptionHandlerAsm.S | GCC

Hmm, if all code is in an arch-specific subdirectory anyway yet another
directory level for the asm code looks unnecessary to me.
It is not a directory that only holds ASM code, it is a private folder of LoongArch64, this library may support the LoongArch32 in the future, so it is designed this way.

The code looks reasonable overall.  Can't comment on loongarch specific
details though.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116782) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------ZX7T6Hpnmw7xZxgXLBk16sH8--