From: "Peter Grehan" <grehan@freebsd.org>
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix
Date: Tue, 18 Aug 2020 12:21:10 +1000 [thread overview]
Message-ID: <254feb74-abd8-ef56-689c-b61f933ba85d@freebsd.org> (raw)
In-Reply-To: <20200818021035.6479-1-rebecca@bsdio.com>
Reviewed-by: Peter Grehan <grehan@freebsd.org>
> OvmfPkg is the package, so while there are files to build bhyve
> separately, they shouldn't have 'Pkg' in the name.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> ---
> OvmfPkg/Bhyve/{BhyvePkgX64.dsc => BhyveX64.dsc} | 2 +-
> OvmfPkg/Bhyve/{BhyvePkgX64.fdf => BhyveX64.fdf} | 2 +-
> OvmfPkg/Bhyve/{BhyvePkgDefines.fdf.inc => BhyveDefines.fdf.inc} | 0
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename OvmfPkg/Bhyve/{BhyvePkgX64.dsc => BhyveX64.dsc} (97%)
> rename OvmfPkg/Bhyve/{BhyvePkgX64.fdf => BhyveX64.fdf} (96%)
> rename OvmfPkg/Bhyve/{BhyvePkgDefines.fdf.inc => BhyveDefines.fdf.inc} (100%)
>
> diff --git a/OvmfPkg/Bhyve/BhyvePkgX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> similarity index 97%
> rename from OvmfPkg/Bhyve/BhyvePkgX64.dsc
> rename to OvmfPkg/Bhyve/BhyveX64.dsc
> index 99e214619be0..d2e9edfaa6b8 100644
> --- a/OvmfPkg/Bhyve/BhyvePkgX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -22,7 +22,7 @@ [Defines]
> SUPPORTED_ARCHITECTURES = X64
> BUILD_TARGETS = NOOPT|DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
> - FLASH_DEFINITION = OvmfPkg/Bhyve/BhyvePkgX64.fdf
> + FLASH_DEFINITION = OvmfPkg/Bhyve/BhyveX64.fdf
>
> #
> # Defines for default states. These can be changed on the command line.
> diff --git a/OvmfPkg/Bhyve/BhyvePkgX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
> similarity index 96%
> rename from OvmfPkg/Bhyve/BhyvePkgX64.fdf
> rename to OvmfPkg/Bhyve/BhyveX64.fdf
> index d40344d523e4..5d2586ae141a 100644
> --- a/OvmfPkg/Bhyve/BhyvePkgX64.fdf
> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
> @@ -11,7 +11,7 @@
> ################################################################################
>
> [Defines]
> -!include OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc
> +!include OvmfPkg/Bhyve/BhyveDefines.fdf.inc
>
> #
> # Build the variable store and the firmware code as one unified flash device
> diff --git a/OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc b/OvmfPkg/Bhyve/BhyveDefines.fdf.inc
> similarity index 100%
> rename from OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc
> rename to OvmfPkg/Bhyve/BhyveDefines.fdf.inc
>
next prev parent reply other threads:[~2020-08-18 2:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 2:10 [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix Rebecca Cran
2020-08-18 2:21 ` Peter Grehan [this message]
2020-08-18 8:56 ` [edk2-devel] " Laszlo Ersek
2020-08-24 18:38 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254feb74-abd8-ef56-689c-b61f933ba85d@freebsd.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox