From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 62362780091 for ; Thu, 2 May 2024 13:17:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6/59HY30hEvRFL45+J0r+yfT0an9KrpyncfD0LK0RHQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714655827; v=1; b=UOS7ZPYRaQtEyfN0M62RMxdQIa3shdPiRkikRv0zLh8/KCHMXx+ZFxQ1rzrptuUOZAUKVFtr ty/BVQWvIwo1O9bgkhfpfN6FCFh8qoF+n+A3ObJZgMaBGrRuzFudUASJdwr0gxWFAa/RSplyV12 uWjoHePrT4Ubge81zY2D+vYBhCeOh2JcH/fZVWpDnT+3NgaQv9YrRr503jXIwtx/9wq/u0qNABN fopfFZAKZYWm2NOoFsowAP/dunJKb8EHyPtyXQMOt2DHqHDZFnu5zWW7rQ6thNgtVHdcboNTtIs Fu/2Tn3A5l0g/DM8IK6t5bQ/SsuHb/mYHWDdh8eXnhbnA== X-Received: by 127.0.0.2 with SMTP id g2QwYY7687511xd0vJqGjAzF; Thu, 02 May 2024 06:17:07 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.13154.1714655827043182537 for ; Thu, 02 May 2024 06:17:07 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B35D22F4; Thu, 2 May 2024 06:17:31 -0700 (PDT) X-Received: from [10.34.111.156] (e126645.nice.Arm.com [10.34.111.156]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DDAE3F71E; Thu, 2 May 2024 06:17:04 -0700 (PDT) Message-ID: <254ff70f-7fdb-4c78-bde4-662df43ea7a6@arm.com> Date: Thu, 2 May 2024 15:16:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 00/14] Split NorFlashDxe driver and add CadenceQspiNorFlashDeviceLib library To: devel@edk2.groups.io, sahil.kaushal@arm.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , sahil , "levi.yun" References: <20240423055638.1271531-1-Sahil.Kaushal@arm.com> From: "PierreGondois" In-Reply-To: <20240423055638.1271531-1-Sahil.Kaushal@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 06:17:07 -0700 Resent-From: pierre.gondois@arm.com Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aW9T9dg2h4dAirnRWRoT61cXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UOS7ZPYR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Sahil, I had some comments for: - [PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFl= ashDxe for all the other patches: Reviewed-by: Pierre Gondois Also, unless I missed something, shouldn't your mail address/signed-off tag= be: 'Sahil ' -> 'Sahil Kaushal ' ? Regards, Pierre On 4/23/24 07:56, Sahil Kaushal via groups.io wrote: > From: sahil >=20 > This patch series adds the following changes: >=20 > 1. Splits the NorFlashDxe driver to introduce a NorFlashDeviceLib that > implements the specifics for the respective flash. This will allow us > to plug different libraries implementing functionality of various NOR > Flash. The flash specific code in NorFlashDxe has been moved to > P30NorFlashDeviceLib library. >=20 > 2. Adds support for CadenceQspiNorFlashDeviceLib which is used by N1Sdp > platform along with NorFlashDxe driver. N1Sdp uses an emulated variable > storage on DDR memory for the variable storage. But this emulated > variable storage is a volatile memory and so the values of variables > can't persist on next reboot or in power cycle. In N1Sdp platform, the > SoC is connected to IOFPGA which has a Cadence Quad SPI (QSPI) > controller. This QSPI controller manages the flash chip device via QSPI > bus. With these changes we use this NOR flash device for persistent > variable storage. >=20 > v2: > - Fixed code review comments > - Split the NorFlashDxe driver and moved flash specific code to > P30NorFlashDeviceLib > - Added NOR flash Dxe Driver for N1Sdp as a library instead of a > driver >=20 > Links to v1: > https://edk2.groups.io/g/devel/topic/102625035 > https://edk2.groups.io/g/devel/topic/102625033 > https://edk2.groups.io/g/devel/topic/102625034 > https://edk2.groups.io/g/devel/topic/102625036 > https://edk2.groups.io/g/devel/topic/102625037 > https://edk2.groups.io/g/devel/topic/102625038 >=20 > Link to branch with the patches in this series - > https://github.com/sah01Kaushal/edk2-platforms/tree/n1sdp_persistent_stor= age_v2 >=20 > sahil (14): > Platform/ARM/NorFlashDxe: Move DiskIo related functions out of > NorFlash.c > Platform/ARM/NorFlashDxe: Move NorFlashVirtualNotifyEvent > Platform/ARM/NorFlashDxe: Add NorFlashCommon.h header file > Platform/ARM/NorFlashDxe: Move flash specific functions to NorFlash.c > Platform/ARM: Create NorFlashDeviceLib library interface for flash > specific functions > Platform/ARM: Add P30NorFlashDeviceLib Library > Platform/ARM/NorFlashDxe: Switch from NorFlash.c to NorFlashDeviceLib > Platform/ARM: Add HostRegisterBaseAddress variable > Platform/ARM: Add optional provision to fetch and print NOR Flash info > Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region > Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp > Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe > Platform/ARM/N1Sdp: Persistent storage for N1Sdp > Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp >=20 > Platform/ARM/ARM.dec = | 4 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc = | 3 + > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc = | 3 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc = | 3 + > Platform/ARM/JunoPkg/ArmJuno.dsc = | 3 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc = | 24 +- > Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc = | 3 + > Platform/ARM/N1Sdp/N1SdpPlatform.fdf = | 3 + > Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf = | 8 +- > Platform/ARM/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf = | 8 +- > Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/CadenceQspiNorFlashDe= viceLib.inf | 32 + > Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf = | 35 + > Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.inf = | 34 + > Platform/ARM/Drivers/NorFlashDxe/NorFlash.h = | 422 -------- > Platform/ARM/Drivers/NorFlashDxe/NorFlashCommon.h = | 209 ++++ > Platform/ARM/Include/Library/NorFlashDeviceLib.h = | 163 ++++ > Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/CadenceQspiNorFlashDe= viceLib.h | 44 + > Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlashDeviceLib.h = | 98 ++ > Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h = | 7 + > Platform/ARM/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c = | 131 ++- > Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.c = | 292 +++--- > Platform/ARM/Drivers/NorFlashDxe/NorFlashFvb.c = | 2 +- > Platform/ARM/Drivers/NorFlashDxe/NorFlashStandaloneMm.c = | 184 ++-- > Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/CadenceQspiNorFlashDe= viceLib.c | 1011 ++++++++++++++++++++ > Platform/ARM/{Drivers/NorFlashDxe/NorFlash.c =3D> Library/P30NorFlashDe= viceLib/P30NorFlashDeviceLib.c} | 330 +++---- > Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.c = | 65 ++ > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c = | 8 +- > 27 files changed, 2225 insertions(+), 904 deletions(-) > create mode 100644 Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/Ca= denceQspiNorFlashDeviceLib.inf > create mode 100644 Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlas= hDeviceLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFla= shLib.inf > delete mode 100644 Platform/ARM/Drivers/NorFlashDxe/NorFlash.h > create mode 100644 Platform/ARM/Drivers/NorFlashDxe/NorFlashCommon.h > create mode 100644 Platform/ARM/Include/Library/NorFlashDeviceLib.h > create mode 100644 Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/Ca= denceQspiNorFlashDeviceLib.h > create mode 100644 Platform/ARM/Library/P30NorFlashDeviceLib/P30NorFlas= hDeviceLib.h > create mode 100644 Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/Ca= denceQspiNorFlashDeviceLib.c > rename Platform/ARM/{Drivers/NorFlashDxe/NorFlash.c =3D> Library/P30Nor= FlashDeviceLib/P30NorFlashDeviceLib.c} (77%) > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFla= shLib.c >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118508): https://edk2.groups.io/g/devel/message/118508 Mute This Topic: https://groups.io/mt/105690935/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-