[PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[sivaparvathi C]

     Added changes to clear the redundant symbol after using Hexedit cmd in
shell screen page.

      During ClearScreen(),first screen was cleared and cursor was set to
    new position(0,0) ,but the visible state of cursor is always 1. in
    setcursorposition(),cursor was disabled during that time,old cursor
    data is drawn to screen.

 Signed-off-by: sivaparvathic@ami.com
---
 .../Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c    | 2 ++
 .../Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c  | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
index 58beaaf9c5..58df2e022b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
@@ -1627,6 +1627,7 @@ MainEditorCleanup (
     ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_EDIT_LIBEDITOR_FILEBUFFER_CLEANUP), gShellDebug1HiiHandle);

   }



+  gST->ConOut->EnableCursor (gST->ConOut, FALSE);

   //

   // restore old mode

   //

@@ -1644,6 +1645,7 @@ MainEditorCleanup (


   gST->ConOut->ClearScreen (gST->ConOut);



+  gST->ConOut->EnableCursor (gST->ConOut, TRUE);

   return EFI_SUCCESS;

 }



diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
index 0eb917acf7..8b3d5225db 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
@@ -1833,6 +1833,7 @@ HMainEditorCleanup (
     ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_HEXEDIT_LIBEDITOR_CLIPBOARD_CLEAN), gShellDebug1HiiHandle);

   }



+  gST->ConOut->EnableCursor (gST->ConOut, FALSE);

   //

   // restore old mode

   //

@@ -1845,6 +1846,7 @@ HMainEditorCleanup (
                  EFI_TEXT_ATTR (HOriginalColors.Foreground, HOriginalColors.Background)

                  );

   gST->ConOut->ClearScreen (gST->ConOut);

+  gST->ConOut->EnableCursor (gST->ConOut, TRUE);



   return EFI_SUCCESS;

 }

--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Hi gaoliming@byosoft.com.cn ,
Could you please review the changes?

Thanks,
Sivaparvathi C

[-- Attachment #2: Type: text/html, Size: 136 bytes --]

回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Sivaparvathi:

 Is EnableCursor always required after ClearScreen()? Or, is it only required in Hexedit command?

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年9月12日 17:13
收件人: sivaparvathi C <sivaparvathic@ami.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

 

Hi gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>  ,

 Could you please review the changes?

Thanks,
Sivaparvathi C




[-- Attachment #2: Type: text/html, Size: 3933 bytes --]

Re: 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]

Hi gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>,

  The redundant symbol is available after using Hexedit and Edit command in the shell.
I have tried these 2 commands only. These changes are required for Hexedit and Edit commands only.

Thanks,
Sivaparvathi C
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, September 13, 2022 12:22 PM
To: devel@edk2.groups.io; Sivaparvathi Chellaiah <sivaparvathic@ami.com>
Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Sivaparvathi:
 Is EnableCursor always required after ClearScreen()? Or, is it only required in Hexedit command?

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 sivaparvathi C via groups.io
发送时间: 2022年9月12日 17:13
收件人: sivaparvathi C <sivaparvathic@ami.com<mailto:sivaparvathic@ami.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
主题: Re: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

Hi gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn> ,
 Could you please review the changes?

Thanks,
Sivaparvathi C

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[-- Attachment #2: Type: text/html, Size: 7275 bytes --]

回复: 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2651 bytes --]

Sivaparvathi:

 I use Hexedit command and use F3 to exit it. But, I don’t find the redundant symbol on the screen. How do you reproduce this issue?

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年9月15日 12:45
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

 

Hi gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ,

 

  The redundant symbol is available after using Hexedit and Edit command in the shell.

I have tried these 2 commands only. These changes are required for Hexedit and Edit commands only.

 

Thanks,

Sivaparvathi C

From: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > 
Sent: Tuesday, September 13, 2022 12:22 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Sivaparvathi Chellaiah <sivaparvathic@ami.com <mailto:sivaparvathic@ami.com> >
Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

 

 

**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** 

Sivaparvathi:

 Is EnableCursor always required after ClearScreen()? Or, is it only required in Hexedit command?

 

Thanks

Liming

发件人:  <mailto:devel@edk2.groups.io> devel@edk2.groups.io < <mailto:devel@edk2.groups.io> devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年9月12日 17:13
收件人: sivaparvathi C < <mailto:sivaparvathic@ami.com> sivaparvathic@ami.com>;  <mailto:devel@edk2.groups.io> devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

 

Hi gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>  ,

 Could you please review the changes?

Thanks,
Sivaparvathi C

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. 




[-- Attachment #2: Type: text/html, Size: 10238 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

HI GaoLiming,
The redundant symbol is available after using Hexedit and Edit command in the shell.

I have tried these 2 commands. These changes are required for Hexedit and Edit commands only.

I have tried the  edk2-edk2-stable202002 source Emulator64 environment. It will produce shell.efi application. Tried this application on the  MSI platform, and the redundant cursor symbol was available on the shell screen.
Thanks,
Sivaparvathi

[-- Attachment #2: Type: text/html, Size: 1412 bytes --]