From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web09.5182.1631966395073116499 for ; Sat, 18 Sep 2021 05:00:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=A8XRWm9G; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18I61Cbp018199; Sat, 18 Sep 2021 07:59:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=rWjTaJNPir4lBgY7WSdgSivXCoqObOxp60f4xRE5H84=; b=A8XRWm9GkKBTBPCrBkJorvIWwpBcpbm4sXQqfoNROZwVwdmowF9QmLkrVulT7ZNZS19E +kUzdY5oO1brhIxs22BzTdHel+/DSzf5BpWho6jjL46I0xQkdk6hvDPC0KviGFl4FOgw guqK6e+OPwD3f5L4O0xfeanwn+n+wr3TAxPQhN5iEhqQk3LE7OuhIwuP00JRmwSkCKfF SrRV9rQMnMixzFzTWclgt/4iXh4txQAL4kWmMpBlfELBrl4qXaHjHHsOIhE2EIJi8+ST pTprDE46VU3sRT8HfDYCv25BLQGmfrIPrSjAf1YGEt2G7Usv2cEtgOAz4/6hYJYywpWF iQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b5afnbxnv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 07:59:51 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18IBqDvi032701; Sat, 18 Sep 2021 07:59:50 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b5afnbxns-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 07:59:50 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18IBvMsP007808; Sat, 18 Sep 2021 11:59:49 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma04dal.us.ibm.com with ESMTP id 3b57r8wgmh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 18 Sep 2021 11:59:49 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18IBxmJj18678082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Sep 2021 11:59:48 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42591C605A; Sat, 18 Sep 2021 11:59:48 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1A89C6059; Sat, 18 Sep 2021 11:59:47 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Sat, 18 Sep 2021 11:59:47 +0000 (GMT) Subject: Re: [edk2-devel] [RFC PATCH 2/3] ArmVirtPkg: Reference new TPM classes in the build system for compilation To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: marcandre.lureau@redhat.com, kraxel@redhat.com, jiewen.yao@intel.com, ardb+tianocore@kernel.org, leif@nuviainc.com, Stefan Berger References: <20210916211752.2714332-1-stefanb@linux.ibm.com> <20210916211752.2714332-3-stefanb@linux.ibm.com> <2aa2bea6-d2a9-363c-ce05-2d6dd3c8c2fe@arm.com> From: "Stefan Berger" Message-ID: <2559ac94-1795-adf7-0419-c94b83258b17@linux.ibm.com> Date: Sat, 18 Sep 2021 07:59:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2aa2bea6-d2a9-363c-ce05-2d6dd3c8c2fe@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0z7mqDKl3eZinT_AL6ZGw12s7bexjPpr X-Proofpoint-ORIG-GUID: CTFnQHGOTfJDialOjyJnF7Ill1mx9Nyy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-18_03,2021-09-17_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 mlxlogscore=892 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109180080 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id 18I61Cbp018199 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/18/21 4:49 AM, Sami Mujawar wrote: > Hi Stefan, > > Thank you for this patch. > > Please find my response inline marked [SAMI]. > > With that updated, > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > On 16/09/2021 10:17 PM, Stefan Berger wrote: >> From: Stefan Berger > [SAMI] Is it possible to add the bugzilla reference here, please? Also > it would be very helpful to add the message from the cover letter here > as the coverletter would not be part of the patch in git. Sure, I will add the link on next round. =C2=A0=C2=A0 Stefan