From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency To: Vijayenthiran Subramaniam ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.53) X-Originating-Platform: Windows Firefox 107 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 16 Dec 2022 02:28:52 -0800 References: <20220920165350.50544-1-vijayenthiran.subramaniam@arm.com> In-Reply-To: <20220920165350.50544-1-vijayenthiran.subramaniam@arm.com> Message-ID: <25627.1671186532908215767@groups.io> Content-Type: multipart/alternative; boundary="awP3oF3QY1FFuSRmEmOO" --awP3oF3QY1FFuSRmEmOO Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Vijay, Thank you for this patch. This patch as such looks ok to me but I am getting a build the following fa= ilure when openssl library is being built. build -a AARCH64 -p Platform\ARM\SgiPkg\PlatformStandaloneMm2.dsc -t GCC5 -= b DEBUG=C2=A0 -n 1 -D EDK2_OUT_DIR=3DBuild\ArmSgiPlatStmm2 -D SECURE_STORAG= E_ENABLE ... "D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\b= in\aarch64-none-elf-gcc"=C2=A0 @w:\edk2-maintenance\Build\SgiMmStandalone\D= EBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\cc_resp.tx= t=C2=A0 -c -o w:\ekd2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\= CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\openssl\crypto\rand\drbg_lib= .obj=C2=A0 w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\cr= ypto\rand\drbg_lib.c w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\d= rbg_lib.c: In function 'drbg_add': w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\d= rbg_lib.c:999:12: error: '+nofp' feature modifier is incompatible with the = use of floating-point types 999 | static int drbg_add(const void *buf, int num, double randomness) |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~= ~ NMAKE : fatal error U1077: 'D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-= w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc.EXE' : return code '0x1' Stop. ... This may not be related to your patch, but can you check, please? Regards, Sami Mujawar --awP3oF3QY1FFuSRmEmOO Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Vijay,

Thank you for this patch.
This patch as such loo= ks ok to me but I am getting a build the following failure when openssl lib= rary is being built.

build -a AARCH64 -p Platform\ARM\SgiPkg\Pla= tformStandaloneMm2.dsc -t GCC5 -b DEBUG  -n 1 -D EDK2_OUT_DIR=3DBuild\= ArmSgiPlatStmm2 -D SECURE_STORAGE_ENABLE
...
"D:\linaro_toolchain= \gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-= gcc"  @w:\edk2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\Cr= yptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\cc_resp.txt  -c -o w:\ekd= 2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\Op= ensslLib\OpensslLib\OUTPUT\openssl\crypto\rand\drbg_lib.obj  w:\edk2-m= aintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c=
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\= rand\drbg_lib.c: In function 'drbg_add':
w:\edk2-maintenance\edk2\Cryp= toPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c:999:12: error: '+no= fp' feature modifier is incompatible with the use of floating-point types  999 | static int drbg_add(const void *buf, int num, double rando= mness)
      |     &= nbsp;      ^~~~~~~~
NMAKE : fatal error U1077= : 'D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf= \bin\aarch64-none-elf-gcc.EXE' : return code '0x1'
Stop.
...

This may not be related to your patch, but can you check, please?
Regards,

Sami Mujawar --awP3oF3QY1FFuSRmEmOO--