From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DE8EA7803DE for ; Fri, 1 Dec 2023 12:26:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=f73TCQZH/0WelbG+xLFz0YZVZksuP8uqcNy8qT+F1dM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701433588; v=1; b=qMqX4qGZUEZ09r1wHJijM0Ae4kbwscB/9tvmDTgT8UF0ypgzmKBlkBrJt1XD0KhvEqFOk9pN 06pr5lIPjJUVblPbO4ZrmeIbhBE8uw0Ffjl9eFTTLMgBgyMFVjtY00rlq96lGCk4zD23fCvhSVu kWjimXojrJWjsGPIQCEK47PM= X-Received: by 127.0.0.2 with SMTP id nt3GYY7687511xINJWo8du91; Fri, 01 Dec 2023 04:26:28 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.21499.1701433587299829319 for ; Fri, 01 Dec 2023 04:26:27 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 437831007; Fri, 1 Dec 2023 04:27:13 -0800 (PST) X-Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28C9B3F5A1; Fri, 1 Dec 2023 04:26:24 -0800 (PST) Message-ID: <25653a17-23ba-4974-bb49-804a238cc90e@arm.com> Date: Fri, 1 Dec 2023 13:26:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions To: "Ni, Ray" , "devel@edk2.groups.io" Cc: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Sami Mujawar , Leif Lindholm References: <20231130110953.16550-1-pierre.gondois@arm.com> <20231130110953.16550-2-pierre.gondois@arm.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VeGcGCCu9bL8wwmOis668FSDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qMqX4qGZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray, I followed the way revisions are defined for ACPI tables revisions, like for the MADT: EFI_ACPI_x_x_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION definition For each ACPI spec. revision, there is a matching MADT revision number. Sometimes the table has changed and the revision is upgraded, sometimes not and the revision stays the same. This also means having a macro definition for each ACPI spec. header file. I think it should be ok do to the same thing for _PSD/_CPC revisions, Regards, Pierre On 12/1/23 11:22, Ni, Ray wrote: >> --- a/MdePkg/Include/IndustryStandard/Acpi50.h >> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h >=20 >> +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 >> +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 >=20 >=20 > Do you think it's better to define EFI_ACPI_AML_PSD_REVISION and > EFI_ACPI_AML_CPC_REVISION in Acpi50.h? >=20 > So that Acpi51.h doesn't have to redefine a different macro to > the same value? >=20 >> >> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h >> b/MdePkg/Include/IndustryStandard/Acpi51.h >> index 01ef544c3a29..19dd7b4f864c 100644 >> --- a/MdePkg/Include/IndustryStandard/Acpi51.h >> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h >=20 >> +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 >> +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111982): https://edk2.groups.io/g/devel/message/111982 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-