From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 599A481B5A for ; Wed, 11 Jan 2017 01:23:53 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 11 Jan 2017 01:23:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="1092640925" Received: from shzintpr02.sh.intel.com (HELO [10.253.24.23]) ([10.239.4.160]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2017 01:23:51 -0800 To: Linson Augustine , edk2-devel@lists.01.org References: <20170111091014.9832-1-linson.augustine@hpe.com> Cc: jaben.carsey@intel.com, ruiyu.ni@intel.com, michael.d.kinney@intel.com, liming.gao@intel.com, star.zeng@intel.com From: "Zeng, Star" Message-ID: <256aa7ac-bd7f-ed7a-507b-c09dcdd50425@intel.com> Date: Wed, 11 Jan 2017 17:23:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170111091014.9832-1-linson.augustine@hpe.com> Subject: Re: [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 09:23:53 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Linson, Add minor comments inline. On 2017/1/11 17:10, Linson Augustine wrote: > Added definitions for the new SMBIOS Type 43 record. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Augustine Linson P > --- > MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h > index c66422fc3a..debc85af6e 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -2,7 +2,7 @@ > Industry Standard Definitions of SMBIOS Table Specification v3.0.0. > > Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials are licensed and made available under > the terms and conditions of the BSD License that accompanies this distribution. > The full text of the license may be found at > @@ -97,6 +97,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40 > #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 > #define SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 > +#define SMBIOS_TYPE_TPM_DEVICE 43 > > /// > /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43. > @@ -2359,6 +2360,21 @@ typedef struct { > } SMBIOS_TABLE_TYPE42; > > /// > +/// TPM Device (Type 43). > +/// > +typedef struct { > + SMBIOS_STRUCTURE Hdr; > + UINT8 VendorID[4]; > + UINT8 MajorSpecVersion; > + UINT8 MinorSpecVersion; > + UINT32 FirmwareVersion1; > + UINT32 FirmwareVersion2; > + UINT8 Description; It is better to use "SMBIOS_TABLE_STRING Description" instead of "UINT8 Description". If you agree that, you can have my Reviewed-by: Star Zeng . And you do not need to resend the patch, I will help push the patch with the line fixed if no others' comments. Thanks, Star > + UINT64 Characteristics; > + UINT32 OemDefined; > +} SMBIOS_TABLE_TYPE43; > + > +/// > /// Inactive (Type 126) > /// > typedef struct { > @@ -2420,6 +2436,7 @@ typedef union { > SMBIOS_TABLE_TYPE40 *Type40; > SMBIOS_TABLE_TYPE41 *Type41; > SMBIOS_TABLE_TYPE42 *Type42; > + SMBIOS_TABLE_TYPE43 *Type43; > SMBIOS_TABLE_TYPE126 *Type126; > SMBIOS_TABLE_TYPE127 *Type127; > UINT8 *Raw; >