From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by mx.groups.io with SMTP id smtpd.web10.36388.1607960748949550755 for ; Mon, 14 Dec 2020 07:45:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=KAWtBrqC; spf=pass (domain: nuviainc.com, ip: 209.85.210.194, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f194.google.com with SMTP id x126so3470055pfc.7 for ; Mon, 14 Dec 2020 07:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ao67S60lVvZV9JSYzGEDLrQc2FVmxm1h81S/LMnq45I=; b=KAWtBrqCpNBCcmHH3ps6MhZ7G6BPOyuBaaQ0B3XMcJewr1EBIb8JAhzZd8birjQdX6 wj8hup5q0cxJlsvsE+hDmNvbMp/JlLxc0TiEpfLlgdIx1tXIlkuZ2CUko23lDhNfhYF5 mefUPIPkV1U518TMq6iaA6lp396V1rXIgIQ8c5jfBkyK6QI7P3O/hkP+Gvx9xspgo5Pk gwj4BghmCUs0Bk2HNLOfO/QhAdqHKEPk0RZstR+JAt6oX1y6pI9kcQZEK0HLkvAmMY/2 uqXYMPMhW1PJobCkFfDvdpBDSpcWFauTmtKQUfLJxktlNes2+BxZWVWeBUfotKlbR2sZ xtjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ao67S60lVvZV9JSYzGEDLrQc2FVmxm1h81S/LMnq45I=; b=fz1qSq7XIgAiBaGMU12hvh2BmLQG3Br8A3nFzrbJIIE77GruHRtT/PjBRbLr4eA+o4 fyKq8Yu6n7lPVsLL0afpQBLkjiz/MPgNPiwzk1XHOVe5Rr/4V+H0Jf4U42/4MIUSPUTA Od3RItU7qNdJ3IoNLMG/t8gMifHE4jyznd7No7LOyfSFlDx9th7SqqcDymASL5LaYxU+ 3IUXQGJyvIsv0/SYc/J+In9gjulq/8ix3Oq3MJy1rATkQ/BEH2cQZS1udjK6BaLD10XB bQmtsKN2Ov2LmarYrcLU536DSbJAbjjP9/pups89YpoglOslj9s2ORPKDJABvchFlUUW s9aw== X-Gm-Message-State: AOAM533zqA9IgZTXOuGzEh+lSDgxzuEs4bxMFfHymt8R8sIRJdnvkPR1 apeOY3LD0PMlcXmhoCe7WcXsSQ== X-Google-Smtp-Source: ABdhPJxK7iR05n46zeOlLIZWPlFgBe2Eu+NtL8TknmXrlslmLWm6GBcHKtRqWEYtvc7QfkrLm/jTnA== X-Received: by 2002:a63:8f19:: with SMTP id n25mr897237pgd.17.1607960748458; Mon, 14 Dec 2020 07:45:48 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id h20sm19581737pgv.23.2020.12.14.07.45.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Dec 2020 07:45:47 -0800 (PST) Subject: Re: [PATCH v4 00/10] ArmPkg,MdePkg: Add Universal/Smbios, and related changes To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel References: <20201207175427.28712-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <25800d46-5b5c-467e-8a0a-c2a4d9402baa@nuviainc.com> Date: Mon, 14 Dec 2020 08:45:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201207175427.28712-1-rebecca@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Could I have some reviews on this series, please? Thanks. Rebecca Cran On 12/7/20 10:54 AM, Rebecca Cran wrote: > Much of the data for the SMBIOS tables is generic, and need not be > duplicated for each platform. This patch series introduces > ArmPkg/Universal/Smbios, which is largely copied from > edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS > tables 0,1,2,3,4,713,32 and uses a combination of PCDs and calls into a > new OemMiscLib to get information which varies between platforms. > > I plan to submit a patch against SbsaQemu to update it to use this new > functionality. > > Note: this series is based on top of the pending SmBios.h typo fixes > series. > > Changes from v3 to v4: > > - Incorporated changes based on v3 feedback. > - Improved code style to more closely match the coding standard. > - Added Doxygen comments. > - Removed the VersionInfo driver, instead integrating code into > Universal/Smbios > > Rebecca Cran (10): > ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h > MdePkg: Update IndustryStandard/SmBios.h with processor status data > ArmPkg: Add register encoding definition for MMFR2 > ArmPkg: Add helper to read the Memory Model Features Register 2 > ArmPkg: Add helper function to read the Memory Model Feature Register > 4 > ArmPkg: Add helper to read CCIDX status > ArmPkg: Fix the return type of the ReadCCSIDR function > ArmPkg: Update ArmLibPrivate.h with cache register definitions > ArmPkg: Add definition of the maximum cache level in ARMv8-A > ArmPkg: Add Universal/Smbios, a generic SMBIOS library for ARM > > ArmPkg/ArmPkg.dec | 14 + > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 56 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 86 ++ > ArmPkg/Include/Chipset/AArch64.h | 4 + > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 13 + > ArmPkg/Include/Library/ArmLib.h | 10 + > ArmPkg/Include/Library/OemMiscLib.h | 95 +++ > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 + > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 + > ArmPkg/Library/ArmLib/ArmLibPrivate.h | 93 ++- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 136 ++++ > MdePkg/Include/IndustryStandard/SmBios.h | 13 + > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 12 + > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 12 + > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 835 ++++++++++++++++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c | 61 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 178 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 92 +++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 263 ++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 35 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 173 ++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 45 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 201 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 51 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 200 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 32 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 154 ++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 34 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 67 ++ > ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 + > ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 4 + > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 6 +- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 23 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscLibStrings.uni | 21 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 17 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 20 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 20 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 17 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni | 42 + > 40 files changed, 3149 insertions(+), 3 deletions(-) > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > create mode 100644 ArmPkg/Include/Library/OemMiscLib.h > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscLibStrings.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni >