From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 336437803E0 for ; Mon, 26 Feb 2024 13:42:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9dDPUiy1tui70N5u74zuoZ59Fo2JaNgO+7e5bosxvfw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708954951; v=1; b=kT8udADZMj1i2zeD2WuJR1ldUhqEizO20i5oT6y6VSv7tiEL183RABhe9OXyy5luRpvtg1wS odVFKSqtqm5Ouo6n0zYrmb+5gCHIRjRbMLW1E+947vxI6BOtGoROYS1pfUv1k9RIWB95vFt4qmu Keg6WEXuBjHLusOY8rDtPCnM= X-Received: by 127.0.0.2 with SMTP id cfChYY7687511xulxkfajKSu; Mon, 26 Feb 2024 05:42:31 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.20461.1708954951104698970 for ; Mon, 26 Feb 2024 05:42:31 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-I2RTd02pPGWXIkZRAyLAIg-1; Mon, 26 Feb 2024 08:42:26 -0500 X-MC-Unique: I2RTd02pPGWXIkZRAyLAIg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7784C83B86A; Mon, 26 Feb 2024 13:42:26 +0000 (UTC) X-Received: from [10.39.194.99] (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7DDC41C06710; Mon, 26 Feb 2024 13:42:25 +0000 (UTC) Message-ID: <259eaab6-695d-6184-9d88-3ccd740fc58b@redhat.com> Date: Mon, 26 Feb 2024 14:42:24 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 1/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob To: devel@edk2.groups.io, ray.ni@intel.com, Gerd Hoffmann Cc: "Kumar, Rahul R" , Oliver Steffen References: <20240222160106.686484-1-kraxel@redhat.com> <20240222160106.686484-2-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: imW0zkHecjjkFZM7h8TfbLvUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kT8udADZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray, On 2/23/24 03:35, Ni, Ray wrote: >> + @param[in] MpHandOff Previous HOB body. Pass NULL to get the >> first HOB. >=20 > Can you replace "...HOB Body. Pass NULL..." with "...HOB Body. Pass NULL= ..."? > Your current comments contain two spaces. >=20 > With that, Reviewed-by: Ray Ni The two spaces after the dot are valid English -- it's called "English spacing after a full stop": https://en.wikipedia.org/wiki/Full_stop#Spacing_after_a_full_stop Some projects use English spacing in comments and documentation, so a developer working on multiple projects may not find it easy to switch between French and English spacing. (If you check Gerd's commit messages in this series, those also use English spacing.) I could edit out the second spaces before merging this series, but I think that wouldn't be right; again, it's valid English. (E.g., we also don't try to enforce American vs. British English spelling in comments, even though the American one is much more common in the codebase.) Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115957): https://edk2.groups.io/g/devel/message/115957 Mute This Topic: https://groups.io/mt/104510907/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-