From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1925D74004E for ; Tue, 31 Oct 2023 17:22:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NyR+47dUp/Qmh0Mmc1HW8umlrJc/AVMzQ2Dz1QDXYDM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698772944; v=1; b=pMqszMkeaFYYxG4XXkMj56F/9pp6X0CXVMS+jkH9WKnxwKBHNZ0gK2fNClWJ1FLoD4w2p3ZK I1ZTivD0+49c0sarJUIWzZ+677F/OMNeq3fTZixeTvMr4dNOidLf6pfDoGPu5EGIKKwV//KfvXb ndp0DPEwYQjShEq4nlX0Q0XU= X-Received: by 127.0.0.2 with SMTP id 4EheYY7687511x8ierortZ6D; Tue, 31 Oct 2023 10:22:24 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.1633.1698772944125760021 for ; Tue, 31 Oct 2023 10:22:24 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-bpa7eIvCN2aJFxq1VVz-ug-1; Tue, 31 Oct 2023 13:22:19 -0400 X-MC-Unique: bpa7eIvCN2aJFxq1VVz-ug-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9982811E82; Tue, 31 Oct 2023 17:22:18 +0000 (UTC) X-Received: from [10.39.195.34] (unknown [10.39.195.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59DB7134; Tue, 31 Oct 2023 17:22:17 +0000 (UTC) Message-ID: <25cfaf16-4b79-c64e-f7b8-ea64fd1d47db@redhat.com> Date: Tue, 31 Oct 2023 18:22:16 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] CodeQL and Apache Licensed Files To: Michael Kubacki , devel@edk2.groups.io, "Kinney, Michael D" , 'Leif Lindholm' , 'Andrew Fish' Cc: 'Sean Brogan' , Gerd Hoffmann , Oliver Steffen References: <76c83798-2e7e-42df-bd10-673785b987f9@linux.microsoft.com> <68b71576-2395-4ea0-a313-ae86de0f21a3@linux.microsoft.com> From: "Laszlo Ersek" In-Reply-To: <68b71576-2395-4ea0-a313-ae86de0f21a3@linux.microsoft.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EDHdCHuHUenUmBySZRXKHcsQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pMqszMke; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/31/23 17:07, Michael Kubacki wrote: > On 10/28/2023 7:51 AM, Laszlo Ersek wrote: >> On 10/27/23 23:11, Michael Kubacki wrote: >>> I'd like to bring attention to Apache License 2.0 code in the CodeQL >>> series I sent to the mailing list for steward review. >>> >>> In particular, the files in the BaseTools/Plugin/CodeQL/analyze >>> directory of this patch: >>> >>> https://edk2.groups.io/g/devel/message/109696 >>> >>> Please let me know if any next steps are needed. >> >> (1) I don't know if edk2 accepts contributions under Apache License 2.0; >> just want to point out that this license is acceptable in Fedora (and so >> RHEL too), per >> . Assuming >> we're talking about "Apache Software License 2.0". >> > A few submodules are using the Apache License 2.0. >=20 > For example, OpenSSL v3: >=20 > - https://www.openssl.org/source/license.html > - https://git.openssl.org/?p=3Dopenssl.git;a=3Dblob_plain;f=3DLICENSE.txt= ;hb=3DHEAD >=20 > And cmoocka: >=20 > - https://gitlab.com/cmocka/cmocka/-/blob/master/COPYING Thanks for identifying those! >=20 > I'm unaware if there was precedent specific to submodules, but I'd > expect terms like redistribution clauses to already apply regardless of > tooling used to acquire the source code into the project. I believe the same. >=20 >> (2) Should we extend "License Details" and "Code Contributions" in >> "ReadMe.rst"? >> > My initial thought was to add the path (BaseTools\Plugin\CodeQL\analyze) > to "License Details". >=20 > Was that all that you had in mind or to elaborate further in that > section on the licenses used/allowed? - Under "License Details", simply list BaseTools/Plugin/CodeQL/analyze as one of the "components" (i.e., first list) that use a "additional licenses". - Under "Code Contributions", we should list "Apache Software License 2.0" as acceptable -- both for this new feature, and for the *already* upstream stuff that you found above. >=20 >> (3) Should the new files (under Apache License 2.0) use an SPDX >> identifier tag, for easy greppability? >> > I'd be happy to add that. That's a relief, I didn't know whether you could touch up the license blocks! Thanks! Laszlo >=20 >> (4) With the addition, downstream packages (such as RPMs in Fedora and >> RHEL) might want to spell out the short SPDX identifier of the new >> license too in their License: tags. >> >> Laszlo >> >> >> >>=20 >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110437): https://edk2.groups.io/g/devel/message/110437 Mute This Topic: https://groups.io/mt/102230244/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-