Re: [edk2-devel] [PATCH 08/12] OvmfPkg/MemEncryptSevLib: Make the MemEncryptSevLib available for SEC

["Laszlo Ersek" <lersek@redhat.com>]

On 01/05/21 15:34, Lendacky, Thomas wrote:
> On 1/5/21 3:40 AM, Laszlo Ersek wrote:
>> On 12/15/20 21:51, Lendacky, Thomas wrote:

>>> diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/SecBaseMemEncryptSevLib.inf b/OvmfPkg/Library/BaseMemEncryptSevLib/SecBaseMemEncryptSevLib.inf
>>> new file mode 100644
>>> index 000000000000..b26f739d69fd
>>> --- /dev/null
>>> +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/SecBaseMemEncryptSevLib.inf
>>> @@ -0,0 +1,54 @@
>>> +## @file
>>> +#  Library provides the helper functions for SEV guest
>>> +#
>>> +# Copyright (c) 2020 Advanced Micro Devices. All rights reserved.<BR>
>>> +#
>>> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
>>> +#
>>> +#
>>> +##
>>> +
>>> +[Defines]
>>> +  INF_VERSION                    = 1.25
>>> +  BASE_NAME                      = SecMemEncryptSevLib
>>> +  FILE_GUID                      = 046388b4-430e-4e61-88f6-51ea21db2632
>>> +  MODULE_TYPE                    = BASE
>>> +  VERSION_STRING                 = 1.0
>>> +  LIBRARY_CLASS                  = MemEncryptSevLib|SEC
>>> +
>>> +#
>>> +# The following information is for reference only and not required by the build
>>> +# tools.
>>> +#
>>> +# VALID_ARCHITECTURES           = IA32 X64
>>> +#
>>> +
>>> +[Packages]
>>> +  MdeModulePkg/MdeModulePkg.dec
>>> +  MdePkg/MdePkg.dec
>>> +  OvmfPkg/OvmfPkg.dec
>>> +  UefiCpuPkg/UefiCpuPkg.dec
>>> +
>>> +[Sources.X64]
>>> +  SecMemEncryptSevLibInternal.c
>>> +  MemEncryptSevLibInternal.c
>>> +  X64/MemEncryptSevLib.c
>>> +  X64/SecVirtualMemory.c
>>> +  X64/VirtualMemory.h
>>> +
>>> +[Sources.IA32]
>>> +  SecMemEncryptSevLibInternal.c
>>> +  MemEncryptSevLibInternal.c
>>> +  Ia32/MemEncryptSevLib.c
>>> +
>>> +[LibraryClasses]
>>> +  BaseLib
>>> +  CpuLib
>>> +  DebugLib
>>> +  PcdLib
>>> +
>>> +[FeaturePcd]
>>> +  gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire
>>> +
>>
>> (2) This PCD does not look useful for the new library instance (at least
>> at this stage).
> 
> The PCD is used in MemEncryptSevLocateInitialSmramSaveStateMapPages() in
> the MemEncryptSevLibInternal.c file, which is part of the library. Because
> of that, I assumed that it needed to be added even though the function
> that uses it isn't called during SEC.
> 
> I'll remove it.

My apologies, your original thought was correct; please keep the PCD here.

Thanks!
Laszlo