[PATCH v2 0/2] dp command without ACPI

[PATCH v2 0/2] dp command without ACPI

[Jeff Brasen]

Systems that do not boot with ACPI (system that use device tree for example)
can not use the shell dp command. This patch adds this to the configuration
table so that dp command can get this without the FPDT table.

I am open to other ways for this to be passed if desired (Installed protocol,
handler of the status code, etc) but wanted to post this to at least get thoughts
on this.

Change Log
v2 - Fix missing cast for IA32 builds

-Jeff

Jeff Brasen (2):
  MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table
  ShellPkg/Dp: Allow dp command to work without ACPI

 ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
 .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
 .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11 ++++++++---
 4 files changed, 12 insertions(+), 3 deletions(-)

-- 
2.25.1

[PATCH v2 1/2] MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table

[Jeff Brasen]

Install the performance table into the UEFI configuration table.
This will allow the shell application to get this if the system
is not using ACPI.

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 .../Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c       | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
index ef14bc073810..57792ba44e7f 100644
--- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
+++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
@@ -1403,6 +1403,8 @@ ReportFpdtRecordBuffer (
         &BPDTAddr,
         sizeof (UINT64)
         );
+      Status = gBS->InstallConfigurationTable (&gEdkiiFpdtExtendedFirmwarePerformanceGuid, (VOID *)(UINTN)BPDTAddr);
+      ASSERT_EFI_ERROR (Status);
     }
 
     //
-- 
2.25.1

[PATCH v2 2/2] ShellPkg/Dp: Allow dp command to work without ACPI

[Jeff Brasen]

If the system does not have ACPI setup use the configuration table
to get the performance info.

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
 .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11 ++++++++---
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
index 4a58286b8c1a..d9e1c23a1ee7 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
@@ -54,6 +54,7 @@ [LibraryClasses]
 
 [Guids]
   gPerformanceProtocolGuid                                ## CONSUMES ## SystemTable
+  gEdkiiFpdtExtendedFirmwarePerformanceGuid               ## CONSUMES ## SystemTable
 
 [Protocols]
   gEfiLoadedImageProtocolGuid                             ## CONSUMES
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
index 013bdbd4a07e..2723fee7066e 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
@@ -55,6 +55,7 @@ [LibraryClasses]
 
 [Guids]
   gPerformanceProtocolGuid                                ## CONSUMES ## SystemTable
+  gEdkiiFpdtExtendedFirmwarePerformanceGuid               ## CONSUMES ## SystemTable
 
 [Protocols]
   gEfiLoadedImageProtocolGuid                             ## CONSUMES
diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
index 512a146da6dd..98c84d2ef938 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
@@ -129,17 +129,22 @@ EFI_STATUS
 GetBootPerformanceTable (
   )
 {
+  EFI_STATUS                  Status;
   FIRMWARE_PERFORMANCE_TABLE  *FirmwarePerformanceTable;
 
   FirmwarePerformanceTable = (FIRMWARE_PERFORMANCE_TABLE *)EfiLocateFirstAcpiTable (
                                                              EFI_ACPI_5_0_FIRMWARE_PERFORMANCE_DATA_TABLE_SIGNATURE
                                                              );
   if (FirmwarePerformanceTable == NULL) {
-    ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle);
-    return EFI_NOT_FOUND;
+    Status = EfiGetSystemConfigurationTable (&gEdkiiFpdtExtendedFirmwarePerformanceGuid, (VOID **)&mBootPerformanceTable);
+    if (EFI_ERROR (Status)) {
+      ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle);
+      return EFI_NOT_FOUND;
+    }
+  } else {
+    mBootPerformanceTable = (UINT8 *)(UINTN)FirmwarePerformanceTable->BootPointerRecord.BootPerformanceTablePointer;
   }
 
-  mBootPerformanceTable     = (UINT8 *)(UINTN)FirmwarePerformanceTable->BootPointerRecord.BootPerformanceTablePointer;
   mBootPerformanceTableSize = ((BOOT_PERFORMANCE_TABLE *)mBootPerformanceTable)->Header.Length;
 
   return EFI_SUCCESS;
-- 
2.25.1

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to work without ACPI

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jeff
> Brasen via groups.io
> Sent: Saturday, July 1, 2023 1:30 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Jeff Brasen <jbrasen@nvidia.com>
> Subject: [edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to
> work without ACPI
> 
> If the system does not have ACPI setup use the configuration table to get the
> performance info.
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
>  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
>  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11 ++++++++-
> --
>  3 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> index 4a58286b8c1a..d9e1c23a1ee7 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> @@ -54,6 +54,7 @@ [LibraryClasses]
> 
>  [Guids]
>    gPerformanceProtocolGuid                                ## CONSUMES ## SystemTable
> +  gEdkiiFpdtExtendedFirmwarePerformanceGuid               ## CONSUMES ##
> SystemTable
> 
>  [Protocols]
>    gEfiLoadedImageProtocolGuid                             ## CONSUMES
> diff --git
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i
> nf
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i
> nf
> index 013bdbd4a07e..2723fee7066e 100644
> ---
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i
> nf
> +++
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i
> nf
> @@ -55,6 +55,7 @@ [LibraryClasses]
> 
>  [Guids]
>    gPerformanceProtocolGuid                                ## CONSUMES ## SystemTable
> +  gEdkiiFpdtExtendedFirmwarePerformanceGuid               ## CONSUMES ##
> SystemTable
> 
>  [Protocols]
>    gEfiLoadedImageProtocolGuid                             ## CONSUMES
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> index 512a146da6dd..98c84d2ef938 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> @@ -129,17 +129,22 @@ EFI_STATUS
>  GetBootPerformanceTable (
>    )
>  {
> +  EFI_STATUS                  Status;
>    FIRMWARE_PERFORMANCE_TABLE  *FirmwarePerformanceTable;
> 
>    FirmwarePerformanceTable = (FIRMWARE_PERFORMANCE_TABLE
> *)EfiLocateFirstAcpiTable (
> 
> EFI_ACPI_5_0_FIRMWARE_PERFORMANCE_DATA_TABLE_SIGNATURE
>                                                               );
>    if (FirmwarePerformanceTable == NULL) {
> -    ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle);
> -    return EFI_NOT_FOUND;
> +    Status = EfiGetSystemConfigurationTable
> (&gEdkiiFpdtExtendedFirmwarePerformanceGuid, (VOID
> **)&mBootPerformanceTable);
> +    if (EFI_ERROR (Status)) {
> +      ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle);
> +      return EFI_NOT_FOUND;
> +    }
> +  } else {
> +    mBootPerformanceTable = (UINT8
> + *)(UINTN)FirmwarePerformanceTable-
> >BootPointerRecord.BootPerformanceTa
> + blePointer;
>    }
> 
> -  mBootPerformanceTable     = (UINT8
> *)(UINTN)FirmwarePerformanceTable-
> >BootPointerRecord.BootPerformanceTablePointer;
>    mBootPerformanceTableSize = ((BOOT_PERFORMANCE_TABLE
> *)mBootPerformanceTable)->Header.Length;
> 
>    return EFI_SUCCESS;
> --
> 2.25.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107288): https://edk2.groups.io/g/devel/message/107288
Mute This Topic: https://groups.io/mt/99877763/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

[Jeff Brasen via groups.io]

Any additional thoughts/feedback on this patch series?

Thanks,
Jeff


> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Friday, June 30, 2023 11:30 AM
> To: devel@edk2.groups.io
> Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn; dandan.bi@intel.com;
> zhichao.gao@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> Subject: [PATCH v2 0/2] dp command without ACPI
> 
> Systems that do not boot with ACPI (system that use device tree for example)
> can not use the shell dp command. This patch adds this to the configuration
> table so that dp command can get this without the FPDT table.
> 
> I am open to other ways for this to be passed if desired (Installed protocol,
> handler of the status code, etc) but wanted to post this to at least get
> thoughts on this.
> 
> Change Log
> v2 - Fix missing cast for IA32 builds
> 
> -Jeff
> 
> Jeff Brasen (2):
>   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table
>   ShellPkg/Dp: Allow dp command to work without ACPI
> 
>  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
>  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
>  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
>  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11 ++++++++-
> --
>  4 files changed, 12 insertions(+), 3 deletions(-)
> 
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108498): https://edk2.groups.io/g/devel/message/108498
Mute This Topic: https://groups.io/mt/99877761/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

[Gao, Zhichao]

I have reviewed the ShellPkg part. Did you get it reviewed in the MdeModulePkg? If yes, you can inform the maintainers of MdeModulePkg to raise the PR and merge it.

Thanks,
Zhichao

> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Tuesday, September 12, 2023 4:39 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Bi, Dandan <dandan.bi@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: RE: [PATCH v2 0/2] dp command without ACPI
> 
> 
> Any additional thoughts/feedback on this patch series?
> 
> Thanks,
> Jeff
> 
> 
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Friday, June 30, 2023 11:30 AM
> > To: devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > dandan.bi@intel.com; zhichao.gao@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > Subject: [PATCH v2 0/2] dp command without ACPI
> >
> > Systems that do not boot with ACPI (system that use device tree for
> > example) can not use the shell dp command. This patch adds this to the
> > configuration table so that dp command can get this without the FPDT table.
> >
> > I am open to other ways for this to be passed if desired (Installed
> > protocol, handler of the status code, etc) but wanted to post this to
> > at least get thoughts on this.
> >
> > Change Log
> > v2 - Fix missing cast for IA32 builds
> >
> > -Jeff
> >
> > Jeff Brasen (2):
> >   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table
> >   ShellPkg/Dp: Allow dp command to work without ACPI
> >
> >  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
> >  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
> >  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
> >  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11
> ++++++++-
> > --
> >  4 files changed, 12 insertions(+), 3 deletions(-)
> >
> > --
> > 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108524): https://edk2.groups.io/g/devel/message/108524
Mute This Topic: https://groups.io/mt/99877761/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v2 0/2] dp command without ACPI

[gaoliming via groups.io]

For the change in MdeModulePkg, Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Jeff Brasen <jbrasen@nvidia.com>
> 发送时间: 2023年9月12日 4:39
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> dandan.bi@intel.com; zhichao.gao@intel.com
> 主题: RE: [PATCH v2 0/2] dp command without ACPI
> 
> 
> Any additional thoughts/feedback on this patch series?
> 
> Thanks,
> Jeff
> 
> 
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Friday, June 30, 2023 11:30 AM
> > To: devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> dandan.bi@intel.com;
> > zhichao.gao@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> > Subject: [PATCH v2 0/2] dp command without ACPI
> >
> > Systems that do not boot with ACPI (system that use device tree for
> example)
> > can not use the shell dp command. This patch adds this to the
configuration
> > table so that dp command can get this without the FPDT table.
> >
> > I am open to other ways for this to be passed if desired (Installed
protocol,
> > handler of the status code, etc) but wanted to post this to at least get
> > thoughts on this.
> >
> > Change Log
> > v2 - Fix missing cast for IA32 builds
> >
> > -Jeff
> >
> > Jeff Brasen (2):
> >   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table
> >   ShellPkg/Dp: Allow dp command to work without ACPI
> >
> >  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
> >  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
> >  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
> >  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11
> ++++++++-
> > --
> >  4 files changed, 12 insertions(+), 3 deletions(-)
> >
> > --
> > 2.25.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108531): https://edk2.groups.io/g/devel/message/108531
Mute This Topic: https://groups.io/mt/101314093/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

[Jeff Brasen via groups.io]

Anything else needed on this to get it merged?

Thanks,
Jeff

> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, September 12, 2023 6:59 AM
> To: Jeff Brasen <jbrasen@nvidia.com>; devel@edk2.groups.io
> Cc: jian.j.wang@intel.com; dandan.bi@intel.com; zhichao.gao@intel.com
> Subject: 回复: [PATCH v2 0/2] dp command without ACPI
> 
> External email: Use caution opening links or attachments
> 
> 
> For the change in MdeModulePkg, Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: Jeff Brasen <jbrasen@nvidia.com>
> > 发送时间: 2023年9月12日 4:39
> > 收件人: devel@edk2.groups.io
> > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > dandan.bi@intel.com; zhichao.gao@intel.com
> > 主题: RE: [PATCH v2 0/2] dp command without ACPI
> >
> >
> > Any additional thoughts/feedback on this patch series?
> >
> > Thanks,
> > Jeff
> >
> >
> > > -----Original Message-----
> > > From: Jeff Brasen <jbrasen@nvidia.com>
> > > Sent: Friday, June 30, 2023 11:30 AM
> > > To: devel@edk2.groups.io
> > > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > dandan.bi@intel.com;
> > > zhichao.gao@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> > > Subject: [PATCH v2 0/2] dp command without ACPI
> > >
> > > Systems that do not boot with ACPI (system that use device tree for
> > example)
> > > can not use the shell dp command. This patch adds this to the
> configuration
> > > table so that dp command can get this without the FPDT table.
> > >
> > > I am open to other ways for this to be passed if desired (Installed
> protocol,
> > > handler of the status code, etc) but wanted to post this to at least
> > > get thoughts on this.
> > >
> > > Change Log
> > > v2 - Fix missing cast for IA32 builds
> > >
> > > -Jeff
> > >
> > > Jeff Brasen (2):
> > >   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table
> > >   ShellPkg/Dp: Allow dp command to work without ACPI
> > >
> > >  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
> > >  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
> > >  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
> > >  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11
> > ++++++++-
> > > --
> > >  4 files changed, 12 insertions(+), 3 deletions(-)
> > >
> > > --
> > > 2.25.1
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109318): https://edk2.groups.io/g/devel/message/109318
Mute This Topic: https://groups.io/mt/101756432/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

[Gao, Zhichao]

Hi Liming,

This patch set is already reviewed. Can you help on the merge?

Thanks,
Zhichao

> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Wednesday, October 4, 2023 10:37 PM
> To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: RE: [PATCH v2 0/2] dp command without ACPI
> 
> Anything else needed on this to get it merged?
> 
> Thanks,
> Jeff
> 
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Tuesday, September 12, 2023 6:59 AM
> > To: Jeff Brasen <jbrasen@nvidia.com>; devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; dandan.bi@intel.com; zhichao.gao@intel.com
> > Subject: 回复: [PATCH v2 0/2] dp command without ACPI
> >
> > External email: Use caution opening links or attachments
> >
> >
> > For the change in MdeModulePkg, Reviewed-by: Liming Gao
> > <gaoliming@byosoft.com.cn>
> >
> > > -----邮件原件-----
> > > 发件人: Jeff Brasen <jbrasen@nvidia.com>
> > > 发送时间: 2023年9月12日 4:39
> > > 收件人: devel@edk2.groups.io
> > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > dandan.bi@intel.com; zhichao.gao@intel.com
> > > 主题: RE: [PATCH v2 0/2] dp command without ACPI
> > >
> > >
> > > Any additional thoughts/feedback on this patch series?
> > >
> > > Thanks,
> > > Jeff
> > >
> > >
> > > > -----Original Message-----
> > > > From: Jeff Brasen <jbrasen@nvidia.com>
> > > > Sent: Friday, June 30, 2023 11:30 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > dandan.bi@intel.com;
> > > > zhichao.gao@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> > > > Subject: [PATCH v2 0/2] dp command without ACPI
> > > >
> > > > Systems that do not boot with ACPI (system that use device tree
> > > > for
> > > example)
> > > > can not use the shell dp command. This patch adds this to the
> > configuration
> > > > table so that dp command can get this without the FPDT table.
> > > >
> > > > I am open to other ways for this to be passed if desired
> > > > (Installed
> > protocol,
> > > > handler of the status code, etc) but wanted to post this to at
> > > > least get thoughts on this.
> > > >
> > > > Change Log
> > > > v2 - Fix missing cast for IA32 builds
> > > >
> > > > -Jeff
> > > >
> > > > Jeff Brasen (2):
> > > >   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config table
> > > >   ShellPkg/Dp: Allow dp command to work without ACPI
> > > >
> > > >  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
> > > >  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
> > > >  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
> > > >  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11
> > > ++++++++-
> > > > --
> > > >  4 files changed, 12 insertions(+), 3 deletions(-)
> > > >
> > > > --
> > > > 2.25.1
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109664): https://edk2.groups.io/g/devel/message/109664
Mute This Topic: https://groups.io/mt/101756432/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] dp command without ACPI

[Jeff Brasen via groups.io]

Anything else needed to get this merged as the November stable release is coming up.

Thanks,
Jeff

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Monday, October 16, 2023 8:39 PM
> To: Jeff Brasen <jbrasen@nvidia.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>
> Subject: RE: [PATCH v2 0/2] dp command without ACPI
> 
> External email: Use caution opening links or attachments
> 
> 
> Hi Liming,
> 
> This patch set is already reviewed. Can you help on the merge?
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Wednesday, October 4, 2023 10:37 PM
> > To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Bi, Dandan
> > <dandan.bi@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: RE: [PATCH v2 0/2] dp command without ACPI
> >
> > Anything else needed on this to get it merged?
> >
> > Thanks,
> > Jeff
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Tuesday, September 12, 2023 6:59 AM
> > > To: Jeff Brasen <jbrasen@nvidia.com>; devel@edk2.groups.io
> > > Cc: jian.j.wang@intel.com; dandan.bi@intel.com;
> > > zhichao.gao@intel.com
> > > Subject: 回复: [PATCH v2 0/2] dp command without ACPI
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > For the change in MdeModulePkg, Reviewed-by: Liming Gao
> > > <gaoliming@byosoft.com.cn>
> > >
> > > > -----邮件原件-----
> > > > 发件人: Jeff Brasen <jbrasen@nvidia.com>
> > > > 发送时间: 2023年9月12日 4:39
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > dandan.bi@intel.com; zhichao.gao@intel.com
> > > > 主题: RE: [PATCH v2 0/2] dp command without ACPI
> > > >
> > > >
> > > > Any additional thoughts/feedback on this patch series?
> > > >
> > > > Thanks,
> > > > Jeff
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Jeff Brasen <jbrasen@nvidia.com>
> > > > > Sent: Friday, June 30, 2023 11:30 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > dandan.bi@intel.com;
> > > > > zhichao.gao@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> > > > > Subject: [PATCH v2 0/2] dp command without ACPI
> > > > >
> > > > > Systems that do not boot with ACPI (system that use device tree
> > > > > for
> > > > example)
> > > > > can not use the shell dp command. This patch adds this to the
> > > configuration
> > > > > table so that dp command can get this without the FPDT table.
> > > > >
> > > > > I am open to other ways for this to be passed if desired
> > > > > (Installed
> > > protocol,
> > > > > handler of the status code, etc) but wanted to post this to at
> > > > > least get thoughts on this.
> > > > >
> > > > > Change Log
> > > > > v2 - Fix missing cast for IA32 builds
> > > > >
> > > > > -Jeff
> > > > >
> > > > > Jeff Brasen (2):
> > > > >   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config
> table
> > > > >   ShellPkg/Dp: Allow dp command to work without ACPI
> > > > >
> > > > >  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |  1 +
> > > > >  .../DpDynamicCommand/DpDynamicCommand.inf             |  1 +
> > > > >  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
> > > > >  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c         | 11
> > > > ++++++++-
> > > > > --
> > > > >  4 files changed, 12 insertions(+), 3 deletions(-)
> > > > >
> > > > > --
> > > > > 2.25.1
> > >
> > >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110334): https://edk2.groups.io/g/devel/message/110334
Mute This Topic: https://groups.io/mt/101756432/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v2 0/2] dp command without ACPI

[gaoliming via groups.io]

Create PR https://github.com/tianocore/edk2/pull/5003 for this patch set. 

> -----邮件原件-----
> 发件人: Gao, Zhichao <zhichao.gao@intel.com>
> 发送时间: 2023年10月17日 10:39
> 收件人: Jeff Brasen <jbrasen@nvidia.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Wang, Jian J <jian.j.wang@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>
> 主题: RE: [PATCH v2 0/2] dp command without ACPI
> 
> Hi Liming,
> 
> This patch set is already reviewed. Can you help on the merge?
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Wednesday, October 4, 2023 10:37 PM
> > To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Bi, Dandan
> > <dandan.bi@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: RE: [PATCH v2 0/2] dp command without ACPI
> >
> > Anything else needed on this to get it merged?
> >
> > Thanks,
> > Jeff
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Tuesday, September 12, 2023 6:59 AM
> > > To: Jeff Brasen <jbrasen@nvidia.com>; devel@edk2.groups.io
> > > Cc: jian.j.wang@intel.com; dandan.bi@intel.com; zhichao.gao@intel.com
> > > Subject: 回复: [PATCH v2 0/2] dp command without ACPI
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > For the change in MdeModulePkg, Reviewed-by: Liming Gao
> > > <gaoliming@byosoft.com.cn>
> > >
> > > > -----邮件原件-----
> > > > 发件人: Jeff Brasen <jbrasen@nvidia.com>
> > > > 发送时间: 2023年9月12日 4:39
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > dandan.bi@intel.com; zhichao.gao@intel.com
> > > > 主题: RE: [PATCH v2 0/2] dp command without ACPI
> > > >
> > > >
> > > > Any additional thoughts/feedback on this patch series?
> > > >
> > > > Thanks,
> > > > Jeff
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Jeff Brasen <jbrasen@nvidia.com>
> > > > > Sent: Friday, June 30, 2023 11:30 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > dandan.bi@intel.com;
> > > > > zhichao.gao@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> > > > > Subject: [PATCH v2 0/2] dp command without ACPI
> > > > >
> > > > > Systems that do not boot with ACPI (system that use device tree
> > > > > for
> > > > example)
> > > > > can not use the shell dp command. This patch adds this to the
> > > configuration
> > > > > table so that dp command can get this without the FPDT table.
> > > > >
> > > > > I am open to other ways for this to be passed if desired
> > > > > (Installed
> > > protocol,
> > > > > handler of the status code, etc) but wanted to post this to at
> > > > > least get thoughts on this.
> > > > >
> > > > > Change Log
> > > > > v2 - Fix missing cast for IA32 builds
> > > > >
> > > > > -Jeff
> > > > >
> > > > > Jeff Brasen (2):
> > > > >   MdeModulePkg/DxeCorePerformanceLib: Install BPDT in config
> table
> > > > >   ShellPkg/Dp: Allow dp command to work without ACPI
> > > > >
> > > > >  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf    |
> 1 +
> > > > >  .../DpDynamicCommand/DpDynamicCommand.inf             |
> 1 +
> > > > >  .../DxeCorePerformanceLib/DxeCorePerformanceLib.c     |  2 ++
> > > > >  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> | 11
> > > > ++++++++-
> > > > > --
> > > > >  4 files changed, 12 insertions(+), 3 deletions(-)
> > > > >
> > > > > --
> > > > > 2.25.1
> > >
> > >





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110693): https://edk2.groups.io/g/devel/message/110693
Mute This Topic: https://groups.io/mt/102412309/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-