From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mcb30@ipxe.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2001:ba8:0:1d4::6950:5845; helo=duck.fensystems.co.uk;
 envelope-from=mcb30@ipxe.org; receiver=edk2-devel@lists.01.org 
Received: from duck.fensystems.co.uk (duck.fensystems.co.uk
 [IPv6:2001:ba8:0:1d4::6950:5845])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 6E3B721F2E17B
 for <edk2-devel@lists.01.org>; Tue, 17 Apr 2018 01:24:05 -0700 (PDT)
Received: from pudding.home (cbs92326-cmbg19-2-0-cust10.5-4.cable.virginm.net
 [86.1.148.75])
 by duck.fensystems.co.uk (Postfix) with ESMTPSA id B4238144E9;
 Tue, 17 Apr 2018 09:24:03 +0100 (BST)
To: Laszlo Ersek <lersek@redhat.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "Gao, Liming" <liming.gao@intel.com>
References: <20180413174211.858-1-leif.lindholm@linaro.org>
 <E92EE9817A31E24EB0585FDF735412F5B89CEDA3@ORSMSX113.amr.corp.intel.com>
 <20180413193143.t45tua3yi7sopk4d@bivouac.eciton.net>
 <E92EE9817A31E24EB0585FDF735412F5B89CF029@ORSMSX113.amr.corp.intel.com>
 <20180416100712.6v642ycksvmoffvt@bivouac.eciton.net>
 <E92EE9817A31E24EB0585FDF735412F5B89CF92E@ORSMSX113.amr.corp.intel.com>
 <52ea5684-380d-0519-2545-6ef7f62198ae@ipxe.org>
 <09cc135a-c3b7-bcbd-1a71-6454e3ba7623@redhat.com>
 <52f131ae-ed51-9276-ac91-e3dded7472e2@ipxe.org>
 <56ad661e-3f48-3889-0641-ae64e8da178a@redhat.com>
From: Michael Brown <mcb30@ipxe.org>
Message-ID: <260807ce-5a94-f07e-3121-32fbf70712a8@ipxe.org>
Date: Tue, 17 Apr 2018 09:24:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <56ad661e-3f48-3889-0641-ae64e8da178a@redhat.com>
Subject: Re: [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 08:24:05 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit

On 17/04/18 09:01, Laszlo Ersek wrote:
> The thing is, the BeIoLib and LeIoLib classes are already good for this
> -- they can be implemented as you suggest. So no need to call the
> function SwapIfNeededForBigEndianDeviceMmioRead16(), just call it
> BeMmioRead16().

I know.  I thought that suggesting a 40-character function name and a 
runtime check in case the CPU endianness changed mid-execution would be 
sufficiently obviously ridiculous, but I fear that it may have sounded 
too plausible for EDK2.

Michael