From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot To: Rebecca Cran ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.53) X-Originating-Platform: Mac Firefox 105 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 07 Oct 2022 05:34:21 -0700 References: <20221007113805.43823-1-rebecca@quicinc.com> In-Reply-To: <20221007113805.43823-1-rebecca@quicinc.com> Message-ID: <26156.1665146061357606600@groups.io> Content-Type: multipart/alternative; boundary="jxY7IwjjB9EipaMJpV4P" --jxY7IwjjB9EipaMJpV4P Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Thank you for this patch. On Fri, Oct 7, 2022 at 04:38 AM, Rebecca Cran wrote: >=20 > + CharCount =3D AsciiSPrint ( > + Buffer, > + sizeof (Buffer), > + "UEFI firmware (version %s built at %a on %a)\n\r", > + (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString), > + __TIME__, > + __DATE__ > + ); Can you check if uncrustify reports any issue with the above, please? Other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar --jxY7IwjjB9EipaMJpV4P Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Rebecca,

Thank you for this patch.

On Fri, Oct 7, = 2022 at 04:38 AM, Rebecca Cran wrote:
+ CharCount =3D AsciiSPrint (
+ Buffer,
+ sizeof (Buf= fer),
+ "UEFI firmware (version %s built at %a on %a)\n\r",
+ (CH= AR16 *)PcdGetPtr (PcdFirmwareVersionString),
+ __TIME__,
+ __DATE= __
+ );
Can you check if uncrustify reports any issue with the above, please?
= Other than that this patch looks good to me.

Reviewed-by: Sami M= ujawar <sami.mujawar@arm.com>

Regards,

Sami Muj= awar --jxY7IwjjB9EipaMJpV4P--