From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.9797.1620722211208283823 for ; Tue, 11 May 2021 01:36:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NbXFBQE2; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620722210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=73FdUSU5WuVKUIyFJaPequtOCU4ZMQhzYfeOd3tFnpE=; b=NbXFBQE2wN8mO0+QBoJtEcFT14nkI8zzXQ7KmgrZzfYgJryMAZIjt0JkTZvI5PpGxZa3J2 v2wBMC5nI6oCmyuV0YFLlyLbvW35vigs9e2C5czNFLV1whOG1VYLwdqLfzMz4oa9jqAyxY zGYranelMSRW2r2EGHs2syj0eJ+2Sq0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-1Yh1-U6GNw-ekLqUTgcLPw-1; Tue, 11 May 2021 04:36:47 -0400 X-MC-Unique: 1Yh1-U6GNw-ekLqUTgcLPw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4522580ED8E; Tue, 11 May 2021 08:36:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-233.ams2.redhat.com [10.36.112.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id B29585D9D7; Tue, 11 May 2021 08:36:42 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 02/13] MdePkg/Amd: add white spaces to retain alignment for future expansion To: devel@edk2.groups.io, brijesh.singh@amd.com Cc: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu References: <20210507203838.23706-1-brijesh.singh@amd.com> <20210507203838.23706-3-brijesh.singh@amd.com> From: "Laszlo Ersek" Message-ID: <261cba2b-a3a9-882b-6c7f-61eb4f98b8a7@redhat.com> Date: Tue, 11 May 2021 10:36:41 +0200 MIME-Version: 1.0 In-Reply-To: <20210507203838.23706-3-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/07/21 22:38, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of the GHCB spec introduces several new SNP-specific NAEs. > Unfortunately, the names for those NAEs break the alignment. Add some > white spaces so that the SNP support patches do not break the alignment. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Brijesh Singh > --- > MdePkg/Include/Register/Amd/Fam17Msr.h | 10 +++++----- > MdePkg/Include/Register/Amd/Ghcb.h | 12 ++++++------ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Msr.h > index 716d52fd508d..7368ce7af02a 100644 > --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > @@ -53,11 +53,11 @@ typedef union { > UINT64 GhcbPhysicalAddress; > } MSR_SEV_ES_GHCB_REGISTER; > > -#define GHCB_INFO_SEV_INFO 1 > -#define GHCB_INFO_SEV_INFO_GET 2 > -#define GHCB_INFO_CPUID_REQUEST 4 > -#define GHCB_INFO_CPUID_RESPONSE 5 > -#define GHCB_INFO_TERMINATE_REQUEST 256 > +#define GHCB_INFO_SEV_INFO 1 > +#define GHCB_INFO_SEV_INFO_GET 2 > +#define GHCB_INFO_CPUID_REQUEST 4 > +#define GHCB_INFO_CPUID_RESPONSE 5 > +#define GHCB_INFO_TERMINATE_REQUEST 256 > > #define GHCB_TERMINATE_GHCB 0 > #define GHCB_TERMINATE_GHCB_GENERAL 0 > diff --git a/MdePkg/Include/Register/Amd/Ghcb.h b/MdePkg/Include/Register/Amd/Ghcb.h > index ccdb662af7a7..712dc8e769c0 100644 > --- a/MdePkg/Include/Register/Amd/Ghcb.h > +++ b/MdePkg/Include/Register/Amd/Ghcb.h > @@ -49,12 +49,12 @@ > // > // VMG Special Exit Codes > // > -#define SVM_EXIT_MMIO_READ 0x80000001ULL > -#define SVM_EXIT_MMIO_WRITE 0x80000002ULL > -#define SVM_EXIT_NMI_COMPLETE 0x80000003ULL > -#define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL > -#define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL > -#define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL > +#define SVM_EXIT_MMIO_READ 0x80000001ULL > +#define SVM_EXIT_MMIO_WRITE 0x80000002ULL > +#define SVM_EXIT_NMI_COMPLETE 0x80000003ULL > +#define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL > +#define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL > +#define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL > > // > // IOIO Exit Information > Based on Liming's feedback at , I'll change the subject of this patch to: MdePkg/Register/Amd: realign macros with more space for future expansion (72 chars) Reviewed-by: Laszlo Ersek Thanks, Laszlo