From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6BC9E740039 for ; Wed, 29 May 2024 15:27:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ciWjzJzHvud3hTmReGa5L9m8U8zAcYE1cKmC2mmgkWc=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1716996463; v=1; b=pXRo5ZRQWE5fnIHc6wtqsAsD8sXRyZTrq15RfG18xJ5UyAO8woar6tTt4IbmiwpulGCKayGh yrxxn/24VeAp0yd1/dQ0rLTLj9BEa2+i+8pG8OXFGNioc35wDi2IsilIEWwY/qMUAnESFarH4PI HMVNRF734AyFVNEbXRlSb42WOoVhL08TjxLTabW8CuvWppb3ZsID6gHPHw57S9OaXYGvDBhhm/G 6PV0CU0UszlHuiEH77mp8lYM4A91MBNe49cqpTBUSzlTi4Rttk3b/i3saGnhlUVMir72Sjcm9bV yfqmWqekLr6yDidNiHqiXXfzrSOag/yFwVH6l2M84PMwg== X-Received: by 127.0.0.2 with SMTP id p5PoYY7687511x4fZF5zig9B; Wed, 29 May 2024 08:27:42 -0700 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V4 00/17] Split NorFlashDxe driver and add CadenceQspiNorFlashDeviceLib library To: "Sahil Kaushal" , devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.49) X-Originating-Platform: Mac Safari 17.4 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 29 May 2024 08:27:41 -0700 References: <20240529085517.1074417-1-Sahil.Kaushal@arm.com> In-Reply-To: <20240529085517.1074417-1-Sahil.Kaushal@arm.com> Message-ID: <26273.1716996461478362530@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WlKPVhfOyDCg7p31r9ixa5pAx7686176AA= Content-Type: multipart/alternative; boundary="H0YQhp6NmzUcxLJnfE9s" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pXRo5ZRQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --H0YQhp6NmzUcxLJnfE9s Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Other than my comments for patch 14 and 15 (the changes for which I will fi= x locally before merging), this patch series looks good to me. For this series, Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119354): https://edk2.groups.io/g/devel/message/119354 Mute This Topic: https://groups.io/mt/106365450/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --H0YQhp6NmzUcxLJnfE9s Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Other than my comments for patch 14 and 15 (the changes for which I will fi= x locally before merging), this patch series looks good to me.

F= or this series,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.c= om>

Regards,

Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119354) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--H0YQhp6NmzUcxLJnfE9s--