public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <spbrogan@outlook.com>
To: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib
Date: Thu, 24 Sep 2020 15:23:23 -0700	[thread overview]
Message-ID: <26298.1600986203114586203@groups.io> (raw)
In-Reply-To: <DM6PR11MB4315FA7A40927A7F854D90E8CB3C0@DM6PR11MB4315.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

This seems like a big enough "platform" difference that we should be testing in platform ci.

To do that you would need to add another item in the matrix here

https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L26

and here:
https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml#L25

An example in OVMF of how this is done is here
https://github.com/tianocore/edk2/blob/master/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L95

[-- Attachment #2: Type: text/html, Size: 993 bytes --]

      parent reply	other threads:[~2020-09-24 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19  5:38 [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib Wadhawan, Divneil R
2020-09-19 19:40 ` [edk2-devel] " Matthew Carlson
2020-09-23 13:40 ` Samer El-Haj-Mahmoud
2020-09-23 21:02   ` Matthew Carlson
2020-09-24 22:23 ` Sean [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26298.1600986203114586203@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox