Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

["Kun Qin" <kuqin12@gmail.com>]

Hi Zhiguang,

I do not mind check the reviewed patches (the first 3 changes, 
specifically) in first. I have not done this before. How you want to 
proceed in that case?

Regards,
Kun

On 03/17/2021 00:52, Liu, Zhiguang wrote:
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> Hi Kun,
> Since the first two changes about MinPlatformPkg already got reviewed, can we first check them in?
> 
> Thanks
> Zhiguang
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
>> Sent: Wednesday, March 17, 2021 2:11 AM
>> To: devel@edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
>> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>
>> This change added NULL MmUnblockMemoryLib instance in dsc files of
>> CoreCommonLib to resolve newly introduced dependency. The library
>> interface is consumed by VariableSmmRuntimeDxe to better support
>> variable runtime cache feature.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>>
>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>> ---
>>
>> Notes:
>>      v2:
>>      - Added reviewed-by tag [Liming]
>>
>>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> index cb40e111b5dd..bcabb797e91a 100644
>> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> @@ -159,6 +159,7 @@ [LibraryClasses.common]
>>     LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
>>
>>     SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
>> +
>> +
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
>> ckMemoryLi
>> + bNull.inf
>>
>>     SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLi
>> b.inf
>> --
>> 2.30.0.windows.1
>>
>>
>>
>> 
>>
>