From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mx.groups.io with SMTP id smtpd.web09.3409.1615968640899599877 for ; Wed, 17 Mar 2021 01:10:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=H4pvRsL7; spf=pass (domain: gmail.com, ip: 209.85.210.171, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f171.google.com with SMTP id j25so573171pfe.2 for ; Wed, 17 Mar 2021 01:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Kbuh1MND71RuJi7ioXo03qMn99a3nodoDx6vSLJqoSA=; b=H4pvRsL7TQYGIOQixYRT8L8aowX8YbQmLyzNfAsJnR9HmhtBl29KKYjAqhFAJsxkSL QO1G4DtX9aLoFoKhRMvsKqoVZPxrxVYMjqB0dlq1Bt/KrfrS+QqXxpF5w40VNdJcXdRO dnWdZzQ5LnJ52Ek2eGh+kppHDKdYuhE+MWtE1cVi0EX/yCkye7Go53jsuXTZJdgPluab AgQbQRWmQBrS0Q/WPpCUcxCD0UTmFkDryXrDLsnILT2IRfvp4IgZwIldFAKEF3dTNc+r xuUBGwFoKQD+aSv1MAz+Thn4mIdE4SgYqnUVMksamJRc+CqndvDT/42g9+Uztv5Gm5SO srQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kbuh1MND71RuJi7ioXo03qMn99a3nodoDx6vSLJqoSA=; b=kUt4g7XgcJU71TkOH+DSuGASaZkhO1dlCSmZfwPYPbGu0+9DOL8z5Qz6chFN9qAIP3 7KUt5f1J1jq7nIamGh0Rk4Hc37jfuIGIXIijMVyQpIK/iOVF1ftyanOak/aUplyCRSwv TJcs7+EFC932c1SczDEKg+niTDNRAlrRcESkTl7d/VikfeenVc79TEjLXNYpvkwAMYv2 CAGx4rTtdrx10tFemGwj7yWthEoQv0kABXZSF3m5jO7dPpm0donhsimQSjogxlPttrQ5 O3exMolMvRAWWOtMH9vh5Bc99BcYt+ym6KHirhcuO7ohe4BD/rFYeH0wsh06RiFslTe/ 1VgQ== X-Gm-Message-State: AOAM53247FQ3YMpkx9BbzUpOkedSq39Qyxi0lTa3nIcYJ6b57v69JeyG 6cku+Dcs1t5nTJExQvKtJxc= X-Google-Smtp-Source: ABdhPJzxyBVpk+972HaZ2LEGohK2bzle5zgBxaHcYK5/ryNRjyQ37LULjGqjBCdOqQVgFjR1djzOqA== X-Received: by 2002:a65:4782:: with SMTP id e2mr1700122pgs.93.1615968640280; Wed, 17 Mar 2021 01:10:40 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id ha8sm1693149pjb.6.2021.03.17.01.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 01:10:39 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe To: "Liu, Zhiguang" , "devel@edk2.groups.io" Cc: "Chiu, Chasel" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" References: <20210316181038.1413-1-kuqin12@gmail.com> <20210316181038.1413-2-kuqin12@gmail.com> From: "Kun Qin" Message-ID: <2647f43c-b74c-d9b6-f446-2e75c0036130@gmail.com> Date: Wed, 17 Mar 2021 01:10:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Zhiguang, I do not mind check the reviewed patches (the first 3 changes, specifically) in first. I have not done this before. How you want to proceed in that case? Regards, Kun On 03/17/2021 00:52, Liu, Zhiguang wrote: > Reviewed-by: Zhiguang Liu > > Hi Kun, > Since the first two changes about MinPlatformPkg already got reviewed, can we first check them in? > > Thanks > Zhiguang > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Kun Qin >> Sent: Wednesday, March 17, 2021 2:11 AM >> To: devel@edk2.groups.io >> Cc: Chiu, Chasel ; Desimone, Nathaniel L >> ; Liming Gao >> ; Dong, Eric >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: >> CoreCommonLib: Added new library for VariableSmmRuntimeDxe >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 >> >> This change added NULL MmUnblockMemoryLib instance in dsc files of >> CoreCommonLib to resolve newly introduced dependency. The library >> interface is consumed by VariableSmmRuntimeDxe to better support >> variable runtime cache feature. >> >> Cc: Chasel Chiu >> Cc: Nate DeSimone >> Cc: Liming Gao >> Cc: Eric Dong >> >> Signed-off-by: Kun Qin >> Reviewed-by: Liming Gao >> --- >> >> Notes: >> v2: >> - Added reviewed-by tag [Liming] >> >> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc >> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc >> index cb40e111b5dd..bcabb797e91a 100644 >> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc >> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc >> @@ -159,6 +159,7 @@ [LibraryClasses.common] >> LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf >> >> SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf >> + >> + >> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo >> ckMemoryLi >> + bNull.inf >> >> SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLi >> b.inf >> -- >> 2.30.0.windows.1 >> >> >> >> >> >