From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.66, mailfrom: philmd@redhat.com)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Fri, 19 Jul 2019 10:13:45 -0700
Received: by mail-wm1-f66.google.com with SMTP id h19so24148738wme.0
        for <devel@edk2.groups.io>; Fri, 19 Jul 2019 10:13:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=bMRbXr5tNq/VYOSEhF23rOtaLmFc3KQLL+P0gKf3pg8=;
        b=j/bRnMDrMDMTTiccwNLExBgeIWsMckv36ZDg2cPIaIvHOqeUYlr4cithvSEpJV0mr9
         QIim2mKBu+nJnB4qoNnmEPu4k1xTTBVgKycRfvMr2lQ/2Or2ytQXdTR0vbwn8yIaTn9m
         hSU7oe7Q/NdGowuVJSGeEA4K9eLT9jTKBeE/uNhlDXySPSYNKQHZ7qUg1X7IQ4ktrhZw
         kn33oRcdJl5VjNMvx+sn6TB6WwnC4rfErjLvQ0trH2F6+PQ4DQsi5S11uOctcDA/HwT0
         +W/WT70/kMKaZZedcsUja7GoZrAtPfD/77CDyy8weniZ23NMftFZdv//na0d0k718vEz
         ArKg==
X-Gm-Message-State: APjAAAVG1PDGI9o5D06jxm4E9fTuKTRcRiMAJbrbdk/kKHaJkBsfcDpI
	V7zopWCV3Ns25tGhI4JLPtGHZHALDUU=
X-Google-Smtp-Source: APXvYqwIZCa6VS5dsV9H8k/xV6YuSwGGwQ6bp9ZuRw1cqF39AURuWQ6DACwcJ9HZqxanblsdwMpBNA==
X-Received: by 2002:a1c:b146:: with SMTP id a67mr47970177wmf.124.1563556423622;
        Fri, 19 Jul 2019 10:13:43 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62])
        by smtp.gmail.com with ESMTPSA id q10sm32363372wrf.32.2019.07.19.10.13.42
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Fri, 19 Jul 2019 10:13:43 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH 2/4] ArmPlatformPkg: list module-internal header files in INF [Sources]
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Leif Lindholm <leif.lindholm@linaro.org>
References: <20190719164319.9070-1-lersek@redhat.com>
 <20190719164319.9070-3-lersek@redhat.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <264fc4a2-a142-6d34-aa08-d5c6f63607f3@redhat.com>
Date: Fri, 19 Jul 2019 19:13:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190719164319.9070-3-lersek@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/19/19 6:43 PM, Laszlo Ersek wrote:
> The BaseTools build feature introduced for TianoCore#1804 / in commit
> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file",
> 2019-06-10) logs some (non-fatal) warnings about unlisted internal header
> files. List those files explicitly.
> 
> Note: header files are added in lexicographical order only if the
> underlying INF file already keeps the [Sources] and [LibraryClasses]
> sections in lexicographical order. Otherwise, header files are added in
> rough "logical" order.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf                     | 1 +
>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 1 +
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                         | 1 +
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                        | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> index f17a9301a4ac..a647c016878d 100644
> --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> @@ -17,6 +17,7 @@ [Defines]
>    ENTRY_POINT                    = NorFlashInitialise
>  
>  [Sources.common]
> +  NorFlashDxe.h
>    NorFlashDxe.c
>    NorFlashFvbDxe.c
>    NorFlashBlockIoDxe.c
> diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> index 4c62311f5d41..8224617f20ab 100644
> --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> @@ -17,6 +17,7 @@ [Defines]
>    LIBRARY_CLASS                  = RealTimeClockLib|DXE_RUNTIME_DRIVER
>  
>  [Sources.common]
> +  PL031RealTimeClock.h
>    PL031RealTimeClockLib.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> index 0e112710dcfc..f2ac45d171bc 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> @@ -16,6 +16,7 @@ [Defines]
>  
>  [Sources.common]
>    MainMPCore.c
> +  PrePeiCore.h
>    PrePeiCore.c
>  
>  [Sources.ARM]
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> index c163a818c407..84c319c3679b 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> @@ -15,6 +15,7 @@ [Defines]
>    VERSION_STRING                 = 1.0
>  
>  [Sources.common]
> +  PrePeiCore.h
>    PrePeiCore.c
>    MainUniCore.c
>  
>