From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.2059.1588144926162706547 for ; Wed, 29 Apr 2020 00:22:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Abb5JHXd; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588144925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7WnZirsqqx/4OWAh4adHSgk8tB20r8CWfAxB8g+l/p8=; b=Abb5JHXdT5/HSDD+LTYX5VFlI6G7jI2pZcE/o3T+x8hTucMVAts7CrWEZjbmF9crnnpCh6 C+E6gI2BTqWc+o0rUElInscwQsMEfbT3Oj7lJhuPE3VmCdKDzMKWO9ukOPjot2stCoTxsj mwLzhUMuIEkNXjtUzgMhFVimyfnpDtA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-fxaN2ri7MGi6-o_HGkt1vw-1; Wed, 29 Apr 2020 03:21:18 -0400 X-MC-Unique: fxaN2ri7MGi6-o_HGkt1vw-1 Received: by mail-wr1-f70.google.com with SMTP id o8so1270695wrm.11 for ; Wed, 29 Apr 2020 00:21:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YvzdibNQoNi9enCcuzeUjTLnFxCSGnupHLzXKPKczS4=; b=SpmlcDeuAItHTVcDnFE5RdoXJ5V4aCaWwUI1LBLJRW28mLbnbJmmIRMnCCTy/F0YLw iHgff9WZvaR5Zt0EXoIKlqV9LDqp1XAhSo8ciHHc20ryp1NtyowQ3sQIm/UvPzmC91+4 tPA7k0o/Xjgo7/arJTenR/P3PB4EM4b0lMegSo2H0brtr3Q74S+yRBUqgmo4SpjPynnI wtxDRq2l7HTk8kNm71IBeC6Z9vIGw9OHlxz4wJrsxnXwbQ8SijZx59yEh0nyuaqMia43 seESB8NNO1Z/ypU72HeCAEY+aiDPOSsBQ529uMeeeH0P3+uohuyTC7AZk31qnvf9oFa5 CUYQ== X-Gm-Message-State: AGi0PuY69KNJ9yplyDC2OFuoq+3SyEOenN//66kdwsZE6eSJ7UINXPKa +H6gJuQD3QEI4HdtySEGkXz6DXHZHi1CBSvqIdcIYtxj7RXsJSFr1Z46nvdncOxyuBLpD5Odp+k SqcngU/Vpk9swGw== X-Received: by 2002:a7b:c250:: with SMTP id b16mr1702699wmj.100.1588144876473; Wed, 29 Apr 2020 00:21:16 -0700 (PDT) X-Google-Smtp-Source: APiQypLfLVIh+boJ6CqbybOP1wJvHlftod4wnGCRVBG6FTFijSt+RPR+GNz+A6MFey+Y0gGZV41IUg== X-Received: by 2002:a7b:c250:: with SMTP id b16mr1702675wmj.100.1588144876172; Wed, 29 Apr 2020 00:21:16 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id o28sm29074051wra.84.2020.04.29.00.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 00:21:15 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 0/7] OvmfPkg, ArmVirtPkg: control PXE v4/v6 boot support from the QEMU cmdline To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Jordan Justen , Leif Lindholm , Per Sundstrom References: <20200424075353.8489-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <265c54c3-1833-5074-7735-c6bac34f1604@redhat.com> Date: Wed, 29 Apr 2020 09:21:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/29/20 12:39 AM, Laszlo Ersek wrote: > On 04/24/20 09:53, Laszlo Ersek wrote: >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2681 >> Repo: https://pagure.io/lersek/edk2.git >> Branch: pxe_fw_cfg >> >> With this series applied, the QEMU command line options listed below >> control whether the guest firmware supports PXEv4 / PXEv6 boot. And >> correspondingly, whether UefiBootManagerLib generates *new* PXEv4 / >> PXEv6 boot options automatically. (Existent boot options are never >> deleted in response to just the flags below.) >> >> -fw_cfg name=3Dopt/org.tianocore/IPv4PXESupport,string=3D[yn] >> >> -fw_cfg name=3Dopt/org.tianocore/IPv6PXESupport,string=3D[yn] >=20 > Merged as commit range 64ab457d1f21..cdc3fa54184a, via > . >=20 > I thank everyone for the feedback. >=20 > Phil, regarding your comment under patch#5: the PCD "get" interfaces do > not have "deprecated" vs. "current" variants. Only the "set" interfaces > do. "Get" is always supposed to succeed. "Set" may fail. Oh I see, it makes sense. >=20 > See commit 9a3558419509 ("MdePkg: Add a set of PcdSetXXS APIs into > PcdLib and remove the ASSERT in original PcdSetXX APIs.", 2015-04-10). Got it, thanks for the pointer! >=20 > See also EFI_PCD_PROTOCOL in the Platform Init spec: > . >=20 > Thanks! > Laszlo >=20 >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Leif Lindholm >> Cc: Per Sundstrom >> Cc: Philippe Mathieu-Daud=C3=A9 >> >> Thanks >> Laszlo >> >> Laszlo Ersek (7): >> OvmfPkg: introduce QemuFwCfgSimpleParserLib >> OvmfPkg/PlatformPei: parse "X-PciMmio64Mb" with >> QemuFwCfgSimpleParserLib >> OvmfPkg/PlatformPei: use QemuFwCfgParseBool in >> UPDATE_BOOLEAN_PCD_FROM_... >> OvmfPkg/QemuFwCfgDxeLib: allow UEFI_DRIVER modules >> OvmfPkg: control PXEv4 / PXEv6 boot support from the QEMU command lin= e >> ArmVirtPkg/QemuFwCfgLib: allow UEFI_DRIVER modules >> ArmVirtPkg: control PXEv4 / PXEv6 boot support from the QEMU command >> line >> >> ArmVirtPkg/ArmVirtQemu.dsc = | 13 + >> ArmVirtPkg/ArmVirtQemuKernel.dsc = | 13 + >> ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf = | 2 +- >> OvmfPkg/Include/Library/QemuFwCfgSimpleParserLib.h = | 128 +++++++ >> OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcd.c = | 39 ++ >> OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf = | 33 ++ >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf = | 2 +- >> OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParser.c = | 398 ++++++++++++++++++++ >> OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf = | 27 ++ >> OvmfPkg/OvmfPkg.dec = | 4 + >> OvmfPkg/OvmfPkgIa32.dsc = | 10 + >> OvmfPkg/OvmfPkgIa32X64.dsc = | 11 + >> OvmfPkg/OvmfPkgX64.dsc = | 10 + >> OvmfPkg/PlatformPei/MemDetect.c = | 36 +- >> OvmfPkg/PlatformPei/Platform.c = | 47 +-- >> OvmfPkg/PlatformPei/PlatformPei.inf = | 1 + >> 16 files changed, 712 insertions(+), 62 deletions(-) >> create mode 100644 OvmfPkg/Include/Library/QemuFwCfgSimpleParserLib.h >> create mode 100644 OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcd.c >> create mode 100644 OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProduce= rLib.inf >> create mode 100644 OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgS= impleParser.c >> create mode 100644 OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgS= impleParserLib.inf >> >=20