* [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState
@ 2021-09-08 19:14 Heinrich Schuchardt
2021-10-12 8:09 ` [edk2-devel] " G Edhaya Chandran
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-09-08 19:14 UTC (permalink / raw)
To: EDK II Development
Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen,
Samer El-Haj-Mahmoud, Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3390
According to the UEFI specification
EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState() may return EFI_UNSUPPORTED if
"the device does not support the ability to have its state set."
BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1() must not report an error
in this case.
Fixes: e9c21711c17 ("uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
.../BlackBoxTest/SimpleTextInputExBBTestFunction.c | 3 +++
.../BlackBoxTest/SimpleTextInputExBBTestFunction.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c
index 3ae40ee3b3ed..c9eaf408ab02 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c
@@ -1182,6 +1182,9 @@ BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1 (
SimpleTextInputEx,
&State
);
+ if (Status == EFI_UNSUPPORTED) {
+ return EFI_UNSUPPORTED;
+ }
if (EFI_ERROR(Status)) {
StandardLib->RecordAssertion (
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c
index 7dfd5dea6269..eddce4d3640d 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestFunction.c
@@ -1182,6 +1182,9 @@ BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1 (
SimpleTextInputEx,
&State
);
+ if (Status == EFI_UNSUPPORTED) {
+ return EFI_UNSUPPORTED;
+ }
if (EFI_ERROR(Status)) {
StandardLib->RecordAssertion (
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState
2021-09-08 19:14 [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState Heinrich Schuchardt
@ 2021-10-12 8:09 ` G Edhaya Chandran
2021-10-25 7:44 ` G Edhaya Chandran
0 siblings, 1 reply; 3+ messages in thread
From: G Edhaya Chandran @ 2021-10-12 8:09 UTC (permalink / raw)
To: Heinrich Schuchardt, devel
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
On Thu, Sep 9, 2021 at 12:45 AM, Heinrich Schuchardt wrote:
>
> BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1
Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com>
[-- Attachment #2: Type: text/html, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState
2021-10-12 8:09 ` [edk2-devel] " G Edhaya Chandran
@ 2021-10-25 7:44 ` G Edhaya Chandran
0 siblings, 0 replies; 3+ messages in thread
From: G Edhaya Chandran @ 2021-10-25 7:44 UTC (permalink / raw)
To: G Edhaya Chandran, devel
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
Patch is upstreamed through commit: https://github.com/tianocore/edk2-test/commit/7c60a6d4c73a2a4a5e1f352534e103f0f1a418bd
[-- Attachment #2: Type: text/html, Size: 129 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-08 19:14 [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState Heinrich Schuchardt
2021-10-12 8:09 ` [edk2-devel] " G Edhaya Chandran
2021-10-25 7:44 ` G Edhaya Chandran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox