On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:<br />
<blockquote>-#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0<br />+#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0<br />+#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5</blockquote>
Based on discussion at <a href="https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v2/92203690?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,previd%3D1657121904386162709,nextid%3D1657101454237486469&amp;previd=1657121904386162709&amp;nextid=1657101454237486469," target="_blank" rel="noopener">https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v2/92203690?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,previd%3D1657121904386162709,nextid%3D1657101454237486469&amp;previd=1657121904386162709&amp;nextid=1657101454237486469,</a> the suggestion is to rename these macros to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 and EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05 respectively.<br />I will wait for any other feedback on this series, before I send out the updated series reflecting the macro renaming.<br /><br />Regards,<br /><br />Sami Mujawar