From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for IORT Rev E.d spec To: Sami Mujawar ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.51) X-Originating-Platform: Windows Firefox 101 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 06 Jul 2022 08:44:14 -0700 References: <20220706095631.27196-2-sami.mujawar@arm.com> In-Reply-To: <20220706095631.27196-2-sami.mujawar@arm.com> Message-ID: <26686.1657122254781859400@groups.io> Content-Type: multipart/alternative; boundary="yGD4PVOnGFZXGv5EnsHU" --yGD4PVOnGFZXGv5EnsHU Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote: >=20 > -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0 > +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0 > +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5 Based on discussion at https://edk2.groups.io/g/devel/topic/patch_edk2_plat= forms_v2/92203690?p=3D,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,= previd%3D1657121904386162709,nextid%3D1657101454237486469&previd=3D16571219= 04386162709&nextid=3D1657101454237486469, the suggestion is to rename these= macros to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 and EFI_ACPI_IO_REMAPPIN= G_TABLE_REVISION_05 respectively. I will wait for any other feedback on this series, before I send out the up= dated series reflecting the macro renaming. Regards, Sami Mujawar --yGD4PVOnGFZXGv5EnsHU Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:
-#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0
+#define= EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0
+#define EFI_ACPI_IO_REMAPPING_T= ABLE_REV5 0x5
Based on discussion at https://edk2.groups.io/g/devel/topic/patch_edk2_platf= orms_v2/92203690?p=3D,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,p= revid%3D1657121904386162709,nextid%3D1657101454237486469&previd=3D16571= 21904386162709&nextid=3D1657101454237486469, the suggestion is to r= ename these macros to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 and EFI_ACPI_= IO_REMAPPING_TABLE_REVISION_05 respectively.
I will wait for any other= feedback on this series, before I send out the updated series reflecting t= he macro renaming.

Regards,

Sami Mujawar --yGD4PVOnGFZXGv5EnsHU--