Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid

["Nhi Pham" <nhi@os.amperecomputing.com>]

On 1/8/21 21:02, Laszlo Ersek wrote:
> On 01/08/21 14:41, Nhi Pham via groups.io wrote:
>> The EfiGetVariable() is used in the entry of this module. So, the
>> variable services are required to be ready before they are used. This
>> patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency
>> expression to guarantee that this module will be started once the
>> variable protocol is available.
>>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
>> ---
>>   EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>> index fec53c79d335..0a4cd6dae703 100644
>> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>> @@ -38,5 +38,5 @@ [Protocols]
>>     gEfiRealTimeClockArchProtocolGuid
>>   
>>   [Depex]
>> -  TRUE
>> +  gEfiVariableArchProtocolGuid
>>   
>>
> Will you send a patch for "OvmfPkg/OvmfXen.dsc", for the regression that
> you commit 55ee36b0c490 caused?

Yes, I will generate a patch for it.

-Nhi

>
>
> For this patch:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>