From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (NAM04-SN1-obe.outbound.protection.outlook.com [40.107.70.96]) by mx.groups.io with SMTP id smtpd.web09.57.1610114868234054263 for ; Fri, 08 Jan 2021 06:07:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=h2gx+jEK; spf=pass (domain: os.amperecomputing.com, ip: 40.107.70.96, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=keBT0nDpj6UObxmgNqKA7/JjuAS1p5/MUEOKWdO6sUs6ijBwYksCF6xC4ZbmU8HDPe6DWQmnlYjVhduQzcmF48KCVHR61e4ItqGo7pYEwNxXzJX+6O1fCheKLBj0+j7EDjLAGmqc4sy87lADOd0HZSdex7Rv18+/9K3tt3DhebzVo9Mosq5ThrNdeXed+4rnMhmbwQKdhxEl0TdP1eAb1NAHtfRph3ihx2eg3Tj+5B//svyHhmSqzBiokEa4I+TjyaZHDgM5g4SJEKp9435UQk0OgQBfetxrcIKO2XPgommYgGQGzUGoFCGMJ8RldItBKvWRM2V1BsvQVpz30XzFyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B4+UXqRWQheUtNZzy5+cXwqwtd07kwBMz5vjru7YY/s=; b=Dt54w9tnMbGbyEagQZrc6J4qfxbMCSVmWzu5WpKGj0uB4Xb/T2DC7dRGZr8t/Uy6kYAs3Vqnv5LWG4zPNHI+MpbPiS2LDaecbFh58ijhJVdyoEgEtkARMP3n/PbJ8p4+KWfZcrrbOtNoVeVeyCj7y2X0+xj5GKyt9j3DoSpllNzdWYXZDsiAVWsv8DK4lNFMcYCz0xN122T4+k0wQCa9xKXhzkHtpik99jSOWjtExEPc7qVF/ke3eVh40PDzQNCjVuVHBPbihf0cVV5GDR15cc8ZYx/0uetmuQMayNQ86nLpGxknfD8m3BCdP5LtFYlVNRbJr/Rd9xNEwi/PWTg3Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B4+UXqRWQheUtNZzy5+cXwqwtd07kwBMz5vjru7YY/s=; b=h2gx+jEKrQwJDVksuCpt5ZH8Em6pc2cIpyLvAe9MDOhr2mc13efcoTZEVB3haq4/gc5UT8XtXZVL++CkWKr2zp77/UAsFMj1I9okXlVuHhiPNn/5OLUt3QsK5HKJgbiIKSS80marF9DlHUhpvxDd1EDQt3DbUJdU4m0YhMIZBq0= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM6PR01MB5849.prod.exchangelabs.com (2603:10b6:5:205::20) by DM5PR0101MB3067.prod.exchangelabs.com (2603:10b6:4:31::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.24; Fri, 8 Jan 2021 14:07:46 +0000 Received: from DM6PR01MB5849.prod.exchangelabs.com ([fe80::d8f3:caee:a39b:f999]) by DM6PR01MB5849.prod.exchangelabs.com ([fe80::d8f3:caee:a39b:f999%7]) with mapi id 15.20.3742.010; Fri, 8 Jan 2021 14:07:45 +0000 Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid To: Laszlo Ersek , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel References: <20210108134115.8011-1-nhi@os.amperecomputing.com> <485d1426-5bef-3248-f37b-ea29a51f7faf@redhat.com> From: "Nhi Pham" Message-ID: <266ef850-cbcc-4991-00c5-d5b4873cbdb2@os.amperecomputing.com> Date: Fri, 8 Jan 2021 21:07:36 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <485d1426-5bef-3248-f37b-ea29a51f7faf@redhat.com> X-Originating-IP: [1.53.156.154] X-ClientProxiedBy: HK2PR02CA0176.apcprd02.prod.outlook.com (2603:1096:201:21::12) To DM6PR01MB5849.prod.exchangelabs.com (2603:10b6:5:205::20) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.73] (1.53.156.154) by HK2PR02CA0176.apcprd02.prod.outlook.com (2603:1096:201:21::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Fri, 8 Jan 2021 14:07:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54ce2d32-eff7-4351-6f9f-08d8b3dec608 X-MS-TrafficTypeDiagnostic: DM5PR0101MB3067: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:644; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uKWkvSp9OmayntjKhuo+CmXE+zLAPYJOSSvAhUDm12Iy6xrbqrTWYpKvTMbSkmdgumgTR5F7aZrzD6TBXNHtGL4oriaSnj/6lmiygf49JbQyo4VvtSiikLSq3Ju+JRCsw+Qhk6vOKiFe9ny3/4Whxbq6H4mtE46tMZKMqh6fMoNUXNGdHRdsz7gwUDVe/PBhaVgWdQdmgCLbxS/56spsJ9Zz3Ricu1JE9cqVsip7dq0pXAVEDNoQvgsaSZ2qABrv5JyLRys2Jv+DnUrHAfuUWYHsAg11mIos88VwI7Ou9mOfrYnSDBeEerxFuUSl3NINeSPcqlzYi9bZ+BVv7WxJCnVYHQT+UuWDiTqdOcbSnjKb768t7eKs1PbrmFoSBPHTM1dUjREpKGV8SBrC9489F9xzf4GIQXLr6AKOaT9FF00eT9EtDI+JBqdbCbpVwhoI9UbOhSKLlicKpgvPuK49rL8RL0YfDoAWhIu4B7p9uSdoau0AJSD3tGsrWsY34rt9f4/svrAQPKf/1ZVU9JyVnJF+HLc8uQTW0WHkVQhrOilg6I0KCJCP5WFuwx6Vr505 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR01MB5849.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(366004)(39850400004)(396003)(8676002)(66556008)(52116002)(66476007)(16526019)(2906002)(53546011)(186003)(5660300002)(478600001)(6666004)(956004)(31696002)(2616005)(66946007)(4326008)(26005)(86362001)(6486002)(83380400001)(54906003)(316002)(16576012)(8936002)(31686004)(145543001)(145603002)(213903007)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ek9zZncwUUNYb1hwZ3JHUXJ3ZGVwUjVoWFdselZibW9ZbUVjSVU1VFZTYlB5?= =?utf-8?B?MGdIRlljMHJXUlNZM0dJeUpHMitSbGxoZGQvRlFmNHhNY014Sk5OZ2ZxdjVa?= =?utf-8?B?WVJyYjV3K1VvTW8xZDUxcDgvYTVGb0pZZXpaUWVTK2FZWEU4QUFBRDRseDNP?= =?utf-8?B?WUVCUmllTmFjY0kzR3FoY1V0RUpJS3hmZXp0VmUvWlZXWWFxQWtmVCsvUndM?= =?utf-8?B?UEMwWkpHbVljVTEwSkZ4TlNSNHlDM3dtU045amg1OXNXUUp3MnpnMkQ1aXFo?= =?utf-8?B?Y3RqeEQwZEx3UC92U1dTaktKeTk0NWlJb3R0SzIzdFA4QkpJL1k0ZjhmR2d1?= =?utf-8?B?Sk82SkRGenVwSEl5MGZ4SUZiaEVSSzNJcjhrd3hKZFRGVExKN3JnWTE2TDNu?= =?utf-8?B?VkpMNVkrajV0MUtRR3pUNDBtWlFLUzhFQXdsenlWU0oxRjNuZGRDRGZpR05h?= =?utf-8?B?SGZsakdId3R0NnF3S0kxd0doWHhUSVhaV3doOEFITkxhb0g1YXJRcWdQa3o3?= =?utf-8?B?RnZ4UUJqeEFRcUE0dmNDV0FyYmQ3WFM5SEkyN3NiTDdMMGo1NVpJZjVBemhE?= =?utf-8?B?cW50S2xrb09NZUdXUGxGUGtJSXlkc2haREVFR1Y0MUxUUTluWFRCMUpRYWs5?= =?utf-8?B?UzdQV3VqRTlCZGxrcXE0dko2RXc4T29kR1VDZUw5ejltQzZvaXhGT0tyZTIz?= =?utf-8?B?QUNjTFlDemN4WE9pNU9KS0ZSMmlyc0lSWlcxU3MrdUpOamVGcHhRZ3VIRkJW?= =?utf-8?B?bFRJRmsvOGZmRm5GOW40WTF5NmZaaUtZcjcwN1Z1bFp6MHNzWi9kcWp4T3h0?= =?utf-8?B?alpzZGRTV2RZdXlVY3IrOW5lRHF1dGhraUxPbS8xQ2J1SytEalNhUXhFb3d2?= =?utf-8?B?b1psMlptdllVTzJXeWhDV3ZyM1FTZUNPR0FwcVB0bFJUT3VHc090SkFBQTlT?= =?utf-8?B?VXFKWmlpMlVrdFlJUUhNdmQzcktseVpKTU5POGhmc29zc05pSENqS2xwMUdk?= =?utf-8?B?SzRic2FPenJrQVF1SzZUdWtPMzRGYXFtRXlWeDF2VG8zSXBuenBJS1Fnencv?= =?utf-8?B?emIxM3lydkgrVjdmd3crczgrNjdyamIxWVhzR0dyemdGWmFWOTJxZjFyMjJo?= =?utf-8?B?S0RYVWdWQkMwUW1idCtUNUp1eE5VUWZGOGh5UG50dHcxczJPUERlSzQ2bFV4?= =?utf-8?B?MEZNOTcyNndWTkMrZU8raWorSHBKMXlpOXFvQ1BLRm9Sa3NNVktWU0xtZWs5?= =?utf-8?B?bXFTdUIrWE1RbGpTbnBaSEs1YUVmUHVxYWEwYWxWSWhmZ21wdlZOZTRGVjJz?= =?utf-8?Q?94wRnMb1fGXKo=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5849.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2021 14:07:45.8948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-Network-Message-Id: 54ce2d32-eff7-4351-6f9f-08d8b3dec608 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VZa4YijwbcUyCSz+9xyNeBTdvO0oe1xCuiL0Oz+obTTSXD4AocjynTmXLvywCoxjgEJF1KwH3SL9LvxDWE2OziPdKBcdA//zWmcDaf7pEwo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0101MB3067 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 1/8/21 21:02, Laszlo Ersek wrote: > On 01/08/21 14:41, Nhi Pham via groups.io wrote: >> The EfiGetVariable() is used in the entry of this module. So, the >> variable services are required to be ready before they are used. This >> patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency >> expression to guarantee that this module will be started once the >> variable protocol is available. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Signed-off-by: Nhi Pham >> --- >> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> index fec53c79d335..0a4cd6dae703 100644 >> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> @@ -38,5 +38,5 @@ [Protocols] >> gEfiRealTimeClockArchProtocolGuid >> >> [Depex] >> - TRUE >> + gEfiVariableArchProtocolGuid >> >> > Will you send a patch for "OvmfPkg/OvmfXen.dsc", for the regression that > you commit 55ee36b0c490 caused? Yes, I will generate a patch for it. -Nhi > > > For this patch: > > Reviewed-by: Laszlo Ersek >