* [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 @ 2019-06-06 12:28 PierreGondois 2019-06-06 12:51 ` [edk2-devel] " Alexei.Fedorov ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: PierreGondois @ 2019-06-06 12:28 UTC (permalink / raw) To: devel Cc: jaben.carsey, ray.ni, zhichao.gao, sami.mujawar, Matteo.Carlini, Stephanie.Hughes-Fitt, pierre.gondois, nd From: Pierre Gondois <pierre.gondois@arm.com> The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2 virtual timer fields. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_update_v1 Notes: v1: - GTDT updates for ACPI 6.3 [Pierre] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c index 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab057c32369a456267 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c @@ -5,7 +5,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent @par Reference(s): - - ACPI 6.2 Specification - Errata A, September 2017 + - ACPI 6.3 Specification - January 2019 **/ #include <IndustryStandard/Acpi.h> @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = { {L"Platform Timer Count", 4, 88, L"%d", NULL, (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, + {L"Virtual EL2 Timer GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Virtual EL2 Timer Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} }; /** -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 2019-06-06 12:28 [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 PierreGondois @ 2019-06-06 12:51 ` Alexei.Fedorov 2019-06-06 14:33 ` Sami Mujawar 2019-06-10 3:09 ` Gao, Zhichao 2 siblings, 0 replies; 5+ messages in thread From: Alexei.Fedorov @ 2019-06-06 12:51 UTC (permalink / raw) To: PierreGondois, devel [-- Attachment #1: Type: text/plain, Size: 54 bytes --] Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com> [-- Attachment #2: Type: text/html, Size: 60 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 2019-06-06 12:28 [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 PierreGondois 2019-06-06 12:51 ` [edk2-devel] " Alexei.Fedorov @ 2019-06-06 14:33 ` Sami Mujawar 2019-06-10 3:09 ` Gao, Zhichao 2 siblings, 0 replies; 5+ messages in thread From: Sami Mujawar @ 2019-06-06 14:33 UTC (permalink / raw) To: devel@edk2.groups.io Cc: jaben.carsey@intel.com, ray.ni@intel.com, zhichao.gao@intel.com, Pierre Gondois, nd Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> -----Original Message----- From: PierreGondois <pierre.gondois@arm.com> Sent: 06 June 2019 01:29 PM To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>; nd <nd@arm.com> Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 From: Pierre Gondois <pierre.gondois@arm.com> The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2 virtual timer fields. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_update_v1 Notes: v1: - GTDT updates for ACPI 6.3 [Pierre] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c index 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab057c32369a456267 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars +++ er.c @@ -5,7 +5,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent @par Reference(s): - - ACPI 6.2 Specification - Errata A, September 2017 + - ACPI 6.3 Specification - January 2019 **/ #include <IndustryStandard/Acpi.h> @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = { {L"Platform Timer Count", 4, 88, L"%d", NULL, (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Timer + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} }; /** -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 2019-06-06 12:28 [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 PierreGondois 2019-06-06 12:51 ` [edk2-devel] " Alexei.Fedorov 2019-06-06 14:33 ` Sami Mujawar @ 2019-06-10 3:09 ` Gao, Zhichao 2019-06-10 19:00 ` Carsey, Jaben 2 siblings, 1 reply; 5+ messages in thread From: Gao, Zhichao @ 2019-06-10 3:09 UTC (permalink / raw) To: PierreGondois, devel@edk2.groups.io Cc: Carsey, Jaben, Ni, Ray, sami.mujawar@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> I would collect the R-B and send to the maintainer to push. Thanks, Zhichao > -----Original Message----- > From: PierreGondois [mailto:pierre.gondois@arm.com] > Sent: Thursday, June 6, 2019 8:29 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; > Gao, Zhichao <zhichao.gao@intel.com>; sami.mujawar@arm.com; > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; > pierre.gondois@arm.com; nd@arm.com > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 > > From: Pierre Gondois <pierre.gondois@arm.com> > > The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual > EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2 > virtual timer fields. > > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> > --- > > The changes can be seen at: > https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd > ate_v1 > > Notes: > v1: > - GTDT updates for ACPI 6.3 [Pierre] > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > index > 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05 > 7c32369a456267 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > +++ er.c > @@ -5,7 +5,7 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent > > @par Reference(s): > - - ACPI 6.2 Specification - Errata A, September 2017 > + - ACPI 6.3 Specification - January 2019 > **/ > > #include <IndustryStandard/Acpi.h> > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = { > {L"Platform Timer Count", 4, 88, L"%d", NULL, > (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, > {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, > - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} > + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Timer > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} > }; > > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 2019-06-10 3:09 ` Gao, Zhichao @ 2019-06-10 19:00 ` Carsey, Jaben 0 siblings, 0 replies; 5+ messages in thread From: Carsey, Jaben @ 2019-06-10 19:00 UTC (permalink / raw) To: Gao, Zhichao, PierreGondois, devel@edk2.groups.io Cc: Ni, Ray, sami.mujawar@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Pushed as sufficient RB's were received. > -----Original Message----- > From: Gao, Zhichao > Sent: Sunday, June 09, 2019 8:09 PM > To: PierreGondois <pierre.gondois@arm.com>; devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; > sami.mujawar@arm.com; Matteo.Carlini@arm.com; Stephanie.Hughes- > Fitt@arm.com; nd@arm.com > Subject: RE: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 > Importance: High > > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > I would collect the R-B and send to the maintainer to push. > > Thanks, > Zhichao > > > -----Original Message----- > > From: PierreGondois [mailto:pierre.gondois@arm.com] > > Sent: Thursday, June 6, 2019 8:29 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; > > Gao, Zhichao <zhichao.gao@intel.com>; sami.mujawar@arm.com; > > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; > > pierre.gondois@arm.com; nd@arm.com > > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 > > > > From: Pierre Gondois <pierre.gondois@arm.com> > > > > The ACPI 6.3 specification introduces support to describe the ARMv8.1 > virtual > > EL2 timers. This patch updates the GTDT parser of acpiview to decode the > EL2 > > virtual timer fields. > > > > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> > > --- > > > > The changes can be seen at: > > > https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd > > ate_v1 > > > > Notes: > > v1: > > - GTDT updates for ACPI 6.3 [Pierre] > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > > | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > > .c > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > > .c > > index > > > 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05 > > 7c32369a456267 100644 > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > > .c > > +++ > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > > +++ er.c > > @@ -5,7 +5,7 @@ > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @par Reference(s): > > - - ACPI 6.2 Specification - Errata A, September 2017 > > + - ACPI 6.3 Specification - January 2019 > > **/ > > > > #include <IndustryStandard/Acpi.h> > > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = { > > {L"Platform Timer Count", 4, 88, L"%d", NULL, > > (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, > > {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, > > - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} > > + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Timer > > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer > > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} > > }; > > > > /** > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-10 19:00 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-06 12:28 [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 PierreGondois 2019-06-06 12:51 ` [edk2-devel] " Alexei.Fedorov 2019-06-06 14:33 ` Sami Mujawar 2019-06-10 3:09 ` Gao, Zhichao 2019-06-10 19:00 ` Carsey, Jaben
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox