From: "Marvin Häuser" <mhaeuser@posteo.de>
To: devel@edk2.groups.io, rebecca@nuviainc.com,
Michael Kubacki <Michael.Kubacki@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?
Date: Mon, 16 Aug 2021 19:39:50 +0000 [thread overview]
Message-ID: <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de> (raw)
In-Reply-To: <07a6ecff-f7bf-083a-f24d-246ca6c7988b@nuviainc.com>
Hey Rebecca,
I think even Uncrustify has issues with the EDK II indentation style.
You might want to check the UEFI Talkbox Discord server, I had a brief
chat with Michael about it there. I don't think realistically any tool
supports EDK II's indentation style however, so I'd propose it is
changed. This could be for new submissions only, or actually the entire
codebase could be reformatted at once with a good tool setup. While this
screws with git blame, the (to my understanding) decided on CRLF -> LF
change does that anyway, so at least two evils could be dealt with in
one go really.
Best regards,
Marvin
On 16/08/2021 21:34, Rebecca Cran wrote:
>
> cc devel@ .
>
> On 8/16/21 1:33 PM, Rebecca Cran wrote:
>>
>> I noticed a message on Twitter about an idea of using Uncrustify for
>> EDK2 instead of the ECC tool, and came across
>> https://www.mail-archive.com/search?l=devel@edk2.groups.io&q=subject:%22Re%5C%3A+%5C%5Bedk2%5C-devel%5C%5D+TianoCore+Community+Meeting+Minutes+%5C-+2%5C%2F4%22&o=newest&f=1
>> .
>>
>> I was wondering if there's been any progress on it that I could check
>> out?
>>
>>
>> Michael Kubacki: in that message, you said:
>>
>> "I'm planning to put up a branch that we can use as a reference for a
>> conversation around uncrustify in the next couple of weeks."
>>
>>
>> Did you end up creating that branch, and if so could you provide a
>> link to it please?
>>
>>
>> --
>> Rebecca Cran
>>
>
next prev parent reply other threads:[~2021-08-16 19:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e15cf895-03a4-96cd-2754-d1cfeead6b98@nuviainc.com>
2021-08-16 19:34 ` Progress on getting Uncrustify working for EDK2? Rebecca Cran
2021-08-16 19:39 ` Marvin Häuser [this message]
2021-08-16 20:00 ` [edk2-devel] " Michael Kubacki
2021-10-07 10:48 ` Leif Lindholm
2021-10-07 15:30 ` Andrew Fish
[not found] ` <16ABC94F0E9D1AC5.21629@groups.io>
2021-10-07 16:03 ` Andrew Fish
2021-10-07 16:34 ` Michael D Kinney
2021-10-07 17:01 ` Michael Kubacki
2021-10-07 17:05 ` Michael D Kinney
2021-10-07 18:30 ` Marvin Häuser
2021-10-07 17:19 ` Michael D Kinney
2021-10-07 17:36 ` Andrew Fish
2021-10-07 17:43 ` Marvin Häuser
2021-10-07 21:09 ` Andrew Fish
2021-11-09 0:23 ` Michael D Kinney
2021-11-09 1:09 ` Andrew Fish
2021-11-09 1:13 ` Michael D Kinney
2021-11-09 2:46 ` Andrew Fish
2021-11-09 3:02 ` Michael D Kinney
2021-11-09 7:32 ` Marvin Häuser
2021-11-09 15:43 ` Michael D Kinney
2021-11-09 16:12 ` Marvin Häuser
2021-11-09 16:33 ` Michael D Kinney
2021-11-09 20:55 ` Leif Lindholm
2021-11-09 21:20 ` Michael D Kinney
2021-11-09 23:23 ` Leif Lindholm
2021-11-10 10:12 ` Gerd Hoffmann
2021-11-09 1:12 ` 回复: " gaoliming
2021-11-09 15:22 ` Michael D Kinney
2021-11-09 8:40 ` Gerd Hoffmann
2021-11-09 11:56 ` Michael Brown
2021-11-09 12:36 ` Leif Lindholm
2021-11-09 14:10 ` Gerd Hoffmann
2021-11-09 15:44 ` Michael D Kinney
2021-11-10 15:38 ` Michael Kubacki
2021-11-09 15:08 ` Michael D Kinney
2021-11-09 18:13 ` Andrew Fish
2021-11-09 18:26 ` Michael D Kinney
2021-11-09 18:52 ` Andrew Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox