From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web09.29313.1629142793572492661 for ; Mon, 16 Aug 2021 12:39:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.de header.s=2017 header.b=NfCqAU21; spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id B018E240026 for ; Mon, 16 Aug 2021 21:39:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1629142791; bh=t2OHo9wkOJIejH0rNwUugBWp0Ev/VgD2K2x+pG153Aw=; h=Subject:To:From:Date:From; b=NfCqAU21Ikx95EvDe9CZajwdkLeWfTp7b0koFc1yxOjvWruCg6QPQ+4d2FvzrAUBL OjVU8mP0qKYseFQBTiitzY2TkPl4HtKHLeKt5ynYS4TFllI+fHo2dGTFuwAwUJDzmm ldTBKyUw9qlCpNMss/qtxJGgBj6/EoPMO0zyuCahDQesB8EqKCGP+eLeFbcTkzJbJV 2+k3UA8HcV+2MGRrST3aF9MmPChjaBa7dfjQ7oFYM4ieRHY4bryctOAd5/5IT3pH0l ivXz3AUE1OHxL0ZXYM69PyqIViQ0jF0SP07ZbuRzH/u+xpN6wkFvMnJg0K4+vufkWl z45jDZTMZ6ntA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GpPd24XLWz6tnt; Mon, 16 Aug 2021 21:39:50 +0200 (CEST) Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? To: devel@edk2.groups.io, rebecca@nuviainc.com, Michael Kubacki , Bret Barkelew , Michael D Kinney References: <07a6ecff-f7bf-083a-f24d-246ca6c7988b@nuviainc.com> From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Message-ID: <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de> Date: Mon, 16 Aug 2021 19:39:50 +0000 MIME-Version: 1.0 In-Reply-To: <07a6ecff-f7bf-083a-f24d-246ca6c7988b@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hey Rebecca, I think even Uncrustify has issues with the EDK II indentation style. You might want to check the UEFI Talkbox Discord server, I had a brief chat with Michael about it there. I don't think realistically any tool supports EDK II's indentation style however, so I'd propose it is changed. This could be for new submissions only, or actually the entire codebase could be reformatted at once with a good tool setup. While this screws with git blame, the (to my understanding) decided on CRLF -> LF change does that anyway, so at least two evils could be dealt with in one go really. Best regards, Marvin On 16/08/2021 21:34, Rebecca Cran wrote: > > cc devel@ . > > On 8/16/21 1:33 PM, Rebecca Cran wrote: >> >> I noticed a message on Twitter about an idea of using Uncrustify for >> EDK2 instead of the ECC tool, and came across >> https://www.mail-archive.com/search?l=devel@edk2.groups.io&q=subject:%22Re%5C%3A+%5C%5Bedk2%5C-devel%5C%5D+TianoCore+Community+Meeting+Minutes+%5C-+2%5C%2F4%22&o=newest&f=1 >> . >> >> I was wondering if there's been any progress on it that I could check >> out? >> >> >> Michael Kubacki: in that message, you said: >> >> "I'm planning to put up a branch that we can use as a reference for a >> conversation around uncrustify in the next couple of weeks." >> >> >> Did you end up creating that branch, and if so could you provide a >> link to it please? >> >> >> -- >> Rebecca Cran >> >