From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: Sunil V L <sunilvl@ventanamicro.com>
Cc: <devel@edk2.groups.io>, Abner Chang <abner.chang@hpe.com>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH v1 3/5] U540, U500: Add initrd command to boot Linux
Date: Mon, 4 Oct 2021 19:07:44 +0800 [thread overview]
Message-ID: <267ceb27-1c8a-c7ac-73ba-e80f9981be84@hpe.com> (raw)
In-Reply-To: <20211004104526.GC83401@sunil-ThinkPad-T490>
On 10/4/21 18:45, Sunil V L wrote:
> On Mon, Oct 04, 2021 at 01:23:57AM +0800, Daniel Schaefer wrote:
>> Cc: Abner Chang <abner.chang@hpe.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>>
>> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
>> ---
>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 +++++++
>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 1 +
>> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 7 +++++++
>> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf | 1 +
>> 4 files changed, 16 insertions(+)
>>
>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> index cdc1b9ee8f..23f50ab2c4 100644
>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> @@ -513,6 +513,13 @@
>> FatPkg/EnhancedFatDxe/Fat.inf
>> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>>
>> + OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
>> + <PcdsFixedAtBuild>
>> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>> + <LibraryClasses>
>> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> Do we need to add UefiShellLib.inf here? Same question for other changes
> too.
You're right. We don't, if we add it to the regular libraries.
Neither do we need it for
ShellPkg/Application/Shell/Shell.inf
I'll remove it.
>> + }
>> +
>> ShellPkg/Application/Shell/Shell.inf {
>> <LibraryClasses>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
>> index f262e4fe17..5f3ac8e0b7 100644
>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
>> @@ -187,6 +187,7 @@ INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
>>
>> INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
>>
>> +INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf
>> INF ShellPkg/Application/Shell/Shell.inf
>>
>> #
>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> index be70ef5294..850d60afa2 100644
>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> @@ -512,6 +512,13 @@
>> FatPkg/EnhancedFatDxe/Fat.inf
>> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>>
>> + OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
>> + <PcdsFixedAtBuild>
>> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>> + <LibraryClasses>
>> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> + }
>> +
>> ShellPkg/Application/Shell/Shell.inf {
>> <LibraryClasses>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
>> index c0ce09fcee..a1a4b342e3 100644
>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
>> @@ -187,6 +187,7 @@ INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
>>
>> INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
>>
>> +INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf
>> INF ShellPkg/Application/Shell/Shell.inf
>>
>> #
>> --
>> 2.33.0
>>
next prev parent reply other threads:[~2021-10-04 11:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 17:23 [PATCH v1 0/5] Improvements for booting to Linux on RISC-V Daniel Schaefer
2021-10-03 17:23 ` [PATCH v1 1/5] U540, U500: Add filesystem drivers Daniel Schaefer
2021-10-04 10:19 ` Sunil V L
2021-10-03 17:23 ` [PATCH v1 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure Daniel Schaefer
2021-10-04 10:39 ` Sunil V L
2021-10-03 17:23 ` [PATCH v1 3/5] U540, U500: Add initrd command to boot Linux Daniel Schaefer
2021-10-04 10:45 ` Sunil V L
2021-10-04 11:07 ` Daniel Schaefer [this message]
2021-10-03 17:23 ` [PATCH v1 4/5] U540: BuildCpuHob with 48 to indicate size memory space Daniel Schaefer
2021-10-04 11:02 ` Sunil V L
2021-10-04 11:26 ` Abner Chang
2021-10-03 17:23 ` [PATCH v1 5/5] Signal EndOfDxe in boot manager Daniel Schaefer
2021-10-04 11:07 ` Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267ceb27-1c8a-c7ac-73ba-e80f9981be84@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox