Re: [edk2-devel] May I become a contributor in EmulatorPkg ?

Re: [edk2-devel] May I become a contributor in EmulatorPkg ?

[Hiber He]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Hi，


    For the second one:  Dai already pointed out the problem, a ending slash(\) should be added to the nasm path variable. You can find the following 


On 06/30/2019 21:22, Ni, Ray wrote:

Bob,

Any comments?

 

 

From:戴，曉政 [mailto:cloud0907@yahoo.com.tw]
Sent: Sunday, June 30, 2019 3:37 PM
To: Justen, Jordan L <jordan.l.justen@intel.com>; afish@apple.com; Ni, Ray <ray.ni@intel.com>
Subject: May I become a contributor in EmulatorPkg ?

 

Dears,

 

I live in Taiwan so please forgive my English pool. I download edk2 source code from Github recently and I encounter two build error when I build EmulatorPkg (I use Visual Studio 2017 ). First is in GenPcdDb.py, this error means parameter used to unpack is zero, please refer below :

 

 

Second is in tools_def.txt, this error means there is missing slash before nasm.exe, please refer below :

 

 

You can search “clouddai-test” in Attachment so that you will easy understand what I say. If I need submit more official document for become a contributor please let me know, or if my modification need obey some rule please also let me know, I am waiting your response


[-- Attachment #2: Type: text/html, Size: 4427 bytes --]

Re: [edk2-devel] May I become a contributor in EmulatorPkg ?

[Hiber He]

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

Hi，


    (Sorry for the previous incomplete email!)
    For the second one:  Dai already pointed out the problem, a ending slash(\) should be added to the nasm path variable. You can find the how nasm path is processed in edksetup.bat:


:check_NASM
if not defined NASM_PREFIX (
    @echo.
    @echo !!! WARNING !!! NASM_PREFIX environment variable is not set
    @if exist "C:\nasm\nasm.exe" @set "NASM_PREFIX=C:\nasm\"
    @if exist "C:\nasm\nasm.exe" @echo Found nasm.exe, setting the environment variable to C:\nasm\
    @if not exist "C:\nasm\nasm.exe" echo Attempting to build modules that require NASM will fail.
)


    And iasl path variable(IASL_PREFIX) is handled similarly. Maybe they should be adopted to handle with and without ending slash(\).


Best Regards,
Hiber
On 06/30/2019 21:22, Ni, Ray wrote:

Bob,

Any comments?

 

 

From:戴，曉政 [mailto:cloud0907@yahoo.com.tw]
Sent: Sunday, June 30, 2019 3:37 PM
To: Justen, Jordan L <jordan.l.justen@intel.com>; afish@apple.com; Ni, Ray <ray.ni@intel.com>
Subject: May I become a contributor in EmulatorPkg ?

 

Dears,

 

I live in Taiwan so please forgive my English pool. I download edk2 source code from Github recently and I encounter two build error when I build EmulatorPkg (I use Visual Studio 2017 ). First is in GenPcdDb.py, this error means parameter used to unpack is zero, please refer below :

 

 

Second is in tools_def.txt, this error means there is missing slash before nasm.exe, please refer below :

 

 

You can search “clouddai-test” in Attachment so that you will easy understand what I say. If I need submit more official document for become a contributor please let me know, or if my modification need obey some rule please also let me know, I am waiting your response


[-- Attachment #2: Type: text/html, Size: 5425 bytes --]