From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE12221197B2F for ; Mon, 17 Dec 2018 02:27:28 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38903C04B2D9; Mon, 17 Dec 2018 10:27:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-46.rdu2.redhat.com [10.10.120.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id DFFF01001F58; Mon, 17 Dec 2018 10:27:23 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: Shenglei Zhang , edk2-devel@lists.01.org, Michael D Kinney , Jiewen Yao , Liming Gao , Chao Zhang References: <20181211013132.25028-1-shenglei.zhang@intel.com> <14bbe8e4-3361-1150-ba3e-ee2ecd2ff53b@redhat.com> From: Laszlo Ersek Message-ID: <2687dc25-fa04-6cf6-0393-07520b4e53ed@redhat.com> Date: Mon, 17 Dec 2018 11:27:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <14bbe8e4-3361-1150-ba3e-ee2ecd2ff53b@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 17 Dec 2018 10:27:28 +0000 (UTC) Subject: Re: [PATCH 0/2] Fix typos in MdePkg and SecurityPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 10:27:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12/17/18 11:08, Philippe Mathieu-Daudé wrote: > Hi, > > On 12/11/18 2:31 AM, Shenglei Zhang wrote: >> Change EFI_RETURNING_FROM_EFI_APPLICATOIN to >> EFI_RETURNING_FROM_EFI_APPLICATION. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Chao Zhang >> Cc: Jiewen Yao >> Shenglei Zhang (2): >> MdePkg/IndustryStandard: Fix a typo in UefiTcgPlatform.h >> SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c >> >> MdePkg/Include/IndustryStandard/UefiTcgPlatform.h | 2 +- >> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- >> SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 4 ++-- >> 3 files changed, 5 insertions(+), 5 deletions(-) >> > > NACK, this change has to be in the same patch to be bisectable. > > However, if you resend the same change squashed in a single patch, you > can directly add my: > Reviewed-by: Philippe Mathieu-Daudé Good catch! Bisectability is important! An alternative approach to yours could be: first, introduce the correctly spelled macro (with the same value); second, update the references; third, remove the misspelled macro. This would be *slightly* more idiomatic for edk2, where we tend to avoid cross-package patches, if we can. Personally I'd be fine with either approach in this case. Thanks! Laszlo