From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A7ECF21E1DB5D for ; Wed, 9 Aug 2017 17:00:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3FBF6E813; Thu, 10 Aug 2017 00:02:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B3FBF6E813 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-102.phx2.redhat.com [10.3.116.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 428C460F82; Thu, 10 Aug 2017 00:02:50 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1502107139-412-1-git-send-email-brijesh.singh@amd.com> <1502107139-412-8-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <26a6be37-9983-7a34-afbf-d25e5501b138@redhat.com> Date: Thu, 10 Aug 2017 02:02:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502107139-412-8-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 10 Aug 2017 00:02:52 +0000 (UTC) Subject: Re: [PATCH v1 07/14] OvmfPkg/VirtioLib: Use AllocateShared() to allocate vring buffer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 00:00:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/07/17 13:58, Brijesh Singh wrote: > The vring buffer is communication block between guest and hypervisor, > allocate the vring buffer using AllocateSharedPages() so that it can be > Map() with BusMasterCommonBufer for bi-directional access. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Library/VirtioLib/VirtioLib.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/Library/VirtioLib/VirtioLib.c b/OvmfPkg/Library/VirtioLib/VirtioLib.c > index 09a3f9b7f2e5..9ba64204326f 100644 > --- a/OvmfPkg/Library/VirtioLib/VirtioLib.c > +++ b/OvmfPkg/Library/VirtioLib/VirtioLib.c > @@ -61,6 +61,7 @@ VirtioRingInit ( > OUT VRING *Ring > ) > { > + EFI_STATUS Status; > UINTN RingSize; > volatile UINT8 *RingPagesPtr; > > @@ -79,9 +80,12 @@ VirtioRingInit ( > sizeof *Ring->Used.AvailEvent, > EFI_PAGE_SIZE); > > + // > + // Allocate a shared ring buffer > + // > Ring->NumPages = EFI_SIZE_TO_PAGES (RingSize); > - Ring->Base = AllocatePages (Ring->NumPages); > - if (Ring->Base == NULL) { > + Status = VirtioAllocateSharedPages (VirtIo, Ring->NumPages, &Ring->Base); > + if (EFI_ERROR (Status)) { > return EFI_OUT_OF_RESOURCES; > } > SetMem (Ring->Base, RingSize, 0x00); > @@ -143,7 +147,7 @@ VirtioRingUninit ( > IN OUT VRING *Ring > ) > { > - FreePages (Ring->Base, Ring->NumPages); > + VirtioFreeSharedPages (VirtIo, Ring->NumPages, Ring->Base); > SetMem (Ring, sizeof *Ring, 0x00); > } > > The logic looks good, I have some superficial comments: (1) Please update the subject, the commit message, and the code to refer to VirtIo->AllocateSharedPages() (or even VIRTIO_ALLOCATE_SHARED, as you see fit -- just not the helper function, because we won't have that). (2) Please update the documentation of "@retval EFI_OUT_OF_RESOURCES" -- replace it with @return Status codes propagated from VirtIo->AllocateSharedPages(). (3) Accordingly, please forward the Status received, on the error branch. (4) Please remove MemoryAllocationLib from the #includes and also from [LibraryClasses]. Thanks, Laszlo