From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 71E0A941C3F for ; Mon, 19 Feb 2024 20:08:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0zjNPYqoiW+ZX5bz4rr/rCTzoS6NmI3cbfHBymniMO0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708373300; v=1; b=Zw2Tu/PnjDtQVyXt98zEFLYcfF/oUtJBzkfqO93Z++ZFHyCH9q+LsRei3i74KRl47q58PTrT GYGOLutvR5k/Y08WdNld0IyH4jcQCUdM4bEPRgAZ5N1dQyw7AU91LGXXJWEj1vT32zl33BdR41R veoW62ptHAeFXwbr6L9wXyzg= X-Received: by 127.0.0.2 with SMTP id YZaeYY7687511xUn9VWDmuuj; Mon, 19 Feb 2024 12:08:20 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4073.1708373299966383704 for ; Mon, 19 Feb 2024 12:08:20 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-pBdRiG0EPy2cw93LCKIksg-1; Mon, 19 Feb 2024 15:08:15 -0500 X-MC-Unique: pBdRiG0EPy2cw93LCKIksg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3E24885CDE4; Mon, 19 Feb 2024 20:08:15 +0000 (UTC) X-Received: from [10.39.194.20] (unknown [10.39.194.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9324F2166AEE; Mon, 19 Feb 2024 20:08:14 +0000 (UTC) Message-ID: <26afe746-3c5b-1d8d-2192-d726cd9fdede@redhat.com> Date: Mon, 19 Feb 2024 21:08:13 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype To: Chao Li , devel@edk2.groups.io Cc: Bibo Mao , Xianglai li References: <36593e23-d3e8-b71a-808d-ef94260b5fd0@redhat.com> <20240207010919.105860-1-lersek@redhat.com> <20240207010919.105860-6-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aNxs4GLj536zZK3JKbiHqJfZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Zw2Tu/Pn"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/19/24 03:21, Chao Li wrote: > Hi Laszlo, >=20 > I have tested: >=20 > 1. Follow edk2 series patch 3 changes to > BaseTools/Source/Python/AutoGen/GenC.py. >=20 > 2. Follow edk2-platforms series patch 5 changes to > edk2-platforms/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c. >=20 > After the changes, I have built and tested, and it works fine. >=20 >=20 > BTW, you can get the LoongArch cross-toolchain in two ways: >=20 > 1. Download it from LoongArch cross-toolchain website, URL: > https://github.com/loongson/build-tools, the last release date is Aug 8, > 2023. >=20 > 2. Use the Fedora39 docker or virt-machin(X64), and install the > LoongArch cross-toolchain from rpm source. >=20 >=20 > Build-tested-by: Chao Li >=20 > Reviewed-by: Chao Li Thanks -- in fact I've remembered since that, at an earlier time, I've already used a LoongArch toolchain in a Fedora VM, with a virtio filesystem= . Laszlo >=20 >=20 > Thanks, > Chao > On 2024/2/7 09:09, Laszlo Ersek wrote: >> The current declaration of, and call to, SEC >> ProcessLibraryConstructorList() in LoongArchQemuPkg matches the PEIM ent= ry >> point parameter list. Fix the call, and rely on AutoGen for the >> declaration. >> >> Untested (have no cross-toolchain installed for LOONGARCH64). >> >> Cc: Bibo Mao >> Cc: Chao Li >> Cc: Xianglai li >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 >> Signed-off-by: Laszlo Ersek >> --- >> Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform= /Loongson/LoongArchQemuPkg/Sec/SecMain.c >> index 3f1998c48c12..50d898859a99 100644 >> --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c >> +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c >> @@ -9,7 +9,6 @@ >> =20 >> #include >> =20 >> -#include >> #include >> #include >> #include >> @@ -378,7 +377,7 @@ SecCoreStartupWithStack ( >> =20 >> DEBUG ((DEBUG_INFO, "Entering C environment\n")); >> =20 >> - ProcessLibraryConstructorList (NULL, NULL); >> + ProcessLibraryConstructorList (); >> =20 >> DEBUG ((DEBUG_INFO, >> "SecCoreStartupWithStack (0x%lx, 0x%lx)\n", >> >> >> >>=20 >> >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115598): https://edk2.groups.io/g/devel/message/115598 Mute This Topic: https://groups.io/mt/104210907/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-