From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.4145.1622104711258621273 for ; Thu, 27 May 2021 01:38:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pwd0DkfQ; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zqQjHLk9jObmwbFDRrBprkYg6/oEYaF4A0jFZqwF4PM=; b=Pwd0DkfQVoYFm2PtQP9BVYD9ZEIo1abqqM0Lb1mCClYZXkIxyHsyJikCkaS43Y1fo/+/Uq s3Qs2yPC0gmWnmoxoIlloSaQ/R9ivrobsmZoTaEEV5MUB2cRRCXUj6jkDFZZgTZqGGMB/x 6gpdL75SyYS5Ye/u71ytCVpkD5wUfOE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-niiKqhQxO6yE-dOVpOhS5Q-1; Thu, 27 May 2021 04:38:28 -0400 X-MC-Unique: niiKqhQxO6yE-dOVpOhS5Q-1 Received: by mail-wr1-f72.google.com with SMTP id i15-20020a5d558f0000b029011215b1cf5cso1441758wrv.22 for ; Thu, 27 May 2021 01:38:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zqQjHLk9jObmwbFDRrBprkYg6/oEYaF4A0jFZqwF4PM=; b=tgzMnB/wP3dQZVkeVwuagoYh0Z2WruQjqH8n7NlzLw3FNUKTnC8HbayNQ7gtAx2IZ8 oFWesELEkKvAZNlcqvewuZ2eMGTMYX2klw9FAeActqFwnk163kUxUC2kXqqExDek2Rlr TIVA/K3TlEmWI86aIr9Ygez2yU5rwWIKlffVA+YR69wZiWxVqiquP1H7F3j1+9xtpn8K /Z9zxWP3bjgWGT/0OSA8dNfwOsHgrsew6arsKVUWkzyA4bmvBz46Gq3DpCt82sXtBacJ Ad3hBT18nTDoYNyb7vA2D0OP0O2XeD7U4avMoJpBQRrhMTuKRqmiBxh8YYOwTkpKDFPv bQNg== X-Gm-Message-State: AOAM530YwZfo17VWyQ3V/VpTf+X9vrzK1VzW4ZbxUFyIohT0SGKPlVCE 7Agf4mfJyAcF2uvrM3ZKTY6SPMXvLFNuNrMtyESJm0AW9T8GCPpJFjnL3G8koLRhEzZ5EaY+c0U b5Tze8MUA7EHCNw== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr2123881wry.243.1622104707493; Thu, 27 May 2021 01:38:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNlrW5MiResFW60N+3PMWXcTmgUqG5sImaCbWQDh8ftreSbvwkR0lilbeGFdOqNoAD52xNNA== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr2123871wry.243.1622104707367; Thu, 27 May 2021 01:38:27 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id t204sm10173946wmg.38.2021.05.27.01.38.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:38:26 -0700 (PDT) Subject: Re: [PATCH 13/43] OvmfPkg/XenAcpiPlatformDxe: remove the QEMU ACPI linker/loader client To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-14-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <26b87dad-e116-a77e-6607-508d74911fcd@redhat.com> Date: Thu, 27 May 2021 10:38:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-14-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The root of the QEMU ACPI linker/loader client in XenAcpiPlatformDxe is > the InstallQemuFwCfgTables() function. This function always fails on Xen, > due to its top-most QemuFwCfgFindFile() call. > > Remove the InstallQemuFwCfgTables() function call from XenAcpiPlatformDxe, > along with all dependencies that now become unused. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 6 - > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.h | 51 - > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.c | 2 +- > OvmfPkg/XenAcpiPlatformDxe/BootScript.c | 269 ----- > OvmfPkg/XenAcpiPlatformDxe/PciDecoding.c | 194 ---- > OvmfPkg/XenAcpiPlatformDxe/QemuFwCfgAcpi.c | 1196 -------------------- > 6 files changed, 1 insertion(+), 1717 deletions(-) Reviewed-by: Philippe Mathieu-Daude