From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.43.1605311632274703427 for ; Fri, 13 Nov 2020 15:53:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fQo6Tdsi; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605311631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=STKoTZsotQYIvb+HGN34xkPRpZadrxnegp2oX0BrGgU=; b=fQo6TdsidG/Vu4sJhYtb6rREY2yqOWM3Mp70CiaqG2ziVD0qYDqPqBszmcLTJd48EqYxOF k8VxaGIESG9YiPW5IZiGOzXkiGwG1Z6l9b3nLUCk0se/osVeZo9dJsV3Dh/ju59UucGwhU Y1T54CDzRtM9F03l/QjayEJa9Dg4iT0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-W9rtcc-EO-eU90D_MBZ2xA-1; Fri, 13 Nov 2020 18:53:47 -0500 X-MC-Unique: W9rtcc-EO-eU90D_MBZ2xA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BC94107AD74; Fri, 13 Nov 2020 23:53:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-113.ams2.redhat.com [10.36.112.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25757171D6; Fri, 13 Nov 2020 23:53:44 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V4 06/13] ArmVirtPkg/ArmVirtQemuKernel.dsc: Enable MD5 while enable iSCSI To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Ard Biesheuvel , Leif Lindholm References: <20201112055558.2348-1-zhichao.gao@intel.com> <20201112055558.2348-7-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: <26be1ed2-42c8-ca00-6eac-4c0845dab8c1@redhat.com> Date: Sat, 14 Nov 2020 00:53:44 +0100 MIME-Version: 1.0 In-Reply-To: <20201112055558.2348-7-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/12/20 06:55, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 > > There is a plan to make MD5 disable as default. > The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES > would be introduced to enable MD5. Make the > definition ahead of the change to avoid build > error after the MACRO changed. > > Enable iSCSI. > > Signed-off-by: Zhichao Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > --- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 9449a01d6e..f447c62f68 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -1,7 +1,7 @@ > # > # Copyright (c) 2011-2015, ARM Limited. All rights reserved. > # Copyright (c) 2014, Linaro Limited. All rights reserved. > -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. > +# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -38,6 +38,7 @@ > DEFINE NETWORK_SNP_ENABLE = FALSE > DEFINE NETWORK_TLS_ENABLE = FALSE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > + DEFINE NETWORK_ISCSI_ENABLE = TRUE > > !if $(NETWORK_SNP_ENABLE) == TRUE > !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" > @@ -84,6 +85,8 @@ > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > [BuildOptions] > +!include NetworkPkg/NetworkBuildOptions.dsc.inc > + > # > # We need to avoid jump tables in SEC modules, so that the PE/COFF > # self-relocation code itself is guaranteed to be position independent. > Reviewed-by: Laszlo Ersek