From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web09.14915.1637689755205650687
 for <devel@edk2.groups.io>;
 Tue, 23 Nov 2021 09:49:15 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Xdi8g1s/;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174])
	by linux.microsoft.com (Postfix) with ESMTPSA id 2C87F20D4BC1;
	Tue, 23 Nov 2021 09:49:14 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2C87F20D4BC1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1637689754;
	bh=PgeTmBL7ju5Hu2XEYAK3zfd35caVSsVggkf+elg/x7w=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=Xdi8g1s/tJtV51MESdfe801AkMWNVyDdLW6C2S38eSywvnLcjof64KP0uvMUbHhzw
	 yn+tL25DFbSGmxO2zehXXgiiD3OD9McrbLOADm6+JE7lj8ttf1zK+NhbPXHWKjc1iH
	 OlsiRg9O+rJEVGF4eQBccfZq16eUAQnQDV9vexMw=
Message-ID: <26f89d65-6707-d5fb-2889-b322f59411a4@linux.microsoft.com>
Date: Tue, 23 Nov 2021 12:49:13 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>
References: <20211123172552.1129-1-michael.d.kinney@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20211123172552.1129-1-michael.d.kinney@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 11/23/2021 12:25 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747
> 
> * Remove deprecated option /Gm that generates a warning.
> * Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT
>    profile from tools_def.txt enable debug information
> * Remove /Gs8192 option that is overriding the larger setting of
>    /GS32768 from tools_def.txt that generates a warning.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   EmulatorPkg/Win/Host/WinHost.inf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/Win/Host/WinHost.inf b/EmulatorPkg/Win/Host/WinHost.inf
> index 4d2ce19620a1..2030ac084702 100644
> --- a/EmulatorPkg/Win/Host/WinHost.inf
> +++ b/EmulatorPkg/Win/Host/WinHost.inf
> @@ -86,7 +86,7 @@ [Pcd]
>   
>   [BuildOptions]
>     MSFT:*_*_*_DLINK_FLAGS            == /out:"$(BIN_DIR)\$(BASE_NAME).exe" /base:0x10000000 /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb"
> -  MSFT:*_*_*_CC_FLAGS               == /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /Gs8192 /Zi /Gm /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
> +  MSFT:*_*_*_CC_FLAGS                = /nologo /W4 /WX /Gy /c /D UNICODE /Od /Oy- /FIAutoGen.h /EHs-c- /GF /D _CRT_SECURE_NO_WARNINGS /D _CRT_SECURE_NO_DEPRECATE
>     MSFT:*_*_*_PP_FLAGS               == /nologo /E /TC /FIAutoGen.h
>   
>     MSFT:*_VS2015_IA32_DLINK_FLAGS     = /LIBPATH:"%VS2015_PREFIX%Lib" /LIBPATH:"%VS2015_PREFIX%VC\Lib" /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib vcruntimed.lib ucrtd.lib
>