Re: [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"

[Laszlo Ersek <lersek@redhat.com>]

On 09/08/16 19:09, Shah, Tapan wrote:
> Typo..... Missing company's copyright message in both changed files*

Bah, I don't care about that for files that exist, the git log is just fine for that. :) I am aware that a copyright notice is required for new files, and I do comply with that absolutely. I also never touch copyright lines belonging to other companies (big no-no).

But, I generally don't litter my patches with RH copyright lines (or copyright line updates) for files that already exist -- other companies may require their associates to do so (I recall such hunks from Intel), but we don't do that (not just in edk2, but as far as I am aware, in any of the other projects where we modify files -- QEMU and the Linux kernel are the most direct examples I can think of).

For example, in Linux, the "arch/x86/kvm/vmx.c" file still says:

/*
 * Kernel-based Virtual Machine driver for Linux
 *
 * This module enables machines with Intel VT-x extensions to run virtual
 * machines without emulation or binary translation.
 *
 * Copyright (C) 2006 Qumranet, Inc.
 * Copyright 2010 Red Hat, Inc. and/or its affiliates.
 *
 * Authors:
 *   Avi Kivity   <avi@qumranet.com>
 *   Yaniv Kamay  <yaniv@qumranet.com>
 *
 * This work is licensed under the terms of the GNU GPL, version 2.  See
 * the COPYING file in the top-level directory.
 *
 */

Funnily enough, the Red Hat line was added in kernel commit 221d059d15f1c ("KVM: Update Red Hat copyrights") in 2010, even though RH acquired Qumranet in 2008 (according to Wikipedia).

But, I digress. I think the current patches satisfy "ShellPkg/Contributions.txt". I do thank you for pointing this out: if I were responsible for sticking the explicit (C) RH notice in every preexistent file I touch, I'd definitely fix up the patches now.

Thank you!
Laszlo

> -----Original Message-----
> From: Shah, Tapan 
> Sent: Thursday, September 08, 2016 12:09 PM
> To: 'Laszlo Ersek' <lersek@redhat.com>; edk2-devel@ml01.01.org
> Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>
> Subject: RE: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"
> 
> Missing company's copyright message in both changed filed. Code works fine on NT32.
>  
> Reviewed-by: Tapan Shah <tapandshah@hpe.com>
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Thursday, September 08, 2016 11:14 AM
> To: edk2-devel@ml01.01.org
> Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>
> Subject: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"
> 
> Tapan reported
> <https://tianocore.acgmultimedia.com/show_bug.cgi?id=112>. Since I had encountered the problem myself, and now managed to find a tiny time slot, I looked into it. Patch #2 is the fix; patch #1 cleans up a small wart that I came across while studying the code.
> 
> Public branch: <https://github.com/lersek/edk2/commits/childctrl>.
> 
> Tapan, can you please test the series, and respond with your Tested-by?
> Thanks!
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Tapan Shah <tapandshah@hpe.com>
> 
> Cheers,
> Laszlo
> 
> Laszlo Ersek (2):
>   ShellPkg/UefiHandleParsingLib: fix IN/OUT notation in child ctrlr
>     parsing
>   ShellPkg/UefiHandleParsingLib: fix retval for empty child controller
>     array
> 
>  ShellPkg/Include/Library/HandleParsingLib.h                  |  4 ++--
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 15 +++++++++++----
>  2 files changed, 13 insertions(+), 6 deletions(-)
> 
> --
> 2.9.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>