From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF4B51A1DFB for ; Thu, 8 Sep 2016 11:35:38 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EB6A13D07; Thu, 8 Sep 2016 18:35:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-57.phx2.redhat.com [10.3.116.57]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u88IZaKu018507; Thu, 8 Sep 2016 14:35:36 -0400 To: "Shah, Tapan" , "edk2-devel@ml01.01.org" References: <20160908161414.3143-1-lersek@redhat.com> Cc: Jaben Carsey , Ruiyu Ni From: Laszlo Ersek Message-ID: <26fb16df-b2c2-a65a-54a9-4815b3e6c259@redhat.com> Date: Thu, 8 Sep 2016 20:35:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 08 Sep 2016 18:35:38 +0000 (UTC) Subject: Re: [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 18:35:39 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/08/16 19:09, Shah, Tapan wrote: > Typo..... Missing company's copyright message in both changed files* Bah, I don't care about that for files that exist, the git log is just fine for that. :) I am aware that a copyright notice is required for new files, and I do comply with that absolutely. I also never touch copyright lines belonging to other companies (big no-no). But, I generally don't litter my patches with RH copyright lines (or copyright line updates) for files that already exist -- other companies may require their associates to do so (I recall such hunks from Intel), but we don't do that (not just in edk2, but as far as I am aware, in any of the other projects where we modify files -- QEMU and the Linux kernel are the most direct examples I can think of). For example, in Linux, the "arch/x86/kvm/vmx.c" file still says: /* * Kernel-based Virtual Machine driver for Linux * * This module enables machines with Intel VT-x extensions to run virtual * machines without emulation or binary translation. * * Copyright (C) 2006 Qumranet, Inc. * Copyright 2010 Red Hat, Inc. and/or its affiliates. * * Authors: * Avi Kivity * Yaniv Kamay * * This work is licensed under the terms of the GNU GPL, version 2. See * the COPYING file in the top-level directory. * */ Funnily enough, the Red Hat line was added in kernel commit 221d059d15f1c ("KVM: Update Red Hat copyrights") in 2010, even though RH acquired Qumranet in 2008 (according to Wikipedia). But, I digress. I think the current patches satisfy "ShellPkg/Contributions.txt". I do thank you for pointing this out: if I were responsible for sticking the explicit (C) RH notice in every preexistent file I touch, I'd definitely fix up the patches now. Thank you! Laszlo > -----Original Message----- > From: Shah, Tapan > Sent: Thursday, September 08, 2016 12:09 PM > To: 'Laszlo Ersek' ; edk2-devel@ml01.01.org > Cc: Jaben Carsey ; Ruiyu Ni > Subject: RE: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" > > Missing company's copyright message in both changed filed. Code works fine on NT32. > > Reviewed-by: Tapan Shah > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, September 08, 2016 11:14 AM > To: edk2-devel@ml01.01.org > Cc: Jaben Carsey ; Ruiyu Ni > Subject: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" > > Tapan reported > . Since I had encountered the problem myself, and now managed to find a tiny time slot, I looked into it. Patch #2 is the fix; patch #1 cleans up a small wart that I came across while studying the code. > > Public branch: . > > Tapan, can you please test the series, and respond with your Tested-by? > Thanks! > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Tapan Shah > > Cheers, > Laszlo > > Laszlo Ersek (2): > ShellPkg/UefiHandleParsingLib: fix IN/OUT notation in child ctrlr > parsing > ShellPkg/UefiHandleParsingLib: fix retval for empty child controller > array > > ShellPkg/Include/Library/HandleParsingLib.h | 4 ++-- > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 15 +++++++++++---- > 2 files changed, 13 insertions(+), 6 deletions(-) > > -- > 2.9.2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >