public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pedro Falcato <pedro.falcato@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ray.ni@intel.com" <ray.ni@intel.com>
Cc: "Chen, Christine" <yuwei.chen@intel.com>,
	Pierre Gondois <Pierre.Gondois@arm.com>,
	Rebecca Cran <rebecca@bsdio.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	Yeo Reum Yun <YeoReum.Yun@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id
Date: Wed, 29 Nov 2023 09:53:11 +0000	[thread overview]
Message-ID: <2719CBE9-81DE-4330-951F-21F3ADB94998@arm.com> (raw)
In-Reply-To: <CAKbZUD29RZhcqHuk8SoKBesigWtwKoJWzO_W_nO-i0CTVa-G9A@mail.gmail.com>

Hi Pedro,

On 29/11/2023, 06:40, "Pedro Falcato" <pedro.falcato@gmail.com <mailto:pedro.falcato@gmail.com>> wrote:


On Wed, Nov 29, 2023 at 12:56 AM Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com>> wrote:
>
> It's good. But I am curious why --ignore-change-id is needed?


I didn't ask, but presumably, if you have an internal gerrit instance
that runs CI before pushing, PatchCheck.py may be part of the CI
workflow; in those cases, we don't want it to error out.
So the CI would be adapted to do PatchCheck.py --ignore-change-id, and
all is well.
[SAMI] Just saw your email. You have summarised it well.

Regards,

Sami Mujawar

-- 
Pedro





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111844): https://edk2.groups.io/g/devel/message/111844
Mute This Topic: https://groups.io/mt/102748141/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-29  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 13:14 [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id PierreGondois
2023-11-23  2:11 ` Pedro Falcato
2023-11-29  0:23 ` Yuwei Chen
2023-11-29  0:56   ` Ni, Ray
2023-11-29  1:10     ` Yuwei Chen
2023-11-29  6:40     ` Pedro Falcato
2023-11-29  9:53       ` Sami Mujawar [this message]
2023-11-29  9:37     ` Sami Mujawar
2023-12-12  9:38       ` PierreGondois
2023-12-20 22:55         ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2719CBE9-81DE-4330-951F-21F3ADB94998@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox