From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.64]) by mx.groups.io with SMTP id smtpd.web11.39263.1650289672454858726 for ; Mon, 18 Apr 2022 06:47:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Kagl+MFn; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.64, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRZ5syIgjPMszprsWh92Hky583/+Fb3Lmm2tH6lI6mOGnWuFPUWHMcZW0xR1pQQYi8HXkhDOR56NTm1TswaU4Da/U572CaVT8AzrmDrQ3oLA8PflSxIfmjhW8WHuk69UjblBXKNrjSZZUsjaVF7DGXl+2b40IWccb8fAHBrD8sgXm+39MEK7Kc89I3Fp0Mt/G08fsC+sXbxfxW4/VWghKhQl+6pOWP8mCxL9+kK1SAyPyLvv/Dj4VM91w9+T2/LBeqtUde3BHZ7OcGY0+I2nB/UbWTxoNPNjyWpZxlVeNGR3TrqUD134pKJlvpFFjrqbRqk9Pf2bx+iG9JAob4rjPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uedh5w+sL+bTQlcEdynDOW2AZhVDjA3vxtX3WkZNwxU=; b=BaokaHHEmPFNI+myF1Fg88LHoyUzVomxUeIRsdZyEZg+tFDxdqMMJwvuFt+t5BcDT8JpVhIVfOAMR3qRB0h1c1o20tddtkAuzZmibJJVK+F9WJH0bVGRKshX1AV0YgH9/C+RzrfAVfY9MmkhMl2L334txbNw3m1mRaPvr507x92VHnnll5LfdiY4PFhvl19r2B+K5V2hkRdmt/js7uLb5QSbgZPFGWSyBKYyovb7kSx43GHjOuCP9D951LT9CwQtWoMYMCKKhATeU+lZqjYnxcuptht4Vl8uIFjRJKEneQ4L9JqbboAsG+30RryT2w6aFpHga8/et7vJWld6PVH3ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uedh5w+sL+bTQlcEdynDOW2AZhVDjA3vxtX3WkZNwxU=; b=Kagl+MFn2bpTIGwy21XDlaB1FlxZtn2xEpGe56mp4EoaQC2WSRQtFr4cVgurR/Q/ra4jkfhf4rRZJyc8Dw2DRuEpFKlg96pF7DK0ez4NgAnfWMmRDqzLJe0klH3riBS16w+XJtzGdJh4e5KDfODkE9SVCLezBaODXR0du1BOzcM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM8PR12MB5414.namprd12.prod.outlook.com (2603:10b6:8:3e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr 2022 13:47:50 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::781d:15d6:8f63:a4e7]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::781d:15d6:8f63:a4e7%5]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022 13:47:50 +0000 Message-ID: <2739f5ba-cad7-f98c-28ca-93eb759033cb@amd.com> Date: Mon, 18 Apr 2022 08:47:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h To: Min Xu , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , James Bottomley , Jiewen Yao , Gerd Hoffmann , Brijesh Singh , Erdem Aktas References: From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: MN2PR01CA0038.prod.exchangelabs.com (2603:10b6:208:23f::7) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: daaeb366-80a6-448f-4f3e-08da21420789 X-MS-TrafficTypeDiagnostic: DM8PR12MB5414:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bD0O1ITqaIvviLRTLJ9oPoOnWYVNruY1UNcGC0g8QGyRwAnZ2f0+RulyZ/VoSxnUntzjRV6F2d20AwQsKaMDlfM10weZ243hzJGMzWso35+mICIpMbArVGpSfxcD1kMXdXc7jTFnIoPCbd4JgooiaCQeRMdxsNpAfNYVsO41vzH2PoYlO9sIAdHfWepSmb/rv0cRybMLv+Y3OkwUagLQ2tTpMeDL8DJGLrhjciq0Tnd08DR7G1icVTyo1mtr/SFpDoAtaClWGh4hmITBs6lr/0t8YVYj8WrxjsDF62CstSmmeiS3HQ+3xi3VSxbCKTCRBigPsf9/LzppffN/C+Ks5hdfTuSMO5IjaoD8K6Mv3oCXDOqJ6wYXJa91WweuEvXvMMiEznDNis9C7xcL70jyFdiSYKJGnSwWvRr7ct9i4E9+JWHBOCqWVypO0n9ytkgGcf+zD1ySmJzJ5A/EAj5dOHrWv+y/06iyRmgTf9NCy1Vw9NYYpdqR8LDyK/iFAQYcV2GepedjDF5cdWm006KwaEvY5EgZR07rDExpjwSb0zzE9S6VWXdGRk/h5Dew9KR6mL2AXMtII/vJIk57NcYoVORkUBQeEfOlqHvFtdr0OcrsCCdPxptfTSPEx+oidw+s4kMDlg8DY0kBVZwPTbBmkEIfZSjWzD5bM0ERYIdQhuOXqENzunUS7EkZKVxuqXMmOo/wh8zXFVYAavK6Jk6NyOcUUPVzVLVcdwwDLYH5d2ky8l4JIGlIWlO5+MzMPtU5K+ywLF+OUY8HZCdM2uEVuu2ATGhBE6pXceBtC2TkSTQpyUS55j9fCYJE0SFE/Doh6tHauSAnT33i5kwlT1cMbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(2906002)(186003)(26005)(8936002)(6506007)(6486002)(966005)(4326008)(316002)(6666004)(508600001)(86362001)(31696002)(66476007)(38100700002)(66946007)(8676002)(53546011)(31686004)(6512007)(83380400001)(5660300002)(36756003)(2616005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGRkbjFrZGU0L01oZzNFZTZ1YVJ1Z0Q2c25wUFFsaUt5MDA5bURTWk5COGdR?= =?utf-8?B?TDl4ZUJncHgyQm44NHdwdkRwZC9FTGpOK0Y1MjRuS0VoUTdUZHhBc1hVWXRR?= =?utf-8?B?aUZLUnNicXlraDFrcUFvbUtZZHg4eDJ2RG4zUnNDMlJPSnY1Q2kwbHBzclRH?= =?utf-8?B?b3B2Q25UNUd6Y052OHIzMWQ2U1lrNmtPNEdqOXZsWjJYemxXQnVpa0tmNGdp?= =?utf-8?B?SCtPdTE3L3NnTHBHdFBtd0p2czE2NjQrRVVreURFVWo2R28ydy9UVGYrREhH?= =?utf-8?B?MENSMUVHQ0pkakJIZHdtdzFRaEY5ZElrZzVsQmc2b25GcUhTZ25GbVhNUVUr?= =?utf-8?B?eVo4U21pODhKOTE4N1hkSi8rV3BzSTVMUzcxK3JnWUJWV1gvTDR2WnZsZDUx?= =?utf-8?B?UE9lNU1sRldGSmJqbnpNSlcxcGZNQVMvQ3JVSS8xOWhZQTk3bzhTbGx6S0xJ?= =?utf-8?B?a1BqV2xYV1IraFpZODJyRXZiOXE5QkdZVWw2TFRiUXYzK25DTWlxVXZ2TzJO?= =?utf-8?B?aW5vMmZwbGYwZEhGcGRiT3loUm9NN0FxeUlNZHpwcTYzdURoNXl3WnF5SCtN?= =?utf-8?B?MW5ScVExbmpxQ3ZraEFRWFNCQ24yYmczN1NMMVZGU3lzeVJRVW5zb3c1cWtv?= =?utf-8?B?UkhQUXNBMS9CeTdxMVFCMCttRHdmWDdsQWtiNWdpNGxpK08zQ21GeFZGL0hH?= =?utf-8?B?YjBRUzQxdi9HK3NHMzJnMGI2b3VBbUw2RjZNa3JNWlNiNko2Y2pYMzVLWU96?= =?utf-8?B?c0kxeW1wYVBpcVYwOWt2TEZ2dUNXMFRQS2daVkF4eTVrMGpVT0cvV0w3eDJn?= =?utf-8?B?TTcyVm50eHJVZ01HYnhhMVpwUWE5MGRienl0UXNJMEJBUGR6Q0tkYjBaNzlI?= =?utf-8?B?NTBUaGpMaHRSNkNtbEg1d0hGd2w4d3RpR0Jqd1hyNG54K1JITUVrOEZUeHc0?= =?utf-8?B?Q1o0QmFaL1NnV25abEE0L2ZTMXU3WHpmTmYzY21DTERFSFJiMSt5S1lGUzk1?= =?utf-8?B?NGJhYndEUWsrWUpHcEs0RHlFSElTb2lGckQvUGFTK04waVJiMTV2YlBIUERS?= =?utf-8?B?UGRGak9Cb3hPR1FKM3VEb1dOZStHQm95eFdkdERGSWh2bHlnRTZOOXEzdnBK?= =?utf-8?B?aFd1b1NrTTA4QzNwSHQ3L3pRNllvQzhCcmZaczVRNmU0OWM3RWJGUmhDeklQ?= =?utf-8?B?QVpXelhUaUxpN2o5NDhYTkhIT0ZYTVFCZkI4U2V6UXJEM1gwR2gxd3ZHRVhi?= =?utf-8?B?WHRJZHJaZW44Vk9hczU3cy9HYlZSVXcvKysycmthd0kyb0hNaDlVM1o1Y1dJ?= =?utf-8?B?cThNTUtzSU5ld3o5RkcwdGswcVE4N0JuWEV0UWpOaUZXZE90dCtTM0hjODlU?= =?utf-8?B?Z1Z0cXJGV2tEY3pPUXV6czYrb3RNMytOWFdnbkRsemdwUUVsLzB5ZkUwdGRp?= =?utf-8?B?TlhTQUtBbUxQaWpXcHQvQUtWWEd2M0VhN1B6NFdicmlqNlR0VkM0ajduQWhY?= =?utf-8?B?WmlYZzQ0ZDJhb2JDbDcxU2Rneks0WmJNVlNyL1Zhdk83Q09yOWYrMDVYbVV1?= =?utf-8?B?eGt3U1FJOEpXOTZ0azVsYWhoZllmZklBTDdLcUF4T0EvWVdDdDI4ZGtDb08x?= =?utf-8?B?SC9vTzJYRmJiVVlScUU4T0tKS0tEM2V2eTlnRWpCMC96VVZIeVh0c1NIMlI1?= =?utf-8?B?UC9vTjNpVm16OUdNTk01dWxNNDJjQ01LaXlEM0JOM1BTbDVveW11OTRzejMz?= =?utf-8?B?N0lIY1F6aStVTGROTXRLeWJsZjIxTnVINjhjTUg0eS90ZW9ZcTN2ZlNlUkV1?= =?utf-8?B?Y0ZTeElZZG0rcWpkUnVMYUgwNmtTNy9COTFkNEpKNFNmbmFFK2dlVDMwekdN?= =?utf-8?B?R0U4ZFNrUmtrdTBEbFdidEtYT2pta2ZNSVdaalFFeVo1QkV1NFBBQUEybVNG?= =?utf-8?B?aGZPZlVOOGFFTGZvL2NJUGdtOFpUMjE4V3ZBdEVrMGFsWEVjQkFOV29lRDM0?= =?utf-8?B?cjhQblZZUHp2RVdlRk5YM284bi9MWGs4amlsUEhVSW41N0c2Z0dXMDRCUFRm?= =?utf-8?B?a1JXc0VKTXh3Z3VpQm8xOHI1eTY5TzhHNjNIR01HRVdYSVpUdWZpUE9lWmM3?= =?utf-8?B?VjUwZGZOeHJIaEwrSnRWNjFrTThSMHVDWHdYWmZRQ0xQalIzY3VZMGt1Q0Uy?= =?utf-8?B?SFB3TEJ6ak85eFo1bWQ0ZFFhOEJ4Rkc1ZlI1d3c2RXYzOTA3VzhmMTBzN0Jp?= =?utf-8?B?MGMrWmRDRVRKam1PaDVUcm9HVnBPWWcyeTdENDZGMjNPcURkN2FFSngrd0Ur?= =?utf-8?B?R09yUWFxSHhFQnRDMG5SY0d1YVNydFcyOG4vbXJtQXBreWpSUUk4dz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: daaeb366-80a6-448f-4f3e-08da21420789 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 13:47:50.5749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W4dDjCsOMCmQMVPlDGFfxWI2uUBRx7iRslmI7FquVBnQVzhE/FqF8eh9JiD4zE2jxW5zmHGWYwDdfQR0gCzkWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5414 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/16/22 22:01, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902 > > The confidential computing guest type (GUEST_TYPE) was defined in > OvmfPkg/Include/WorkArea.h. Now it is to be moved to > MdePkg/Include/ConfidentialComputingGuestAttr.h and renamed as > CC_GUEST_TYPE. > > There are 2 reasons for this change. > 1. CC_GUEST_TYPE is a generic definition and will be used in CcProbeLib > which is defined in MdePkg. > 2. Based on the latest edk2 coding style: > - First character should be upper case > - Must contain lower case characters > - No white space characters > - Global variable name must start with a 'g' > > As the first step CC_GUEST_TYPE is defined in this patch. In the > next patch GUEST_TYPE will be deleted. This is to make sure the > bisect work correctly. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: Tom Lendacky > Signed-off-by: Min Xu > --- > MdePkg/Include/ConfidentialComputingGuestAttr.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h b/MdePkg/Include/ConfidentialComputingGuestAttr.h > index dd2541c6dcdf..9e9424a01559 100644 > --- a/MdePkg/Include/ConfidentialComputingGuestAttr.h > +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h > @@ -1,5 +1,5 @@ > /** @file > -Definitions for Confidential Computing Attribute > +Definitions for Confidential Computing Guest Attributes > > Copyright (c) 2021 AMD Inc. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -9,6 +9,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #ifndef CONFIDENTIAL_COMPUTING_GUEST_ATTR_H_ > #define CONFIDENTIAL_COMPUTING_GUEST_ATTR_H_ > > +// > +// Confidential computing guest type > +// > +typedef enum { > + CCGuestTypeNonEncrypted = 0, > + CCGuestTypeAmdSev, > + CCGuestTypeIntelTdx, > +} CC_GUEST_TYPE; Should these be CcGuest... ? The precedent seems to be use lowercase even when the the acronym is uppercase, e.g. PCI => Pci, GHCB => Ghcb, SMBIOS => SmBios, NVME => Nvme, etc. Thanks, Tom > + > typedef enum { > /* The guest is running with memory encryption disabled. */ > CCAttrNotEncrypted = 0,