From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 12 Apr 2019 02:09:57 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D953E8831E; Fri, 12 Apr 2019 09:09:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-65.rdu2.redhat.com [10.10.120.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BFA95C21E; Fri, 12 Apr 2019 09:09:55 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 17/31] OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it as runned To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Jordan Justen , Ard Biesheuvel , Julien Grall , xen-devel@lists.xenproject.org References: <20190409110844.14746-1-anthony.perard@citrix.com> <20190409110844.14746-18-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: <274ac146-58a6-14c1-23c3-51ab14e6f37f@redhat.com> Date: Fri, 12 Apr 2019 11:09:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190409110844.14746-18-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 12 Apr 2019 09:09:56 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/09/19 13:08, Anthony PERARD wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenPlatformPei/Xen.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/XenPlatformPei/Xen.c b/OvmfPkg/XenPlatformPei/Xen.c > index 89933ec3e9..22c7a22c88 100644 > --- a/OvmfPkg/XenPlatformPei/Xen.c > +++ b/OvmfPkg/XenPlatformPei/Xen.c > @@ -275,7 +275,9 @@ InitializeXen ( > // Reserve away HVMLOADER reserved memory [0xFC000000,0xFD000000). > // This needs to match HVMLOADER RESERVED_MEMBASE/RESERVED_MEMSIZE. > // > - AddReservedMemoryBaseSizeHob (0xFC000000, 0x1000000, FALSE); > + if (XenHvmloaderDetected ()) { > + AddReservedMemoryBaseSizeHob (0xFC000000, 0x1000000, FALSE); > + } > > PcdStatus = PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE); > ASSERT_RETURN_ERROR (PcdStatus); > (1) please fix the subject: s/as runned/has run/ (2) please write a nonempty commit message body. With that: Acked-by: Laszlo Ersek Thanks Laszlo