Re: [PATCH 11/12] OvmfPkg/SmmControl2Dxe: save fw_cfg boot script with QemuFwCfgS3Lib

[Laszlo Ersek <lersek@redhat.com>]

On 03/14/17 14:48, Laszlo Ersek wrote:
> On 03/14/17 02:58, Kinney, Michael D wrote:
>> Laszlo,
>>
>> I agree that there are some inconsistencies in the edk2 C source files.
>>
>> For this specific example, I prefer what Jordan recommended:
>>
>>>>   Status = QemuFwCfgS3WriteBytes (
>>>>              mRequestedFeaturesItem,
>>>>              sizeof ScratchBuffer->Features
>>>>              );
>>
>> When multi-line:
>> * One argument per line
>> * Indent each argument 2 spaces from start of function name
>> * Close parenthesis aligned with start of arguments
>>
>> I am actively working on adding the EDK II C Coding standard
>> and other EDK II docs to gitbooks.  That will be a good place
>> to discuss and clarify or correct the EDK II C coding standard.
>>
>> Given inconsistencies in some of the edk2 C source files and 
>> some clarification needed in EDK II C Coding Standard, I would
>> not require any changes here.
> 
> If I understand correctly, that means v2 of this set should be acceptable.
> 
> If that's right, can you please R-b this set, Jordan?
> 
>> I would prefer everyone follow
>> this specific recommendation if possible.
> 
> I can do that, in the future, if we codify the preference in some
> written form, even before the CCS is updated and/or imported to
> gitbooks. Should we file a TianoCore BZ for it? I can do that, if you
> prefer.

I filed <https://bugzilla.tianocore.org/show_bug.cgi?id=425>.

Thanks
Laszlo