From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6101B803DA for ; Tue, 14 Mar 2017 13:38:56 -0700 (PDT) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBACE51461; Tue, 14 Mar 2017 20:38:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-194.phx2.redhat.com [10.3.116.194]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2EKctPm005064; Tue, 14 Mar 2017 16:38:56 -0400 To: "Kinney, Michael D" , "Justen, Jordan L" References: <20170223014814.10937-1-lersek@redhat.com> <20170223014814.10937-12-lersek@redhat.com> <148914088572.26490.12215430240628550434@jljusten-skl> <55e1eade-1d06-4b04-3e07-5ceef61a5602@redhat.com> <148944077646.15816.5488638936147140185@jljusten-skl> <148944501645.16415.6726175929038559977@jljusten-skl> Cc: edk2-devel-01 From: Laszlo Ersek Message-ID: <274f6338-82de-db08-61dd-f3109761a11d@redhat.com> Date: Tue, 14 Mar 2017 21:38:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 14 Mar 2017 20:38:56 +0000 (UTC) Subject: Re: [PATCH 11/12] OvmfPkg/SmmControl2Dxe: save fw_cfg boot script with QemuFwCfgS3Lib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 20:38:56 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/14/17 14:48, Laszlo Ersek wrote: > On 03/14/17 02:58, Kinney, Michael D wrote: >> Laszlo, >> >> I agree that there are some inconsistencies in the edk2 C source files. >> >> For this specific example, I prefer what Jordan recommended: >> >>>> Status = QemuFwCfgS3WriteBytes ( >>>> mRequestedFeaturesItem, >>>> sizeof ScratchBuffer->Features >>>> ); >> >> When multi-line: >> * One argument per line >> * Indent each argument 2 spaces from start of function name >> * Close parenthesis aligned with start of arguments >> >> I am actively working on adding the EDK II C Coding standard >> and other EDK II docs to gitbooks. That will be a good place >> to discuss and clarify or correct the EDK II C coding standard. >> >> Given inconsistencies in some of the edk2 C source files and >> some clarification needed in EDK II C Coding Standard, I would >> not require any changes here. > > If I understand correctly, that means v2 of this set should be acceptable. > > If that's right, can you please R-b this set, Jordan? > >> I would prefer everyone follow >> this specific recommendation if possible. > > I can do that, in the future, if we codify the preference in some > written form, even before the CCS is updated and/or imported to > gitbooks. Should we file a TianoCore BZ for it? I can do that, if you > prefer. I filed . Thanks Laszlo