[edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[Robert Phelps]

The following patches contain the new definitions for new events that
were added in UEFI 2.9: Before Exit Boot Services and After Ready to
Boot.  The second patch adds the call to signal the Before Exit Boot
Services Event in DxeMain.c and the addition of the GUID in the INF
file DxeMain.inf.


Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
Signed-off-by: Robert Phelps <robert@ami.com>

Robert Phelps (2):
  MdePkg: Add New Event Definitions from UEFI 2.9
  MdeModulePkg: Added call to signal New Event

 MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
 MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
 MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
 MdePkg/MdePkg.dec                       |  6 ++++++
 4 files changed, 19 insertions(+)

--
2.36.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 1/2] MdePkg: Add New Event Definitions from UEFI 2.9

[Robert Phelps]

Add Before Exit Boot Services Event and After Ready To Boot Event Definitions



Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]

Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]

Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]



Signed-off-by: Robert Phelps <robert@ami.com>


---
 MdePkg/Include/Guid/EventGroup.h | 10 ++++++++++
 MdePkg/MdePkg.dec                |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/MdePkg/Include/Guid/EventGroup.h b/MdePkg/Include/Guid/EventGroup.h
index 063d1f7157..37399f5e0c 100644
--- a/MdePkg/Include/Guid/EventGroup.h
+++ b/MdePkg/Include/Guid/EventGroup.h
@@ -9,6 +9,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #ifndef __EVENT_GROUP_GUID__

 #define __EVENT_GROUP_GUID__



+#define EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES \

+  { 0x8be0e274, 0x3970, 0x4b44, { 0x80, 0xc5, 0x1a, 0xb9, 0x50, 0x2f, 0x3b, 0xfc } }

+

+extern EFI_GUID gEfiEventBeforeExitBootServicesGuid;

+

 #define EFI_EVENT_GROUP_EXIT_BOOT_SERVICES \

   { 0x27abf055, 0xb1b8, 0x4c26, { 0x80, 0x48, 0x74, 0x8f, 0x37, 0xba, 0xa2, 0xdf } }



@@ -29,6 +34,11 @@ extern EFI_GUID  gEfiEventMemoryMapChangeGuid;


 extern EFI_GUID  gEfiEventReadyToBootGuid;



+#define EFI_EVENT_GROUP_AFTER_READY_TO_BOOT \

+  { 0x3a2a00ad, 0x98b9, 0x4cdf, { 0xa4, 0x78, 0x70, 0x27, 0x77, 0xf1, 0xc1, 0xb } }

+

+extern EFI_GUID  gEfiEventAfterReadyToBootGuid;

+

 #define EFI_EVENT_GROUP_DXE_DISPATCH_GUID \

   { 0x7081e22f, 0xcac6, 0x4053, { 0x94, 0x68, 0x67, 0x57, 0x82, 0xcf, 0x88, 0xe5 }}



diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 4c81cbd75a..05b6f63323 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -408,12 +408,18 @@
   ## Include/Guid/EventGroup.h

   gEfiEventReadyToBootGuid       = { 0x7CE88FB3, 0x4BD7, 0x4679, { 0x87, 0xA8, 0xA8, 0xD8, 0xDE, 0xE5, 0x0D, 0x2B }}



+  ## Include/Guid/EventGroup.h

+  gEfiEventAfterReadyToBootGuid  = { 0x7081e22f, 0xcac6, 0x4053, { 0x94, 0x68, 0x67, 0x57, 0x82, 0xcf, 0x88, 0xe5 }}

+

   ## Include/Guid/EventGroup.h

   gEfiEventMemoryMapChangeGuid   = { 0x78BEE926, 0x692F, 0x48FD, { 0x9E, 0xDB, 0x01, 0x42, 0x2E, 0xF0, 0xD7, 0xAB }}



   ## Include/Guid/EventGroup.h

   gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { 0x87, 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }}



+  ## Include/Guid/EventGroup.h

+  gEfiEventBeforeExitBootServicesGuid = { 0x8be0e274, 0x3970, 0x4b44, { 0x80, 0xc5, 0x1a, 0xb9, 0x50, 0x2f, 0x3b, 0xfc } }

+

   ## Include/Guid/EventGroup.h

   gEfiEventExitBootServicesGuid  = { 0x27ABF055, 0xB1B8, 0x4C26, { 0x80, 0x48, 0x74, 0x8F, 0x37, 0xBA, 0xA2, 0xDF }}



--
2.36.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Robert Phelps]

This code signals the Before Exit Boot Services event at the beginning
of the ExitBootServices() function.  This gives all the rest of the
code to prepare for the ExitBootServices event.

Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdeModulePkg/Core/Dxe/DxeMain.inf       | 1 +
 MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
index e4bca89577..346bfa7e89 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain.inf
+++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
@@ -122,6 +122,7 @@
   gEfiMemoryAttributesTableGuid                 ## SOMETIMES_PRODUCES   ## SystemTable
   gEfiEndOfDxeEventGroupGuid                    ## SOMETIMES_CONSUMES   ## Event
   gEfiHobMemoryAllocStackGuid                   ## SOMETIMES_CONSUMES   ## SystemTable
+  gEfiEventBeforeExitBootServicesGuid           ## PRODUCES   ## Event

 [Ppis]
   gEfiVectorHandoffInfoPpiGuid                  ## UNDEFINED # HOB
diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
index 5733f0c8ec..1417f0eaa8 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
+++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
@@ -763,6 +763,8 @@ CoreExitBootServices (
 {
   EFI_STATUS  Status;

+  // Before-exit-boot-services event
+  CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid);
   //
   // Disable Timer
   //
--
2.36.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Dionna Glaze]

>
> This code signals the Before Exit Boot Services event at the beginning
> of the ExitBootServices() function.  This gives all the rest of the
> code to prepare for the ExitBootServices event.
>

Hi Robert, I think we're both trying to do this at the same time. See
the patch series "SEV-SNP accepted memory and BeforeExitBootServices"
which suppose now is not appropriately titled since Michael asked me
to add the AfterReadyToBoot event.

-- 
-Dionna Glaze, PhD (she/her)

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Robert Phelps]

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Dionna,

So how should we want to handle this.  Leave yours in or leave mine in.

[-- Attachment #2: Type: text/html, Size: 103 bytes --]

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Dionna Glaze]

> So how should we want to handle this.  Leave yours in or leave mine in.

Given that I'm not particularly confident in how I've implemented the
after_ready_to_boot spec, and you haven't implemented it, I'm not
sure. I'm pursuing the before_exit_boot_services implementation to
solve a problem in confidential compute as part of my job, so I think
I have the motivation to keep pushing on this. Let's go with mine
since it's further along. I'd appreciate a Reviewed-by if you agree
with the implementations.

-- 
-Dionna Glaze, PhD (she/her)

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Michael D Kinney]

I am confused.  I see patches related to ReadyToBoot and ExitBootServices and they mix what is in description and what is in code.

I recommend you coordinate and put together a clean set of patches for these topics.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dionna Glaze via groups.io
> Sent: Wednesday, November 9, 2022 8:22 AM
> To: Robert Phelps <robert@ami.com>
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
> 
> > So how should we want to handle this.  Leave yours in or leave mine in.
> 
> Given that I'm not particularly confident in how I've implemented the
> after_ready_to_boot spec, and you haven't implemented it, I'm not
> sure. I'm pursuing the before_exit_boot_services implementation to
> solve a problem in confidential compute as part of my job, so I think
> I have the motivation to keep pushing on this. Let's go with mine
> since it's further along. I'd appreciate a Reviewed-by if you agree
> with the implementations.
> 
> --
> -Dionna Glaze, PhD (she/her)
> 
> 
> 
> 

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Dionna Glaze]

>
> I am confused.  I see patches related to ReadyToBoot and ExitBootServices and they mix what is in description and what is in code.
>

Will you please comment on the patches in question where the error is?
I don't follow what you're saying.

> I recommend you coordinate and put together a clean set of patches for these topics.
>

Sounds good.


-- 
-Dionna Glaze, PhD (she/her)

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Robert Phelps]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

Dionna,

I can create a new patch that contains, the two Event definitions and the code that signals both events.  I can use my patches that I already have and then add the code from your submission that signals the After Ready to Boot event to that.

Rob

[-- Attachment #2: Type: text/html, Size: 294 bytes --]

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

[Dionna Glaze]

>
> I can create a new patch that contains, the two Event definitions and the code that signals both events.  I can use my patches that I already have and then add the code from your submission that signals the After Ready to Boot event to that.
>
> Rob

I think since Jiewen and Ard already acked my patches for
before_exit_boot_services, you might be better served by just rebasing
your after_ready_to_boot changes on my v1 series, since Michael has
said he doesn't want the after_ready_to_boot changes I had in v2.

-- 
-Dionna Glaze, PhD (she/her)

Re: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[Michael D Kinney]

Hi Robert,

I do not see the signal of the after exit boot services event.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Robert Phelps via groups.io
> Sent: Tuesday, November 8, 2022 12:28 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> 
> The following patches contain the new definitions for new events that
> were added in UEFI 2.9: Before Exit Boot Services and After Ready to
> Boot.  The second patch adds the call to signal the Before Exit Boot
> Services Event in DxeMain.c and the addition of the GUID in the INF
> file DxeMain.inf.
> 
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> Signed-off-by: Robert Phelps <robert@ami.com>
> 
> Robert Phelps (2):
>   MdePkg: Add New Event Definitions from UEFI 2.9
>   MdeModulePkg: Added call to signal New Event
> 
>  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
>  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
>  MdePkg/MdePkg.dec                       |  6 ++++++
>  4 files changed, 19 insertions(+)
> 
> --
> 2.36.1.windows.1
> -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this
> message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all
> copies of the transmission.
> 
> 
> 
> 

Re: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[Robert Phelps]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Mike,

I did not create the code to signal the After Exit Boot Services event.  Just the code that defines the event.  I noticed that another submission authored by Dionna Glaze adds the code to signal the event.
[PATCH v2 4/4] MdePkg: Signal AfterReadyToBoot after ReadyToBoot

[-- Attachment #2: Type: text/html, Size: 336 bytes --]

回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[gaoliming]

Robert:
  EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2022年11月9日 6:45
> 收件人: devel@edk2.groups.io; robert@ami.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> 主题: RE: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> 
> Hi Robert,
> 
> I do not see the signal of the after exit boot services event.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Robert
> Phelps via groups.io
> > Sent: Tuesday, November 8, 2022 12:28 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> >
> > The following patches contain the new definitions for new events that
> > were added in UEFI 2.9: Before Exit Boot Services and After Ready to
> > Boot.  The second patch adds the call to signal the Before Exit Boot
> > Services Event in DxeMain.c and the addition of the GUID in the INF
> > file DxeMain.inf.
> >
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> > Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> > Signed-off-by: Robert Phelps <robert@ami.com>
> >
> > Robert Phelps (2):
> >   MdePkg: Add New Event Definitions from UEFI 2.9
> >   MdeModulePkg: Added call to signal New Event
> >
> >  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
> >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
> >  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
> >  MdePkg/MdePkg.dec                       |  6 ++++++
> >  4 files changed, 19 insertions(+)
> >
> > --
> > 2.36.1.windows.1
> > -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication
> > is intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this
> > message is not the intended recipient, you are on notice that any
> distribution of this message, in any form, is strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all
> > copies of the transmission.
> >
> >
> > 
> >

Re: 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[Robert Phelps]

Liming,

I can add that, but I was wondering if you have a preference of one of the following:
1)  add to the EfiSignalReadyToBoot Function and create, signal, and close the AfterReadyToBoot Event
2) create a new function EfiSignalAfterReadyToBoot and call that from BmBoot.c
3) have all the code that would be in the EfiSignalAfterReadyToBoot Function inline in the EfiBootManagerBoot function.

Rob

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, December 06, 2022 20:08
To: 'Kinney, Michael D' <michael.d.kinney@intel.com>; devel@edk2.groups.io; Robert Phelps <Robert@ami.com>
Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan' <dandan.bi@intel.com>
Subject: [EXTERNAL] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Robert:
  EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event.

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2022年11月9日 6:45
> 收件人: devel@edk2.groups.io; robert@ami.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> 主题: RE: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
>
> Hi Robert,
>
> I do not see the signal of the after exit boot services event.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Robert
> Phelps via groups.io
> > Sent: Tuesday, November 8, 2022 12:28 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in
> > UEFI 2.9
> >
> > The following patches contain the new definitions for new events
> > that were added in UEFI 2.9: Before Exit Boot Services and After
> > Ready to Boot.  The second patch adds the call to signal the Before
> > Exit Boot Services Event in DxeMain.c and the addition of the GUID
> > in the INF file DxeMain.inf.
> >
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> > Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> > Signed-off-by: Robert Phelps <robert@ami.com>
> >
> > Robert Phelps (2):
> >   MdePkg: Add New Event Definitions from UEFI 2.9
> >   MdeModulePkg: Added call to signal New Event
> >
> >  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
> >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
> >  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
> >  MdePkg/MdePkg.dec                       |  6 ++++++
> >  4 files changed, 19 insertions(+)
> >
> > --
> > 2.36.1.windows.1
> > -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication
> > is intended to be read only by the individual or entity to whom it
> > is
> addressed or by their designee. If the reader of this
> > message is not the intended recipient, you are on notice that any
> distribution of this message, in any form, is strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all
> > copies of the transmission.
> >
> >
> > 
> >



-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[gaoliming]

Rob:
  I suggest to only update EfiSignalEventReadyToBoot () API in UefiLib to trig ReadyToBoot and AfterReadyToBoot event both. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Robert Phelps
> via groups.io
> 发送时间: 2022年12月15日 1:50
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; devel@edk2.groups.io
> 抄送: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan'
> <dandan.bi@intel.com>
> 主题: Re: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in
> UEFI 2.9
> 
> Liming,
> 
> I can add that, but I was wondering if you have a preference of one of the
> following:
> 1)  add to the EfiSignalReadyToBoot Function and create, signal, and close
> the AfterReadyToBoot Event
> 2) create a new function EfiSignalAfterReadyToBoot and call that from
> BmBoot.c
> 3) have all the code that would be in the EfiSignalAfterReadyToBoot Function
> inline in the EfiBootManagerBoot function.
> 
> Rob
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, December 06, 2022 20:08
> To: 'Kinney, Michael D' <michael.d.kinney@intel.com>; devel@edk2.groups.io;
> Robert Phelps <Robert@ami.com>
> Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan'
> <dandan.bi@intel.com>
> Subject: [EXTERNAL] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI
> 2.9
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Robert:
>   EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in
> Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > 发送时间: 2022年11月9日 6:45
> > 收件人: devel@edk2.groups.io; robert@ami.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > 主题: RE: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
> >
> > Hi Robert,
> >
> > I do not see the signal of the after exit boot services event.
> >
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Robert
> > Phelps via groups.io
> > > Sent: Tuesday, November 8, 2022 12:28 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > > Subject: [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in
> > > UEFI 2.9
> > >
> > > The following patches contain the new definitions for new events
> > > that were added in UEFI 2.9: Before Exit Boot Services and After
> > > Ready to Boot.  The second patch adds the call to signal the Before
> > > Exit Boot Services Event in DxeMain.c and the addition of the GUID
> > > in the INF file DxeMain.inf.
> > >
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> > > Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
> > > Signed-off-by: Robert Phelps <robert@ami.com>
> > >
> > > Robert Phelps (2):
> > >   MdePkg: Add New Event Definitions from UEFI 2.9
> > >   MdeModulePkg: Added call to signal New Event
> > >
> > >  MdeModulePkg/Core/Dxe/DxeMain.inf       |  1 +
> > >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c |  2 ++
> > >  MdePkg/Include/Guid/EventGroup.h        | 10 ++++++++++
> > >  MdePkg/MdePkg.dec                       |  6 ++++++
> > >  4 files changed, 19 insertions(+)
> > >
> > > --
> > > 2.36.1.windows.1
> > > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication
> > > is intended to be read only by the individual or entity to whom it
> > > is
> > addressed or by their designee. If the reader of this
> > > message is not the intended recipient, you are on notice that any
> > distribution of this message, in any form, is strictly
> > > prohibited. Please promptly notify the sender by reply e-mail or by
> > telephone at 770-246-8600, and then delete or destroy all
> > > copies of the transmission.
> > >
> > >
> > >
> > >
> 
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[Robert Phelps]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

I have an update for this, do I just resubmit with new changes, or do I somehow attach it to what has already been posted

[-- Attachment #2: Type: text/html, Size: 123 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Please send a new patch series email.  Should be marked as V2.  This is done with git send-email option:

--subject-prefix="Patch v2"

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Robert Phelps via groups.io
Sent: Wednesday, January 11, 2023 11:12 AM
To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Subject: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

I have an update for this, do I just resubmit with new changes, or do I somehow attach it to what has already been posted


[-- Attachment #2: Type: text/html, Size: 40396 bytes --]