From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id BAA8A7803DE for ; Fri, 19 Apr 2024 10:02:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ThcZTZ1TYUmSP8qiyLyqrrEeTUagSFGJLXyIbfwHEQg=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1713520974; v=1; b=HRGdsa0t3XXZwwsds5eW846UzHh3z6U3IRgpHDE1Bf5d3uTFeJTTNipKX9uauywAug5v4jAF YqD2w9Od3Zwdl9RT5/z+WUGKfs6hivfSSAiODai/X/z2d0AhbdRrgNOc8dA9FT/NdUsKnEMe2nL zr5xWuS2t+HW7Sq1JdXIfnfoSdOuqklgPnWdtboBqL6IFKk2cK9GSY84U543XWZlgWQV0Uohu9o n9sYGyXvtSqyExdxasLiH/1ljf33fpsuTiFHiNaGSrLTcrk1AI00cKGkYlaSqAaoDrujSaYciqB v7QQgeJ3CgqEvUlLSTXBm0AXHu3gY42yMjfZOSreucnbQ== X-Received: by 127.0.0.2 with SMTP id w67WYY7687511xI1nbEMDVV5; Fri, 19 Apr 2024 03:02:54 -0700 Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpBootDxe: Correctly uninstall HttpBootCallbackProtocol To: "Michael Brown" , devel@edk2.groups.io From: "Mike Beaton" X-Originating-Location: Burgess Hill, England, GB (217.40.85.4) X-Originating-Platform: Windows Chrome 124 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 19 Apr 2024 03:02:53 -0700 References: <0102018eb46489d7-9d4baa6c-98e6-4ef5-a477-1beeb1980005-000000@eu-west-1.amazonses.com> In-Reply-To: <0102018eb46489d7-9d4baa6c-98e6-4ef5-a477-1beeb1980005-000000@eu-west-1.amazonses.com> Message-ID: <2759.1713520973467563953@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7JkhqqteNL20eM8Crkr11Ywpx7686176AA= Content-Type: multipart/alternative; boundary="sh5vjjmaliZHBullWofS" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=HRGdsa0t; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --sh5vjjmaliZHBullWofS Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Dear Michael, I don't know if you had time to answer one follow-up question. Obviously one thing that someone might want to do is to notify on protocol = installs and trap installs of this protocol - e.g. so that something other = than UefiBootManagerLib can manage and monitor HTTP boot, but still allowin= g the original callback to occur, by hooking it. Not sure if this counts as= 'supported' or not (possibly not...) though I think it may count as 'quite= likely to happen'. However, one could hook in such a way that the uninstal= l would succeed anyway, assuming that the function pointer within the origi= nal installed protocol is writeable. My question is: was the above is roughly what you were thinking of, that mi= ght cause the assert to fail, or, if not, if you had the time to give a ver= y brief sketch of what else it might be=C2=A0(just a plausible, very rough = example)? Certainly not saying you're wrong, just that it would be helpful = (to me!) to understand what sort of thing you were thinking of! Many thanks in advance for any time you might have to reply. Mike Beaton -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118016): https://edk2.groups.io/g/devel/message/118016 Mute This Topic: https://groups.io/mt/105368366/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --sh5vjjmaliZHBullWofS Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Dear Michael,

I don't know if you had time to answer one follow-= up question.

Obviously one thing that someone might want to do i= s to notify on protocol installs and trap installs of this protocol - e.g. = so that something other than UefiBootManagerLib can manage and monitor HTTP= boot, but still allowing the original callback to occur, by hooking it. No= t sure if this counts as 'supported' or not (possibly not...) though I thin= k it may count as 'quite likely to happen'. However, one could hook in such= a way that the uninstall would succeed anyway, assuming that the function = pointer within the original installed protocol is writeable.

My = question is: was the above is roughly what you were thinking of, that might= cause the assert to fail, or, if not, if you had the time to give a very b= rief sketch of what else it might be (just a plausible, very rough exa= mple)? Certainly not saying you're wrong, just that it would be helpful (to= me!) to understand what sort of thing you were thinking of!

Man= y thanks in advance for any time you might have to reply.

Mike B= eaton
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118016) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--sh5vjjmaliZHBullWofS--