From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.8328.1586437652905057375
 for <devel@edk2.groups.io>;
 Thu, 09 Apr 2020 06:07:33 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F5F130E;
	Thu,  9 Apr 2020 06:07:32 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF0313F73D;
	Thu,  9 Apr 2020 06:07:31 -0700 (PDT)
Subject: Re: [PATCH 1/1] ArmVirtPkg: Include NVMe support in ArmVirtQemu*
To: Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io
Cc: Laszlo Ersek <lersek@redhat.com>,
 Leendert van Doorn <leendert@microsoft.com>
References: <20200409121050.15387-1-leif@nuviainc.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <27590721-972f-7d2f-d5d9-d8c8a77d0199@arm.com>
Date: Thu, 9 Apr 2020 15:07:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200409121050.15387-1-leif@nuviainc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/9/20 2:10 PM, Leif Lindholm wrote:
> From: Leendert van Doorn <leendert@microsoft.com>
> 
> Enable conditional support for NVMe storage in ArmVirtQemu/
> QemVirtQemuKernel in order to simplify booting/installing operating
> systems that don't support virtio.
> 
> [Conditionalised driver inclusion]

Why?

> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
>   ArmVirtPkg/ArmVirtQemu.dsc           | 8 ++++++++
>   ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 7 +++++++
>   ArmVirtPkg/ArmVirtQemuKernel.dsc     | 8 ++++++++
>   3 files changed, 23 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 8c77fc46427b..6f93032ac064 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -28,6 +28,7 @@ [Defines]
>     # -D FLAG=VALUE
>     #
>     DEFINE TTY_TERMINAL            = FALSE
> +  DEFINE NVME_ENABLE             = FALSE
>     DEFINE SECURE_BOOT_ENABLE      = FALSE
>     DEFINE TPM2_ENABLE             = FALSE
>     DEFINE TPM2_CONFIG_ENABLE      = FALSE
> @@ -447,6 +448,13 @@ [Components.common]
>     MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>     MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
>   
> +  #
> +  # NVME Driver
> +  #
> +!if $(NVME_ENABLE) == TRUE
> +  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +!endif
> +
>     #
>     # SMBIOS Support
>     #
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index aaba0b1c8840..45f0dd65be33 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -128,6 +128,13 @@ [FV.FvMain]
>     INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>     INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
>   
> +  #
> +  # NVME Driver
> +  #
> +!if $(NVME_ENABLE) == TRUE
> +  INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +!endif
> +
>     #
>     # SMBIOS Support
>     #
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 4d82a77213ec..5dd4b1cf29f4 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -28,6 +28,7 @@ [Defines]
>     # -D FLAG=VALUE
>     #
>     DEFINE TTY_TERMINAL            = FALSE
> +  DEFINE NVME_ENABLE             = FALSE
>     DEFINE SECURE_BOOT_ENABLE      = FALSE
>   
>     #
> @@ -382,6 +383,13 @@ [Components.common]
>     MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>     MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
>   
> +  #
> +  # NVME Driver
> +  #
> +!if $(NVME_ENABLE) == TRUE
> +  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
> +!endif
> +
>     #
>     # SMBIOS Support
>     #
>