From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D3BC803B1 for ; Thu, 23 Mar 2017 11:27:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8344F3DBD8; Thu, 23 Mar 2017 18:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8344F3DBD8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8344F3DBD8 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31F7577EC0; Thu, 23 Mar 2017 18:27:09 +0000 (UTC) To: Qin Long , edk2-devel@lists.01.org References: <20170323131932.6168-1-qin.long@intel.com> <20170323131932.6168-2-qin.long@intel.com> Cc: ting.ye@intel.com, jiaxin.wu@intel.com, ard.biesheuvel@linaro.org, glin@suse.com, ronald.cron@arm.com, Moso.Lee@citrix.com, thomas.palmer@hpe.com, David Woodhouse From: Laszlo Ersek Message-ID: <2764f116-c4a5-244a-9556-45f9025c07b3@redhat.com> Date: Thu, 23 Mar 2017 19:27:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170323131932.6168-2-qin.long@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 23 Mar 2017 18:27:12 +0000 (UTC) Subject: Re: [PATCH v2 01/11] CryptoPkg/OpensslLib: Update INF files to support OpenSSL-1.1.0x build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 18:27:12 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/23/17 14:19, Qin Long wrote: > Update OpensslLib INF files to support OpenSSL-1.1.0x source build. > The file list was generated from the latest OpenSSL-1.1.0e release. > > Main changes to support OpensslLib build in this patch include: > 1. Use "openssl" instead of "openssl-x.x.xx" as main source directory, > Also update include path in CryptoPkg.dec > 2. Enable warnings in GCC builds; > 3. Update Visual Studio build options to silence current possible build > warnings. > 4. Move the default opensslconf.h to Include/openssl, and add one dummy > dso_conf.h for native UEFI build. > > The OpensslLib module build was validated as > build -t VSXXXX -a XX -p CryptoPkg/CryptoPkg.dsc > -m CryptoPkg/Library/OpensslLib/OpensslLib.inf > > (NOTE: The extra build options for ARM/RVCT/XCODE were kept, which expect > further optimizations from community) > > Cc: Ting Ye > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Ronald Cron > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: David Woodhouse > Signed-off-by: Qin Long > --- > CryptoPkg/CryptoPkg.dec | 8 +- > CryptoPkg/Include/OpenSslSupport.h | 7 + > CryptoPkg/Include/internal/dso_conf.h | 0 > CryptoPkg/Include/openssl/opensslconf.h | 308 ++++++++ > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 866 +++++++++++----------- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 793 ++++++++++---------- > CryptoPkg/Library/OpensslLib/opensslconf.h | 497 ------------- > 7 files changed, 1142 insertions(+), 1337 deletions(-) > create mode 100644 CryptoPkg/Include/internal/dso_conf.h > create mode 100644 CryptoPkg/Include/openssl/opensslconf.h > delete mode 100644 CryptoPkg/Library/OpensslLib/opensslconf.h Acked-by: Laszlo Ersek Tested-by: Laszlo Ersek (Tested as described in .) Thanks! Laszlo